vedmack / feedback_me Goto Github PK

View Code? Open in Web Editor NEW

187.0 187.0 80.0 173 KB

jQuery Feedback Me Plugin

Home Page: http://feedback-me.appspot.com/

License: MIT License

CSS 29.62% JavaScript 70.38%

feedback_me's People

Contributors

Stargazers

Watchers

Forkers

myusernamejeep nvdnkpr animadverto mustaqsheikh silvap-javier robertlread mrova miguelfontanes voronoy movibe ozzieperez owtp a973c audas drdavidpier webdudi fallenecko jamgdm renamathai vladimirtsyupko sefcha swardesh szmufo vivekavardhana freshxopensource sally83 jeetank iamemilywing sonukry trevorfox jyotiraj sparkinzy lilbro1062000 madmanmonty vishal21st chabito79 eddvdm blaisep starof cuttingedgehobbies tolmanator marwahs michalwkrak wiersmam alexhenkel t2design manidip iamlibo avbrychak jujote jayvi marchampson millawell hafeez3000 tmlpstats rahdean91 hakimkal kevinmickey somenerd sunny151091 webappcreations chunlin428 viniciusbitten paperpixelation paouriel kosenkolubomir sandeep20162017 cleyan owainthomas ronwil cnellis hobo71 anbang wsjake scorion navarajlamichhane r4ndsen surveyormarket technodiver

feedback_me's Issues

Remove jQueryUI dependencies

It shouldn't have been there from the start :)

So the only required library that will be needed to run the feedback_me plugin will be jQuery.

It isn't possible to use two or more plugin per page.

If user needs to use two or more plugins per page (for example: feedback and sendRequest). Both plugins show but only on works.

Please, add possibility to use two or more plugin per page.

fix jquery version check for using on instead of delegate (IE issue)

Thanks to Molkobain for pointing that out, #12 (comment)

the check for jquery version should be fixed to support newer version of jquery in which the version check $().jquery > 1.7 fails (like 1.10.2)

not that its strange but only IE complains...

delayed_options - custom template

First of all - thx for this plugin - great job!

It would be nice to have custom template for delayed_options.

Mutiple feedback doesn't work properly in IE8 and IE9

IE8 - second forms isn't opened if click on it.
IE8 and IE9 - buttons disappear if click on center of page

do tags into clickable tags filters for datatable - yadcf

I post here my question http://stackoverflow.com/questions/29005929/do-tags-into-clickable-tags-filters-for-jquery-table-yadcf

I refer to this example:

http://yadcf-showcase.appspot.com/DOM_source_select2.html

I would like add for every tag in column 4 a clickable filtering feature so I can display rows that contains tag1 or tag2 only.

Just another thing
I see that the number of values remains 8 for the Country column and does not change if the number of rows contains perhaps only 2 states. Is possible to fix this because I have a several number of countries or cities?

Thanks

Confirmation message after send

Hi,
It would be great if you could add some kind of message (maybe next to the submit button) when the message was send correctly. Because I think without this kind of message ppl will not know if message was send or not.

Thanks

Is it possible to have it appear on the bottom of the page?

I see the positioning options for left and right but I was wondering if there was a way to get it to appear in the bottom right corner instead of the right bottom corner?

ajax.beforeSend overriding

With overriding ajax.beforeSend in plugin - global handler in $.ajaxSetup.beforeSend will be not executed.

Doesn't work with jQuery.noConflict

Unfortunately it doesn't work with noConflict.
If i remove: var myFeedback = jQuery.noConflict();
and replace myFeedback with $ it works again.
my Source:

<!DOCTYPE html>
<html><head>
<meta http-equiv="content-type" content="text/html; charset=windows-1252">
<meta http-equiv="X-UA-Compatible" content="IE=Edge">
<title>Feedback Me clean example</title>
<link href="css/jquery.feedback_me.css" rel="stylesheet" type="text/css">
<script src="http://code.jquery.com/jquery-1.11.0.min.js"></script>
<script type="text/javascript" src="js/jquery.feedback_me.js"></script>

<script type="text/javascript">
    var myFeedback = jQuery.noConflict();
    myFeedback(document).ready(function(){
        //set up some basic options for the feedback_me plugin
        fm_options = {
            position: "left-bottom",
            name_required: true,
            message_placeholder: "Go ahead, type your feedback here...",
            message_required: true,
            show_asterisk_for_required: true,
            feedback_url: "send_feedback_clean",
            custom_params: {
                csrf: "my_secret_token",
                user_id: "john_doe",
                feedback_type: "clean"
            },
            delayed_options: {
                send_fail : "Sending failed :(.",
                send_success : "Sent successfully :) !"
            }
        };
        //init feedback_me plugin
        fm.init(fm_options);

    });
</script>

</head><body> </body>
</html>

Option name misspelled

The option name for "boostrap" is misspelled, it is currently "bootsrtap".

It looks like there are only two places in the javascript:

The readme and example pages also use the misspelling, not sure if it's anywhere else in the code.

Is it possible to open iframe as feedback tab?

I want to keep the feedback UI and controls in my control. Is it possible for you to create an example which opens an iframe when a feedback tab is clicked ?

This would be a massive win for this plugin as it would allow any kind of form and validation as part of feedback UI, it could be used for any other purposes as well !

External IFrame Example isn't working after latest update.

I am going to use multiple feedbacks together external iFrame.
But iFrame example doesn't work after latest update.
It gets next error in console:
TypeError: className is undefined
if (className.indexOf('left-top') !== -1) {
(line 205)

Custom variable name

Hi,

I'm just starting with your plugin so I can't really make a feedback now, but for what I've saw, it would be nice to be able to choose our own variable name and not the mandatory "fm".

Some might already have that somewhere or just want to name it properly regarding their naming convention.

Thanks !

Add the ability to send custom params to server (key/value pair)

Can be used to pass csrf token / session_id / user_id etc...)

Feature Request: a cancel button

It would be nice to have the option to have a cancel button that sits next to the send button. When clicked, the cancel button will clear the forms and will close the feedback dialog.

message sent even if the field contains only white spaces

Hello,
the plugin send the message even
if the user fill the fields with only white spaces
I tried to control by modifying the js script line 388
name_required = fm_options.name_required ? "required pattern=".\S+." " : "",
but if the user click 2 or 3 times on send button the message is sent

Can you please help me to block the users to send only white spaces

Thanks for your help

Request To Add Options For Configuring The Plugin Position

Hi Daniel,

Great Work..!

Could you add the support to configure the feedback positioning ? Right now the plugin slides out of left-center

I see possible combinations are,

top-left [ Plugin Slides Out from Top Left Corner adn so on..]
top-center
top-right
mid-left
mid-right
bottom-left
bottom-center
bottom-right

How challenging this implementation is ? Feasible ? !!! I would love to test the same on multiple browsers and give you the feedback.

I believe the ability configure the above options would make a very good differentiation !

Minor Class Name Typos

There and there, it says
feedback-sucess-message
and
feedback-sucess-fail-message-inner
which should be "success", with two 'c's.

adding project to bower

Are there any plans to put this project on bower ?

IE8 and older don't slide after send

Hi,
Great job with jquery feedback me.

I have a problem with IE8 (and older). When I fill out all required fields, I click send and trigger "feedback" disappear but feedback_content don't slide back.

I think that feedback_trigger disappear because it slide back to the side below the feedback_content and feedback_content stays slide out.

Any advice?
Thank you.

google crome issue

I am using google crome as browser. But button is not displaying proper

Dismiss on click outside of box

Can you make it so that the form dismisses when the user clicks outside of the box? This would make it consistent with other dialog patterns

Check if jquery and other resources has been loaded else load it using script.

Is it feasible to outsources the work of adding plugin dependencies like jquery and css to some script ?

That script is the only file added into web page. let's call it InitJS

InitJS script would do the following things,
0) InitJS would contain configuration parameters for plugin.

InitJS would Detect if jquery exists on page ? [ Chances are good that it does ]
InitJS would Reuse existing jquery and CSS files or download asynchronously
InitJS would Download the feddback_me js plugin
..and then the plugin takes over..!

This way our plugin script embedding resorts to minimum file in each page !

What is the motive/advantage ? !
Let us say the InitJS which contains the plugin parameters is dynamically generated from third party server, and those parameters are configured in and generated by some back end !!!

InitJS would always have unique URI which doesn't change, that way the page in which plugin is added remains unaffected as and when the configuration changes, Which would happen in back end and served via same InitJS URI..!!

That way one could roll out FeedbackMe Plugin and it's configuration dynamically without facing end user migration issues as there is nothing to change on web page !

Sounds crazy / useful /feasible / challenging ? :)

Plugin doesn't close when clicking outside

Thanks a lot of the great plugin!
Small issue, plugin doesn't close when I click outside of it although the setting is set to true. There is a small bug:
function applyCloseOnClickOutside() {
var jqVersion = $().jquery.split(".");
jqVersion[0] = +jqVersion[0];
jqVersion[1] = +jqVersion[1];
if (jqVersion[0] >= 1 && jqVersion[1] >= 7) {
.....
The if statement failed for my jQuery version 2.4.

I fixed it like this:
if (jqVersion[0] > 1 || jqVersion[0] == 1 && jqVersion[1] >= 7) {

Throughs an error on IE7 and IE8

This could be a very low-priority issue, you might want to close without fixing. When testing on both IE7 and IE8 I got an "object not supported error". Also, the attractive vertical text only shows as horizontal text on those browsers.

fail to send mail

Hi i am trying to send mail through this plugin using php but failed to do the same please guide me how to use this it displaying the error sending failed

position right-bottom doesn't work

When I set the option position:right-bottom it renders as open on the page with feedback button on top right. No way to close it.

Does it has support to add more fields other than the predefined fields

I wanted to add more fields to the feedback form other than the predefined fields. For example right now plugin has fields for email, name and message.

If I want to add new field text area field say "Description" to the feedback form,what needs to be done?does the plugin has the support or do I need to add fields via custom html option only?

Use CSS3 transitions for sliding the feedback widget

For a much better user experience in a modern browsers!

problems using it in combination with select2

problems using it in combination with select2... If I use it in a page together with select2 I get JS errors and select2 does not works after that. I know this is not much information but I do not have to debug it at the moment. Did someone reported something similar?

"NetworkError: 404 Not Found - http://feedback-me.appspot.com/css%5Cjquery.feedback_me.css"
css\jq..._me.css
"NetworkError: 404 Not Found - http://feedback-me.appspot.com/js%5Cjquery.min.js"
js\jquery.min.js
"NetworkError: 404 Not Found - http://feedback-me.appspot.com/js%5Cjquery-ui.min.js"
js\jqu....min.js
"NetworkError: 404 Not Found - http://feedback-me.appspot.com/js%5Cjquery.feedback_me.js"
js\jqu...k_me.js
"NetworkError: 404 Not Found - http://feedback-me.appspot.com/js%5Cjquery-ui.min.js"
js\jqu....min.js
"NetworkError: 404 Not Found - http://feedback-me.appspot.com/js%5Cjquery.feedback_me.js"
js\jqu...k_me.js
ReferenceError: $ is not defined
[Break On This Error]

$(document).ready(function(){

exampl...ap.html (line 22