Code Monkey home page Code Monkey logo

closedsea's Introduction

Hi there ๐Ÿ‘‹ I'm Vectorized

Open-source Solidity repositories I'm currently maintaining:

  • Solady Optimized Solidity snippets.
  • ERC721A ERC721 implementation optimized for batch minting.
  • Multicaller Efficient multicaller contracts.
  • DN404 Implementation of a co-joined ERC20 <-> ERC721 pair.

Contact

Direct message or tag me on ๐• for the best response times.

closedsea's People

Contributors

1kresh avatar 2pmflow avatar cygaar avatar vectorized avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

closedsea's Issues

Overriding IERC721A in later solidity version breaks compile

When implementing the OperatorFilterer.sol on a base ERC721A the compiler ran into an issue referencing the override of the IERC721A interface. My solution was to remove the reference to IERC721A in the OperatorFilterer methods considering in later solidity versions overriding interfaces is not necessary for functions that override a single interface function.

Issue

The implemented setApprovalForAll function:

    function setApprovalForAll(address operator, bool approved)
        public
        override(IERC721A,ERC721A)
        onlyAllowedOperatorApproval(operator)
    {
        super.setApprovalForAll(operator, approved);
    }

Error received:

TypeError: Invalid contract specified in override list: "IERC721A".
   --> contracts/721AToken.sol:169:9:
    |
169 |         override(IERC721A, ERC721A)
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: This contract: 
  --> erc721a/contracts/IERC721A.sol:10:1:
   |
10 | interface IERC721A {
   | ^ (Relevant source part starts here and spans across multiple lines).

My Solution

Implement OperatorFilterer methods without overriding the ERC721 Interface

    function setApprovalForAll(address operator, bool approved)
        public
        override(ERC721A)
        onlyAllowedOperatorApproval(operator)
    {
        super.setApprovalForAll(operator, approved);
    }

If this fix goes against the grain please let me know, or if there is a better proposed solution that I could implement.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.