vdomah / oc-translatetabs-plugin Goto Github PK

OctoberCMS Build 468
Translate Plugin v1.6.7

I tried to use your plugin, but got the following error:

Trying to access array offset on value of type null

plugins/vdomah/translatetabs/formwidgets/Translations.php line 63

$this->vars['locale'] = $this->formField->attributes['field']['locale'];

My fields.yaml file is super basic:

fields:
  _translations:
    span: left
    type: translations
    form:
      fields:
        name:
          label: Name
          span: auto
          type: text

Also, I couldn't find where the locale variable is even used. Commenting out the line doesn't seem to break anything (but it makes the error go away).

"count(): Parameter must be an array or an object that implements Countable" on line 48 of ...\octobercms\plugins\vdomah\translatetabs\Plugin.php

I found it is an error with PHP 7.2
I change \octobercms\plugins\vdomah\translatetabs\Plugin.php at line 48

from

if (!count($arr))
    return false;

to

if (is_array($arr)) {
    if (!count($arr))
        return false;
} else {
    return false;
}

It is worked!

Hi,
Would it be possible to make it work with special fields like richeditor or markdown?
Also would it be possible to use the language "name" instead of it's "code" to make the tabs titles ?

Thanks.