The verano-http from vatavuk

Header normalization

We need to normalize header key in Header class

Kvp lazy loading

Let's make Kvp.Template take Scalar<Kvp> in ctor, instead of Kvp, to achieve lazy loading.

CachedWire

Let's create it

ExpectedStatus

Let's create ExpectedStatus that will assert whether received status code matches the expected one.

OkHttpWire

Let's create OkHttpWire that will wrap okHttp client

java.lang.VerifyError: class org.cactoos.list.Mapped overrides final method toString.

The code is:

public class AppTest {

    @Test
    public void httpPost() {
        final Response response = new Response(
            new ApiUrl().asString(),
            new Post(
                "/api/auth/login",
                new JsonBody(
                    Json.createObjectBuilder().add(
                        "username",
                        "***"
                    ).add(
                        "password",
                        "***"
                    ).build()
                )
            )
        );
        System.out.println(new Body.Of(response).asString());
    }

}

The result is:

java.lang.VerifyError: class org.cactoos.list.Mapped overrides final method toString.()Ljava/lang/String;

	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
	at hr.com.vgv.verano.http.HashDict.<init>(HashDict.java:59)
	at hr.com.vgv.verano.http.HashDict.<init>(HashDict.java:51)
	at hr.com.vgv.verano.http.DictInput$Envelope.<init>(DictInput.java:67)
	at hr.com.vgv.verano.http.parts.RequestUri.<init>(RequestUri.java:47)
	at hr.com.vgv.verano.http.wire.apache.ApacheWire.<init>(ApacheWire.java:109)
	at hr.com.vgv.verano.http.wire.apache.ApacheWire.<init>(ApacheWire.java:80)
	at hr.com.vgv.verano.http.response.Response.<init>(Response.java:81)
	at ru.fusionsoft.AppTest.httpPost(AppTest.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)

Note: I have in my pom.xml

      <dependency>
          <groupId>org.cactoos</groupId>
          <artifactId>cactoos</artifactId>
          <version>0.50</version>
      </dependency>

You have in your pom.xml

        <dependency>
            <groupId>org.cactoos</groupId>
            <artifactId>cactoos</artifactId>
            <version>0.39</version>
        </dependency>

QueryParam

Create QueryParam

UniqueHeader

Create a header that will guarantee its uniqueness in header map.

SocketTimeout

Implement SocketTimeout apache config

Get/Post/Put/Delete methods

Let's create inner classes in Method.class that contains information for Get/Post/Put/Delete method names

BasicAuth usage is confusing

BasicAuth should take only credentials in its ctor, not the uri

Increase code coverage

Code coverage should not be below 80%

AsyncResponse

Lets add support for handling of async http calls via new AsyncResponse class

JsonBody is not working properly

JsonBody provides empty string instead of a value

Release

For releases

ExpectedStatus exception message

Add more information about request (method, url...) to ExpectedStatus exception message

AutoRedirectWire

Implement it

Simplify *Response classes

Add additional ctor to *Response classes that takes only url.

ApacheHeaders

Create ApacheHeaders that will transform apache Header array to Iterable<Kvp>

Cookie

create cookie header

XmlResponse

Implement it

Multipart form body

Add support for multipart form body

Request/Response toString

Let's override Request/Response toString methods to have more comprehensive view when
an error occur.

FormParam

Create FormParam

DtoBody.Of throws exception that is hard to understand

Let's enrich exception message provided by ObjectMapper with "Cannot deserialize body %s"

Fasterxml jackson version security update

Update jackson to 2.9.9

ApacheWire null body

ApacheWire does not check if the response contains a body before fetching it.

DtoBody.Of has hardcoded dependency on ObjectMapper

ObjectMapper should be injectable into DtoBody.Of

Static analysis

Let's add pqulice static analysis

HeadersOf

Create HeadersOf as iterable if headers

HtmlBody

Create it

Dict iterator returns Key-Value pairs that are not in the map

Multiple Key-Value pairs with the same key are present in Dict.iterator

Apache Proxy

Add proxy config for apache

MockWire

Let's create mock wire for testing client. Mock wire shouldn't run on http, it should operate on java memory structures.

FailWith

Instead of

new ExpectedStatus("Cannot fetch from Google", 301)

use

new ExpectedStatus(301, new FailWith("CannotFetch from Google))

Note: Status code should always go before fail message

Reading of request params

Create separate inner classes Of for reading request params. For example: Body.Of(request)

HeadersOf

Create HeadersOf that will extract headers from dict

RetryWire

Implement it

Post, Put, Delete request

Let's create PostRequest, PutRequest, DeleteRequest

RouteParam

Implement it

Header asList

Lets add asList method to Header class that will return a list of header values.

Accept

Create accept header

Cookies from response

Enable cookie fetching by key

Map<String, String> interface is too verbose

Let's create our own Dict interface that will act as Map<String, String> but will be immutable and less verbose

Simplify Wire interface

Wire doesnt really need to extend Map interface

HTTP/2 support

Let's add support for HTTP/2

ContentType

Create ContentType header

Use JsonReader instead of JsonObject in JsonResponse

JsonResponse.asJson() should return JsonReader instead of JsonObject

Form params

FormParams (plural) override all the other params being sent in the same request.

ConnectionTimeout

Implement ConnectionTimeout apache config

vatavuk / verano-http Goto Github PK

verano-http's People

Contributors

Stargazers

Watchers

Forkers

verano-http's Issues

Recommend Projects

Recommend Topics

Recommend Org