Out of bounds array bug about fisx HOT 10 CLOSED

Please, do so. It seems it should be a[i -1] and b[i -1] (or to change the loop limits)

from fisx.

Fortunately that function is never called. It is a left over from the initial development but it should be corrected. Thanks for the finding!

from fisx.

Yep I had a feeling it was never actually used as this easily might have led to a segfault or at the very least corrupted results.

from fisx.

Oh and by the way, I opened a request to have fisx added to conda-forge.

When this one is merged in, I will create one for PyMca as well.

from fisx.

There is a conda.recipe for each of them fisx and PyMca. It was contributed y people using conda because I do not use it.

from fisx.

I know but they are all outdated and conda-forge makes the platform specific builds using CI/CD, which is the hard part... and they do it in such a way that the resulting binaries will run on some pretty old version of Linux and macOS.

I will let you know when the whole process is complete, in case you want to announce it on the mailinglist or so... I am sure some of your users may find it interesting to know.

from fisx.

Please, feel free to update the recipes of fisx and PyMca of their respective repositories if that helps.

I prefer to have them removed than to have them wrong.

from fisx.

That's impossible I am afraid as they all appear to be in personal repositories (e.g. Nicola Vigano). I have no control over them.

This is why I prefer conda-forge as I would not be the only maintainer and is a known source for trustworthy packages.

from fisx.

I meant those found in the repository under conda.recipes For instance, the one of fisx is:

https://github.com/vasole/fisx/tree/master/conda.recipe

from fisx.

ok thanks for the clarification

I will remove them when both fisx and PyMca have made it onto conda-forge.

from fisx.