vanzeben / mail Goto Github PK

.

Via dev.bukkit.org

/mail reload: Reloads the config and all mail (requires Mail.admin.reload)
/mail convert <old-table-name>: Converts the old mail data to the new format (requires Mail.admin.convert)
/mail inbox <read|unread>: Checks your inbox (requires Mail.general.inbox)
/mail read [index]: Opens the specified mail (requires Mail.general.read)
/mail [write/create/new] [receiver] [message]: Sends a new mail (requires Mail.general.write)

Yet in the code you check lowercase: mail.general here

• Why the discrepancy? Only most permissions plugins are case insensitive. Why use uppercase at all?
• Why are none of these permissions in plugin.yml? It's a useful place for other people to find them without digging through the code.

As per the title, the ability to change the name of the mail table has been removed. Please add this again.

It appears that Mail does not work with zPermissions.

Could you support Vault so they become compatible?

00:29:58 [INFO] [Mail] Using: Permissions.
00:29:58 [INFO] SQLException: Communications link failure
The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.
00:29:58 [INFO] SQLState: 08S01
00:29:58 [INFO] VendorError: 0
00:29:58 [SEVERE] com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications link failure
The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.
00:29:58 [SEVERE] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
00:29:58 [SEVERE] at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
00:29:58 [SEVERE] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
00:29:58 [SEVERE] at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
00:29:58 [SEVERE] at com.mysql.jdbc.Util.handleNewInstance(Util.java:407)
00:29:58 [SEVERE] at com.mysql.jdbc.SQLError.createCommunicationsException(SQLError.java:1116)
00:29:58 [SEVERE] at com.mysql.jdbc.MysqlIO.(MysqlIO.java:343)
00:29:58 [SEVERE] at com.mysql.jdbc.ConnectionImpl.coreConnect(ConnectionImpl.java:2334)
00:29:58 [SEVERE] at com.mysql.jdbc.ConnectionImpl.connectOneTryOnly(ConnectionImpl.java:2371)
00:29:58 [SEVERE] at com.mysql.jdbc.ConnectionImpl.createNewIO(ConnectionImpl.java:2163)
00:29:58 [SEVERE] at com.mysql.jdbc.ConnectionImpl.(ConnectionImpl.java:794)
00:29:58 [SEVERE] at com.mysql.jdbc.JDBC4Connection.(JDBC4Connection.java:47)
00:29:58 [SEVERE] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
00:29:58 [SEVERE] at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
00:29:58 [SEVERE] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
00:29:58 [SEVERE] at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
00:29:58 [SEVERE] at com.mysql.jdbc.Util.handleNewInstance(Util.java:407)
00:29:58 [SEVERE] at com.mysql.jdbc.ConnectionImpl.getInstance(ConnectionImpl.java:378)
00:29:58 [SEVERE] at com.mysql.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:305)
00:29:58 [SEVERE] at java.sql.DriverManager.getConnection(DriverManager.java:582)
00:29:58 [SEVERE] at java.sql.DriverManager.getConnection(DriverManager.java:207)
00:29:58 [SEVERE] at com.imdeity.mail.MySQLConnection.(MySQLConnection.java:28)
00:29:58 [SEVERE] at com.imdeity.mail.Mail.setupDatabase(Mail.java:63)
00:29:58 [SEVERE] at com.imdeity.mail.Mail.onEnable(Mail.java:38)
00:29:58 [SEVERE] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:170)
00:29:58 [SEVERE] at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:957)
00:29:58 [SEVERE] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:280)
00:29:58 [SEVERE] at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:171)
00:29:58 [SEVERE] at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:154)
00:29:58 [SEVERE] at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:297)
00:29:58 [SEVERE] at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:284)
00:29:58 [SEVERE] at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:152)
00:29:58 [SEVERE] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:348)
00:29:58 [SEVERE] at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
00:29:58 [SEVERE] Caused by: java.net.ConnectException: Connection refused
00:29:58 [SEVERE] at java.net.PlainSocketImpl.socketConnect(Native Method)
00:29:58 [SEVERE] at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:351)
00:29:58 [SEVERE] at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:213)
00:29:58 [SEVERE] at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:200)
00:29:58 [SEVERE] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366)
00:29:58 [SEVERE] at java.net.Socket.connect(Socket.java:529)
00:29:58 [SEVERE] at java.net.Socket.connect(Socket.java:478)
00:29:58 [SEVERE] at java.net.Socket.(Socket.java:375)
00:29:58 [SEVERE] at java.net.Socket.(Socket.java:218)
00:29:58 [SEVERE] at com.mysql.jdbc.StandardSocketFactory.connect(StandardSocketFactory.java:254)
00:29:58 [SEVERE] at com.mysql.jdbc.MysqlIO.(MysqlIO.java:292)
00:29:58 [
SEVERE] ... 27 more
00:29:58 [SEVERE] Error occurred while enabling Mail v0.6 (Is it up to date?): [Mail] Failed to create connection to Mysql database
com.avaje.ebeaninternal.server.lib.sql.DataSourceException: [Mail] Failed to create connection to Mysql database
at com.imdeity.mail.MySQLConnection.(MySQLConnection.java:32)
at com.imdeity.mail.Mail.setupDatabase(Mail.java:63)
at com.imdeity.mail.Mail.onEnable(Mail.java:38)
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:170)
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:957)
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:280)
at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:171)
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:154)
at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:297)
at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:284)
at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:152)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:348)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)

00:25:02 [SEVERE] Could not pass event PLAYER_JOIN to Mail
java.lang.NullPointerException
at com.imdeity.mail.MailSQL.getUnreadCount(MailSQL.java:17)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:260)
at com.imdeity.mail.MailPlayerListener.onPlayerJoin(MailPlayerListener.java:16)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:339)
at net.minecraft.server.ServerConfigurationManager.c(ServerConfigurationManager.java:129)
at net.minecraft.server.NetLoginHandler.b(NetLoginHandler.java:121)
at net.minecraft.server.NetLoginHandler.a(NetLoginHandler.java:39)
at net.minecraft.server.NetworkListenThread.a(SourceFile:94)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:471)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:374)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
00:25:02 [INFO] New max size: 484
00:25:02 [INFO] New max size: 784
00:25:16 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'mail' in plugin Mail v0.6
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:42)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:163)
at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:355)
at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:722)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:715)
at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:757)
at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:33)
at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java:500)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:92)
at net.minecraft.server.NetworkListenThread.a(SourceFile:108)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:471)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:374)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
Caused by: java.lang.NullPointerException
at com.imdeity.mail.MailSQL.getAllMail(MailSQL.java:70)
at com.imdeity.mail.MailCommand.checkMail(MailCommand.java:69)
at com.imdeity.mail.MailCommand.parseCommand(MailCommand.java:46)
at com.imdeity.mail.MailCommand.onCommand(MailCommand.java:37)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40)

08:08:01 [SEVERE] Could not pass event PLAYER_JOIN to Mail
java.lang.NullPointerException
at com.imdeity.mail.MailSQL.getUnreadCount(MailSQL.java:17)
at com.imdeity.mail.MailPlayerListener.onPlayerJoin(MailPlayerListener.java:16)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:244)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:338)
at net.minecraft.server.ServerConfigurationManager.c(ServerConfigurationManager.java:124)
at net.minecraft.server.NetLoginHandler.b(NetLoginHandler.java:97)
at net.minecraft.server.NetLoginHandler.a(NetLoginHandler.java:33)
at net.minecraft.server.NetworkListenThread.a(SourceFile:91)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:454)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:363)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)

User reports "Works great, but it throws an exception when you type /mail delete without an ID. I know /mail delete isn't supposed to be a command without ID or *, but still, you should catch that error."

Confirmed and probably easy to fix.

Let me know if you would prefer I fix this.

Joining the server does not send notifications when the player's inbox contains unread mail.

Version v12.08.19

i drag and drop the mail.jar into my plugins folder and apon server start i get a huge error, please fix.
2011-10-10 20:28:32 [INFO] [Mail] Using: Permissions.
2011-10-10 20:28:33 [INFO] CButD: CraftBukkit is up to Date
2011-10-10 20:28:33 [INFO] SQLException: Communications link failure

The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.
2011-10-10 20:28:33 [INFO] SQLState: 08S01
2011-10-10 20:28:33 [INFO] VendorError: 0
2011-10-10 20:28:33 [SEVERE] com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications link failure

The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.
2011-10-10 20:28:33 [SEVERE] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
2011-10-10 20:28:33 [SEVERE] at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.lang.reflect.Constructor.newInstance(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.Util.handleNewInstance(Util.java:407)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.SQLError.createCommunicationsException(SQLError.java:1116)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.MysqlIO.(MysqlIO.java:343)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.ConnectionImpl.coreConnect(ConnectionImpl.java:2334)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.ConnectionImpl.connectOneTryOnly(ConnectionImpl.java:2371)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.ConnectionImpl.createNewIO(ConnectionImpl.java:2163)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.ConnectionImpl.(ConnectionImpl.java:794)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.JDBC4Connection.(JDBC4Connection.java:47)
2011-10-10 20:28:33 [SEVERE] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
2011-10-10 20:28:33 [SEVERE] at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.lang.reflect.Constructor.newInstance(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.Util.handleNewInstance(Util.java:407)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.ConnectionImpl.getInstance(ConnectionImpl.java:378)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:305)
2011-10-10 20:28:33 [SEVERE] at java.sql.DriverManager.getConnection(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.sql.DriverManager.getConnection(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at com.imdeity.mail.MySQLConnection.(MySQLConnection.java:28)
2011-10-10 20:28:33 [SEVERE] at com.imdeity.mail.Mail.setupDatabase(Mail.java:63)
2011-10-10 20:28:33 [SEVERE] at com.imdeity.mail.Mail.onEnable(Mail.java:38)
2011-10-10 20:28:33 [SEVERE] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:126)
2011-10-10 20:28:33 [SEVERE] at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:941)
2011-10-10 20:28:33 [SEVERE] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:280)
2011-10-10 20:28:33 [SEVERE] at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:174)
2011-10-10 20:28:33 [SEVERE] at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:157)
2011-10-10 20:28:33 [SEVERE] at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:297)
2011-10-10 20:28:33 [SEVERE] at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:284)
2011-10-10 20:28:33 [SEVERE] at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:152)
2011-10-10 20:28:33 [SEVERE] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:348)
2011-10-10 20:28:33 [SEVERE] at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)
2011-10-10 20:28:33 [SEVERE] Caused by: java.net.ConnectException: Connection refused: connect
2011-10-10 20:28:33 [SEVERE] at java.net.DualStackPlainSocketImpl.connect0(Native Method)
2011-10-10 20:28:33 [SEVERE] at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.PlainSocketImpl.connect(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.SocksSocketImpl.connect(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.Socket.connect(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.Socket.connect(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.Socket.(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at java.net.Socket.(Unknown Source)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.StandardSocketFactory.connect(StandardSocketFactory.java:254)
2011-10-10 20:28:33 [SEVERE] at com.mysql.jdbc.MysqlIO.(MysqlIO.java:292)
2011-10-10 20:28:33 [SEVERE] ... 27 more
2011-10-10 20:28:33 [SEVERE] Error occurred while enabling Mail v0.6 (Is it up to date?): [Mail] Failed to create connection to Mysql database
com.avaje.ebeaninternal.server.lib.sql.DataSourceException: [Mail] Failed to create connection to Mysql database
at com.imdeity.mail.MySQLConnection.(MySQLConnection.java:32)
at com.imdeity.mail.Mail.setupDatabase(Mail.java:63)
at com.imdeity.mail.Mail.onEnable(Mail.java:38)
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:126)
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:941)
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:280)
at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:174)
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:157)
at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:297)
at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:284)
at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:152)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:348)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:417)

No .jar for DeityAPI in repository.

As you can see, I am unable to perform any mail commands due to an internal error which occurs each time such is attempted. I am positive that the plugin has access to my server's MySQL database, because it has created a (presently empty) table for itself called mail_mail. Using v0.4. Tried 0.5, but it consistently disabled itself for no apparent reason. I'd post the error received, however I can't copy from the console. The error did not show up in the Pail GUI.

08:11:34 [INFO] Forecaster tried to use command /mail
08:11:34 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'mail' in plugin Mail v0.4
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:37)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:129)
at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:352)
at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:737)
at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:701)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:694)
at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:33)
at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:89)
at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java:478)
at net.minecraft.server.NetworkListenThread.a(SourceFile:105)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:454)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:363)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
Caused by: java.lang.NullPointerException
at com.imdeity.mail.MailCommand.checkMail(MailCommand.java:68)
at com.imdeity.mail.MailCommand.parseCommand(MailCommand.java:46)
at com.imdeity.mail.MailCommand.onCommand(MailCommand.java:37)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:35)
... 13 more

Can I request for SuperPerms support for Mail plugin?

I'm trying to get it installed, but it's saying:
17:54:13 [INFO] [Mail] Connection success!
17:54:13 [INFO] [Mail] Plugin was setup incorrectly, disabling
17:54:13 [INFO] [Mail] Disabled
I've configured the config file. And it did log into mysql and create the tables. So I know it's getting that far. But I have no output saying anything further.

Can you add some limits for Mail?

Here is the idea for HelpTicket limits. Same ideas can be applied to Mail too.

Can you implement some limits for HelpTicket so that random players can't spam the database?

Maybe add an option where a player can only post one ticket until it is fixed. Then he can make another one, or when he deletes the old one.

A bypass permission for that feature for admins would be awesome too.

Or a ladder permission based limits:

helpticket.limit.1

and in the config we would specify "limit 1 = 5" and they can't make new tickets until the old ones are solved by admins or they delete one.

Thanks

I do not keep my plugins folder inside the same directory as my craftbukkit.jar, and the Language object creates(or at least, tries to create) a plugins/Mail/Language.yml inside the wrong directory. I've had to enable write access to the directory with my server JAR in it to the user the server runs as. Please use Plugin.getDataFolder() in all cases where you need to access your plugin directory.