valueof / hiro Goto Github PK

Before the merge need to make sure that we can run new Hiro with PhantomJS.

If you have a failed assertion, Hiro continues executing the test function until it reaches the end. It only stops if an exception is thrown.

Useful for newcomers to get into Hiro and for contributors to make sure UI is not broken.

EOM

I can't seem to find any documentation on how to run Hiro using PhantomJS. I'm no expert on the subject but with a little help I could write up a small cookbook article.

EOM

EOM

Right now the assert functions are using loose comparison operators within the assert methods, is there any particular reason not to use strict comparisons?

Debugging failed assertions is difficult because the current reporting mechanism doesn't list the affected object/function, source code line, etc.

QUnit does this: http://docs.jquery.com/QUnit#Using_QUnit

In cases where Hiro fails to load certain resources the test suite will stop executing.

For example, we have several test cases which will load an html, javascript, or css file, and as soon as that fails the test suite bails (no events are fired/etc).

EOM.

It just fails with a red error bar - there's no indication of what actually happened.

If you have more assertions that are expected, the message is kind of off.

If you use pause/resume in a test, that test will ignore any prior expectations re: # of assertions.

Hi,
This looks like a nice testing framework, but it doesn't have a license file or any license embedded in the source code. Would you mind adding one? cough Permissive license cough

Thanks

I think it would be nice to have a few more assertions.

• assertGreaterThan
• assertGreaterThanOrEqualTo
• assertLessThan
• assertLessThanOrEqualTo
• assertUndefined
• assertNull
• assertInstanceOf
• assertObjectHasProperty
• assertArrayContains

I'm not to sure about the names of the last two. What do you think?

Would you like me to open a PR?

Whenever the module name is incorrect an error message should be shown to indicate why the test could not be run.

Before merge, need to make sure that you can run new Hiro from inside the browser.

http://dl.dropbox.com/u/421333/Screenshots/y26hgo7qdfa0.png

Final check before merge: can we run Disqus tests with Hiro 2?

New fancy pants Hiro website