[BUG] inconsistent behavior of kqueue aeApiDelEvent comparing to the code before #638 about valkey HOT 2 CLOSED

thanks, this looks reasonable, please make a PR so that we can do a review

from valkey.

I looked into the related code before submitting a PR, and found that the evport implementation might not be working since 2014.

This is the first commit to evport, which uses port_get(), and this commit modified it to port_getn(), both committed by Dave Pacheco in 2012. The code in aeApiDelEvent says:

We rely on the fact that our caller has already updated the mask in the eventLoop.

Then in 2014, a small commit moves aeApiDelEvent(eventLoop, fd, mask) before modifying the properties in eventLoop, which breaks the assumption which evport relies on. Also there's no real benefit or clear reason for the modification in the discussion of the the commit.

Also I believe both evport and epoll can use the mask stored in eventLoop, without re-calculating the mask themselves.

I'll submit the PR with all the above fixes I would like to make, which is still very small.
If we finally make the conclusion that only the fix to kqueue should be applied, I would still be willing to modify the PR.

from valkey.