code usege of sds (and maybe other data types) about valkey HOT 1 OPEN

@zvi-code Thanks for starting this issue. Right now I'm a bit unclear about your suggestion. I would like to understand more :).

Also not sure if you're referring to the same thing which I also had experimented a little while ago. Let me know if we are on the same page :).

Overall, my idea was not to create robj/sds during the IO flow for each argument. Hence, an additional copy isn't required and was instead maintaining a seqbuf struct to refer the data in client's querybuf present already.

typedef struct seqbuf {
   char *buf;
   uint32_t len;
} seqbuf;

Few of the helper methods to handle to-fro between data storage layer and network layer:

seqbuf *seqbuf_init_cstr(char *buf, long len);
seqbuf *seqbuf_init_sds(sds buf);
void seqbuf_clonedata(seqbuf *sb);
sds seqbuf_createsds(seqbuf *sb);
struct redisObject *seqbuf_createStringObject(seqbuf *sb);
void seqbuf_clear(seqbuf *sb);
void seqbuf_free(seqbuf *sb);

One of the challenges which I observed with introducing another type in to the Valkey codebase is the developers need to be aware when to use which type and the initial change would be quite messy as there a lot of touchpoints. Currently, it's pretty homogenous throughout the codebase so easier to navigate albeit paying some of the cost.

from valkey.