validitylabs / daa Goto Github PK

There are multiple cases in which we do not use SafeMath consistently. All mathematical operations should be safe. Needs to be fixed, e.g. here.

Instead of having e.g. here things like VOTE_TIME_IN_MINS = 10; it would make sense to have voteTime = 10 minutes; and then avoid the multiplication in the code (like VOTE_TIME_IN_MINS.mul(1 minutes)).

How does DAAS determine whether someone has a "substantial relationship to Switzerland". According to "Article 11 Members & Membership Requirements" on Page 4 of the DAAS Statute 170907_DAAS Statues.docx, it appears that eligibility to gain membership of the DAAS is only otherwise available to residents of Switzerland.

As described in jsdoc/jsdoc#1489 , there is a security vulnerability in the marked package. We should update as soon jsdoc published the fixed version on npmjs.com.

Here we still have a uint instead of uint256 in a cast. Let's change it all to uint256 and not use the alias anymore.