vaikas / csr Goto Github PK

Not sure if this is user error but..... there is no mention of KO_DOCKER_REPO needing to be defined... assuming you are targeting devs not Knative contributoes who would not have the dev environment vars set up

I see the following controller output:

$ kubectl logs -ncloudschedulersource-system cloudschedulersource-controller-59d46644fc-tls4s
W1120 05:34:39.955488       1 client_config.go:552] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
{"level":"info","ts":1542692079.9584384,"logger":"fallback.controller.cloudschedulersource-controller","caller":"cloudschedulersource/cloudschedulersource.go:122","msg":"Setting up event handlers","knative.dev/controller":"cloudschedulersource-controller"}
{"level":"info","ts":1542692079.958542,"logger":"fallback.controller","caller":"controller/main.go:112","msg":"Waiting for informer caches to sync"}

ko apply -f config gives a big error spew about missing deps.

Running ./hack/update-deps.sh seems to fix this.

e.g. ko create -f ./subscription.yaml

It has no image references to build.

gcloud beta scheduler jobs list errs on cloudscheduler.googleapis.com API not being enabled

Add

gcloud services enable cloudscheduler.googleapis.com

to readme

The IAM setup attempts to create the secret for the GCP robot before the namespace exists.

The instructions call for replace of MY_GCP_PROJECT placeholder with your own project ID but the downloaded subscription.yaml file doesn't have the placeholder or any project ID AFAIKS

Both use the source informer, but this should use the serving informer.

[foo](bar) not (foo)[bar]