vadims / gerrit-owners Goto Github PK

it would be preferable, if the owners file was read from a different reference, similar to gerrits refs/meta/config, or even exactly that.

Would you accept a patch for doing that?

Hi, thanks for the awesome plugin!

I see in pom.xml that this plugin builds against version 2.6-rc1 of the Gerrit API. Is there any plan to update it to a more recent version?

Thanks!

I've spent an hour trying to figure out how to build this plugin. Here's what hasn't worked:

$ git clone https://github.com/vadims/gerrit-owners.git && cd gerrit-owners && buck build gerrit-owners:owners

IOError: [Errno 2] No such file or directory: '/home/ubuntu/gerrit-owners/plugins/gerrit-owners/common.defs'

I've tried moving files around, building from the plugins dir, etc. Any advice on how to build this from scratch?

Reported from [email protected]

Looks like the BUILD files I wrote have now been outlawed, I see the following:

$ buck build gerrit plugins/gerrit-owners/gerrit-owners:owners
remote: Counting objects: 5094, done
remote: Finding sources: 100% (14906/14906)
remote: Total 14906 (delta 9195), reused 14906 (delta 9195)
Receiving objects: 100% (14906/14906), 41.23 MiB | 4.82 MiB/s, done.
Resolving deltas: 100% (9195/9195), completed with 393 local objects.
From https://gerrit.googlesource.com/buck
   6e2e783..c38b989  github-master -> origin/github-master
Buck is at 274acb17e9b6dc9ee60bc1371c47a7f49640c24c,
but should be c38b9899f7952382963cb7822bbdfc9104b42e70.
Buck is updating itself.
To disable this, add a '.nobuckcheck' file to your project root.
In general, you should only disable this if you are developing Buck.
Previous HEAD position was 274acb1... Allow system wide or user specific configurations
HEAD is now at c38b989... Add a brief "Tour of the Codebase" document.
Buildfile: /Users/ugo/development/buck/build.xml

clean:
   [delete] Deleting directory /Users/ugo/development/buck/build

BUILD SUCCESSFUL
Total time: 0 seconds
Buck does not appear to have been built -- building Buck!
Not using buckd because watchman isn't installed.
[+] PARSING BUCK FILES...0.2s
Traceback (most recent call last):
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 1227, in <module>
    main()
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 455, in main
    values = buildFileProcessor.process(build_file.rstrip())
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 395, in process
    implicit_includes=self._implicit_includes)
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 386, in _process_build_file
    implicit_includes=implicit_includes)
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 350, in _process
    exec(code, module.__dict__)
  File "/Users/ugo/development/gerrit/plugins/gerrit-owners/gerrit-owners/BUCK", line 1, in <module>
    include_defs('//plugins/gerrit-owners/common.defs')
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 274, in _include_defs
    implicit_includes=implicit_includes)
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 367, in _process_include
    implicit_includes=implicit_includes)
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 350, in _process
    exec(code, module.__dict__)
  File "/Users/ugo/development/gerrit/plugins/gerrit-owners/common.defs", line 8, in <module>
    license = 'Apache2.0',
  File "/Users/ugo/development/gerrit/lib/maven.defs", line 92, in maven_jar
    out = binjar,
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 92, in invoke
    return self.func(*args, **updated_kwargs)
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 811, in genrule
    }, build_env)
  File "/Users/ugo/development/gerrit/buck-out/tmp/buck_run.Ie9Fxv/buck179844315429781973.py", line 103, in add_rule
    .format(rule['type']))
AssertionError: Cannot use `genrule()` at the top-level of an included file.
[2014-11-03 22:00:55.052][error][command:d0edb3de-7819-4d9a-92f6-7279c2dabb55][tid:01][com.facebook.buck.json.ProjectBuildFileParser] Process java.lang.UNIXProcess@1f939fd3 exited with error code 1
BUILD FAILED: Parse error for BUCK file /Users/ugo/development/gerrit/plugins/gerrit-owners/gerrit-owners/BUCK: java.lang.IllegalStateException: Expected BEGIN_ARRAY but was END_DOCUMENT at line 2 column 1

I'm looking into this.

I do have the following Stacktrace on the latest Gerrit while trying to install the plugin gerrit-owners-autoassign-1.1:

[2015-10-15 19:29:09,264] WARN com.google.gerrit.server.plugins.PluginLoader : Cannot load plugin gerrit-owners-autoassign-1.1
com.google.common.util.concurrent.ExecutionError: com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: com/google/gerrit/extensions/events/GitReferenceUpdatedListener$Update
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2201)
at com.google.common.cache.LocalCache.get(LocalCache.java:3937)
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3941)
at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4824)
at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:4830)
at com.google.inject.internal.FailableCache.get(FailableCache.java:48)
at com.google.inject.internal.ConstructorInjectorStore.get(ConstructorInjectorStore.java:50)
at com.google.inject.internal.ConstructorBindingImpl.initialize(ConstructorBindingImpl.java:136)
at com.google.inject.internal.InjectorImpl.initializeBinding(InjectorImpl.java:533)
at com.google.inject.internal.AbstractBindingProcessor$Processor$1.run(AbstractBindingProcessor.java:160)
at com.google.inject.internal.ProcessedBindingData.initializeBindings(ProcessedBindingData.java:44)
at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:123)
at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
at com.google.inject.internal.InjectorImpl.createChildInjector(InjectorImpl.java:226)
at com.google.inject.internal.InjectorImpl.createChildInjector(InjectorImpl.java:233)
at com.google.gerrit.server.plugins.ServerPlugin.startPlugin(ServerPlugin.java:190)
at com.google.gerrit.server.plugins.ServerPlugin.start(ServerPlugin.java:170)
at com.google.gerrit.server.plugins.PluginLoader.runPlugin(PluginLoader.java:461)
at com.google.gerrit.server.plugins.PluginLoader.rescan(PluginLoader.java:390)
at com.google.gerrit.server.plugins.PluginLoader.start(PluginLoader.java:295)
at com.google.gerrit.lifecycle.LifecycleManager.start(LifecycleManager.java:74)
at com.google.gerrit.pgm.Daemon.start(Daemon.java:293)
at com.google.gerrit.pgm.Daemon.run(Daemon.java:205)
at com.google.gerrit.pgm.util.AbstractProgram.main(AbstractProgram.java:64)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at com.google.gerrit.launcher.GerritLauncher.invokeProgram(GerritLauncher.java:166)
at com.google.gerrit.launcher.GerritLauncher.mainImpl(GerritLauncher.java:93)
at com.google.gerrit.launcher.GerritLauncher.main(GerritLauncher.java:50)
at Main.main(Main.java:25)
Caused by: com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: com/google/gerrit/extensions/events/GitReferenceUpdatedListener$Update
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2201)
at com.google.common.cache.LocalCache.get(LocalCache.java:3937)
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3941)
at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4824)
at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:4830)
at com.google.inject.internal.FailableCache.get(FailableCache.java:48)
at com.google.inject.internal.MembersInjectorStore.get(MembersInjectorStore.java:68)
at com.google.inject.internal.ConstructorInjectorStore.createConstructor(ConstructorInjectorStore.java:74)
at com.google.inject.internal.ConstructorInjectorStore.access$000(ConstructorInjectorStore.java:29)
at com.google.inject.internal.ConstructorInjectorStore$1.create(ConstructorInjectorStore.java:37)
at com.google.inject.internal.ConstructorInjectorStore$1.create(ConstructorInjectorStore.java:33)
at com.google.inject.internal.FailableCache$1.load(FailableCache.java:37)
at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3527)
at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2319)
at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2282)
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2197)
... 31 more
Caused by: java.lang.NoClassDefFoundError: com/google/gerrit/extensions/events/GitReferenceUpdatedListener$Update
at java.lang.Class.getDeclaredMethods0(Native Method)
at java.lang.Class.privateGetDeclaredMethods(Class.java:2615)
at java.lang.Class.getDeclaredMethods(Class.java:1860)
at com.google.inject.spi.InjectionPoint.getInjectionPoints(InjectionPoint.java:688)
at com.google.inject.spi.InjectionPoint.forInstanceMethodsAndFields(InjectionPoint.java:380)
at com.google.inject.internal.MembersInjectorStore.createWithListeners(MembersInjectorStore.java:93)
at com.google.inject.internal.MembersInjectorStore.access$000(MembersInjectorStore.java:37)
at com.google.inject.internal.MembersInjectorStore$1.create(MembersInjectorStore.java:45)
at com.google.inject.internal.MembersInjectorStore$1.create(MembersInjectorStore.java:42)
at com.google.inject.internal.FailableCache$1.load(FailableCache.java:37)
at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3527)
at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2319)
at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2282)
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2197)
... 46 more
Caused by: java.lang.ClassNotFoundException: com.google.gerrit.extensions.events.GitReferenceUpdatedListener$Update
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
... 60 more