There are two similar dialogs, in ReviewForm and one inside the Category view, which are used for similar purposes but implemented differently. Unify common parts into an abstract superclass

When listing categories, I want to be able to edit/delete them, because I don't need them anymore

The same dialog as in #10, but with a Delete button. The delete operation should ask for confirmation on the delete, similarly as in #6.

Either deleting or editing a category should show the feedback dialog, similarly as to in #7 .

Once vaadin/flow#2439 is in, you can remove it servlet declaration.

When adding/editing/deleting reviews, I want to see feedback on the operation, so that I know that it succeeded

A dialog notification which disappears either automatically, or by clicking it (to be confirmed).

Note: this could use paper-toast which is coming as an add-on dependency.

There are some ready made validators for using.
https://github.com/vaadin/flow/tree/master/flow-data/src/main/java/com/vaadin/data/validator

• rewrite the filtering in the backend services to use streams, like

List<Category> categoriesSelected = categories.stream()
        .filter(c -> c.toString().toLowerCase().contains(stringCategoryFilterLoCase)
        .collect(Collectors.toList());

• obsolete the sorting by e.g. using a LinkedHashMap instead of HashMap to store the entities. Note: We may want to sort them by most recent first?

If I set the date to a nonsense value like "a/b/xx" in the ReviewForm then click Save, I get no validation error but an internal error after the dialog closed, when the value is attempted to be converted into a LocalDate.

I think that proper validation should prevent this.

E.g. if I enter a date like 11/11/-11...

...after pressing Save it becomes 11/11/0012.

When opening the app, I want to have navigation on top, so I can easily navigate between the views

There should be header with two buttons, that switch the active view, and the corresponding button is highlighted.

On the left, the name of the App is shown.

It is fine to not use the icons for the first step.

once it's available.

And remove the temporary styles for valo-grid from styles.html.

When tasting, I want to categorize the reviews, so that I can more easily try out different types of food

This is a list of categories with the number of reviews for each category. The edit button does not have to work yet.

Write up what is in the view and how it works:

• template based
  • link to template documentation (in github/vaadin/flow)
• what concepts used, if any
• whatever is necessary to understand from the view

Possibly the editor dialogs too?

When tasting, I want to be able to delete a review, because I accidentally added it twice

There should be delete button in the edit review dialog from #5, and clicking it opens a confirmation dialog, see the screenshot (it has the wrong text visible so please note that).

When opening the app, I want to see a list of all the reviews, so that I can easily see what I have tasted.

See screenshot. This view should be based on a Polymer Template.

The edit button does not have to work for now.

No need to add the search field and new beer button yet.

When the 10.0.0-alpha2 is out, it should be taken into use here instead of flow dependencies.

The platform dependency contains WebJars, then we can remove the bower stuff at the same time.

These are now all black, instead of blue.

Should also determine the exact shade of blue.

by setting the main-layout__nav-item--selected class to the appropriate router link whenever the selection changes

When tasting, I want to be able to edit a review, because I changed my mind on the score.

See screenshot. Same dialog as in #4, the delete button can be left out for now.

After opening either of the views, if I open any of the existing items for editing, not all dialog components get the actual values:

After opening the New (Review|Category) dialog (and simply cancelling it, or adding a new item), the issue doesn't appear anymore:

This is possibly a new form of the known Binder bug vaadin/flow#2460 .

To avoid situations like displaying "Coca Cola" as "Wine" etc.

Following up a TODO left by Jouni

https://invis.io/XDD6L4G9Q#/250172236_frontpage

The clickable prototype still uses the "alcohol-neutral" branding which I called "Drinkventory". Feel free to call it something else or rebrand dummy data to food or whatever fits best.

This is big step that composes of multiple actions:

• changing front-end content folder from /src/main/frontend/bower_components/ to /src/main/webapp/bower_components/
  • remember to update .gitignore to ignore these
• update pom.xml
  • update frontend properties with descriptions on what do their refer to
    • <frontend.working.directory>src/main/webapp</frontend.working.directory>
    • <vaadin.frontend.path>VAADIN/static/frontend</vaadin.frontend.path>
  • update paths for maven-war-plugin and maven-clean-plugin if necessary
    • check for inclusions and exclusions

During refactoring the dialogs, when I extracted the CategoryForm code into its own class, all of a sudden the dialogs appeared directly on the view at startup, and couldn’t be opened/closed anymore:

Tried everything, consulted with @pekam - nothing helped. Comparison to ReviewForm did not reveal any difference in the way the forms are created and opened.

After a couple of hours of agony I discovered that this happens only when I open the /categories URL directly, without seeing the Reviews view first! If I switch to the Reviews view and back, the problem disappears and the dialog starts to behave in a perfectly decent manner.

Even though this shouldn't occur in the normal flow of events (as the root URL is mapped to the Reviews view), it would still be worth fixing.

When tasting, I want to be able to add a new category, so that I can add reviews of that type

After #9 add a button that opens a dialog (see screenshot) that can be used to add a new category.

After adding category should show the feedback notification, similarly as to in #7.

As per the TODOs by Jouni in reviews-list.html:

the label text should be set from Java (to allow easy localization),
but currently it’s not possible to generate this exact DOM structure from
there (it produces unnecessary white-space between the icon and the span)

Use the annotation based Routing API instead of the old imperative API.

Should explain how servlet is automatically registered, how views are mapped and what is the main layout. Should also have a link to the router documentation in Flow (for now only in github)

When opening the app, I want to have some static data available, so that I don't have to create everything with the UI so see all the features

Static in-memory POJO data accessed via service layer, similarly to
https://github.com/vaadin/addressbook/blob/master/src/main/java/com/vaadin/tutorial/addressbook/backend/ContactService.java

• Reviews
  • score
  • name
  • date tasted
• Categories

Service layer calls for first iteration:

List<Review> findReviews()
List<Review> findReviewsByString(String filterText)
List<Category> findCategories()
List<Category> findCategories(String filterText)
Review saveReview(Review review)
boolean deleteReview(ID/Review review)
Category saveCategory(Category category)
boolean deleteCategory(Category category)

SingletonHolder was needed earlier to solve a static initialization order bug between the two services. Since static data has been moved out to a separate class, the SingletonHolders might not be needed anymore. Verify this and if so, remove them and move their code into the outer classes.

This should cover following topics/files with brief explanation and a link to corresponding place in Flow documentation in github/vaadin/flow

• bower.json and /bower_components
• package.json
• polymer.json & index.html

At least the web component integration doc refers to bower, that should be updated accordingly.

main layout style names have strange convention; why not use the toplevel main-layout name in the styles instead?

When listing categories, I want to be able to search the categories, so that I may find the correct category faster.

Similar full text search as in #8 for reviews, but now for categories.

When tasting, I want to be able to enter a new review, so that I can track my tasting experiences.

See screenshot. The name is required (size > 2), the score is from 0-5, and the date picker should have the current date preselect. The default category is undefined.

When looking at my reviews, I want to easily filter them, so that I can find out if I have already reviewed something

There is a search field on top of the list of reviews, and that should do a full text search on the reviews.

Write up what is in the view and how it works:

• binder used
  • link to documentation on binder (in github/vaadin/flow)
• what other concepts used, if any

Readme should have links to the documentation topics in /documentation.

Like

It is saved correctly:

Moreover, the error message for numbers larger than Integer.MAX_VALUE is confusing:

Currently the static data used to generate reviews is inside the service classes. This tangles them up quite badly into a mutual dependency. Refactor code to extract static data into a separate class inside the same package.

Blocked for now since Valo2 will be coming from the platform dependency via WebJars instead of as a direct front-end dependency. Let's see what we do for this

The full name of the starter should be Beverage Buddy App Starter for Flow, and the shortened name in (repo name and in code) should be beverage-app-starter-flow.

Write a bit about the PaperToast component included in the project:

• What are the necessary parts for it and why
  • dependency bower.json
• link to flow documentation on
  • integrating a web component
  • anything other required

Please fix the current read me as it is totally out of date. You should mention:

• what is the user looking at
• what is in there
• how to get started (git clone & mvn run)

Currently ReviewService.saveReview() can't handle the case when a new Review is added which contains a new Category (that is, the category itself has not yet been persisted into CategoryService, thus it has no id). If this happens, the new category won't be persisted, so it won't show up in the Category view either and is not editable/deletable.

This can not currently happen via the UI, still it would be good to handle the use case properly.

Should also handle the "undefined" pseudo-category properly:

• currently an NPE occurs when opening the Add Review dialog, due to the category of the new review object being null
• overall, should we have a dedicated "dummy" Category object to represent this?

E.g.