30days's People
30days's Issues
Try to keep each file small, not to many lines of code and use more function to enhance usability
File Day8.js has too many lines of code. We should split it into multi files or create functions for each purpose like PlayAudio, ResumeAudio,...
Apply useMemo in Infor.js & Objective.js
Fixed InputComponent in Folder ReuseComponent
Fixed InputComponent in Folder ReuseComponent:
- Edit condition to render label
Add Homepage
Add Homepage
Modify page Day4 to Component & use SCSS
Modify page Day4 to Component & use SCSS
Replace Footer.css With Footer.scss
Replace Footer.css With Footer.scss
Add jsconfigs.json
PR-4
Modify page Day3 to Component & use SCSS
Modify page Day3 to Component & use SCSS
Add Card Component
Add Card Component
Changed Attribute class in src/component/Slider.js
- Changed attribute class to className
Fix 'Unexpected duplicate selector ".col", first used at line 3 (no-duplicate-selectors)' issue in src\assets\css\grid.css
CodeFactor found an issue: Unexpected duplicate selector ".col", first used at line 3 (no-duplicate-selectors)
It's currently on:
src\assets\css\grid.css:34
add new Eshope pages
Add Header and Footer to ReactRouter
Add Header and Footer to ReactRouter
src\parts\Footer.js:14
Day11 Todo App use Redux toolkit
Create page day11 : Todo App use Redux toolkit
Remove some unused link in Header Component
Remove some unused link in Header Component
Modify page About to Component & use SCSS
Modify page Aboutto Component & use SCSS enhancement
Class names are too ambitious
Lines 48 to 62 in 9f610b3
There are many class names which are ambitious like fas fa-bars. Class name should convey the idea when reading code
Update Infor.js & Objective.js
Apply useMemo in Infor.js & Objective.js
Convert State in AboutSectionReducer to enum
[src/store/reducers/AboutSectionReducer.js]
Fix 5 Accessibility issues in multiple files
CodeFactor found multiple issues:
img elements must have an alt prop, either with meaningful text, or an empty string for decorative images.
Must use Redux to manage states
We must use Redux to manage states of components. Never hard code.
Changed Attribute class in listComponent
- Changed class to ClassName
- Change logics !== to ===
Add AppLayout And Fixed Route in App.js
Add Header Footer to all pages, but custom component Header in pages Day1:
- Create
<AppLayout />
Component. And Use<AppLayout />
with path="/"
const AppLayout = () =>
(<>
<Header />
<Outlet />
</>)
In < App />
Component Return
<Routes>
<Route path="Day1" element={<Day1 />} />
<Route path="/" element={<AppLayout />}>
<Route path="Day2" element={<Day2 />} />
<Route path="Day3" element={<Day3 />} />
<Route path="Day4" element={<Day4 />} />
<Route path="/" element={<Homepage />} />
</Route>
<Route path="*" element={<Navigate replace to="/404NotFound" />} />
</Routes>
Modify page Day5 to Component & use SCSS
Modify page Day5 to Component & use SCSS
Fixed Route
Fixed Route
Update page About
Remove unuse hooks, useless props, add Header component
Merge branch gitLFS to master
- Merge branch gitLFS to master
Add HomePage and Not Found Page
Replaced Component Content with Homepage
Replaced Component Content with Homepage
Remove unuse hooks, useless props
- Remove unuse hook in src/pages/About/About.js
- Remove props onClick
- Change class to className
Replaced class with className
Replaced class with className in:
- src/component/About/Project.js
- src/component/ListComponent.js
- src/component/Slider.js
- src/pages/About/About.js
- src/component/About/ProjectJSThuan.js
Need to fix all these issues
I have set up CI but it doesn't work now because of warning when building. Please fix all issues listed in CodeFactor: Stype, Maintainability
Fixed Routes in App.js
FIxied Route in file App.js
Fix 7 Duplication issues in multiple files
CodeFactor found multiple issues last seen at fcaef09:
Duplicate Code
- src\pages\data.js:30-60
- src\pages\data.js:58-88
- src\pages\data.js:16-32
- src\pages\data.js:30-46
- src\pages\data.js:58-74
- src\pages\About\index.css:209-226
- src\pages\About copy\index.css:144-161
- src\pages\Day8\Day8.js:112-132
- src\pages\Day8\Day8.js:143-164
- src\pages\About copy\About.js:23-32
- src\pages\About\About.js:67-76
- src\component\About\objective.css:14-40
- src\component\About\infor.css:6-35
- src\pages\About copy\About.js:111-120
- src\component\About\Objective.js:15-24
Fixed Day8 MediaPlayer
Fixed MediaPlayer Day8:
When the PauseButton or PlayButton is clicked or onChange SeekBar, the State does not need to be displayed again. When AudioSrc changes the new state needs to be changed
- use Hook useEffet or useForwardRef
Add features for page Proffile
Add features Auto-Playing Slideshow by using lib React-Slick
Refer: https://react-slick.neostack.com/docs/example/auto-play-methods/
Using Git LFS for binary files like .png, .mp3
All binary files in repo should be manged by Git LFS. Search more https://git-lfs.github.com/
Fix Complex Method Day8.js
CodeFactor found an issue: Complex Method
It's currently on:
src\pages\Day8\Day8.js:66-81
Use Library UUID for key in component
Use Library UUID for key in component.
Modify page Day1 to Component & use SCSS
Replace Page Day1 & Component Day1 files css With files scss
Create Form Validator Day5
Create Form Validator Day5
Modify page Day2 to Component & use SCSS
Each Day should be in a component
Each Day should be in a component
Replace Header.css With Header.scss
Replace Header.css With Header.scss
Fixed link and remove unused lib in Header.js
Fixed link and remove unused lib in Header.js
Need to change Router
Need to fix the router to make it easier to use for nested routes
Add Not Found Page
Add Not Found Page
Change extension of all file .css to .scss
If you use SCSS, change file extension to .scss to distinguish easyly
Change data.js
- Render icon to component Objective error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.