The 30days from v-dat

    
           <div className="header grid " > 
        
               <div className="nav row"> 
        
                 <div className="nav__item"><Link to="/" onClick={handleAdd} >Home</Link></div> 
        
                 <div className="nav__item"><Link to="/News" onClick={handleAdd}>News</Link></div> 
        
                 <div className="nav__item"><Link to="/About" onClick={handleAdd} >About</Link></div> 
        
                 <div className="nav__item nav__item--menu" onClick={handleShowMenu} > 
        
                   <i className="fas fa-bars"></i> 
        
                 </div> 
        
                 <div className="sub-nav" onClick={handleUnShowMenu}> 
        
                         <div className="sub-nav__item"><Link to="/About" onClick={handleAdd} >About</Link></div> 
        
                         <div className="sub-nav__item"><Link to="/News" onClick={handleAdd}>News</Link></div> 
        
                    </div> 
        
               </div> 
        
           </div>

There are many class names which are ambitious like fas fa-bars. Class name should convey the idea when reading code

Update Infor.js & Objective.js

Apply useMemo in Infor.js & Objective.js

Convert State in AboutSectionReducer to enum

[src/store/reducers/AboutSectionReducer.js]

Fix 5 Accessibility issues in multiple files

CodeFactor found multiple issues:

img elements must have an alt prop, either with meaningful text, or an empty string for decorative images.

Must use Redux to manage states

We must use Redux to manage states of components. Never hard code.

Changed Attribute class in listComponent

Changed class to ClassName
Change logics !== to ===

Add AppLayout And Fixed Route in App.js

Add Header Footer to all pages, but custom component Header in pages Day1:

Create <AppLayout /> Component. And Use <AppLayout /> with path="/"

const AppLayout = () => 
(<>
    <Header />
    <Outlet />
</>)

In < App /> Component Return

<Routes>
    <Route path="Day1" element={<Day1 />} />
    <Route path="/" element={<AppLayout />}>
        <Route path="Day2" element={<Day2 />} />
        <Route path="Day3" element={<Day3 />} />
        <Route path="Day4" element={<Day4 />} />
        <Route path="/" element={<Homepage />} />
    </Route>
    <Route path="*" element={<Navigate replace to="/404NotFound" />} />
</Routes>

Ref: https://stackoverflow.com/a/69999387/18710441

Modify page Day5 to Component & use SCSS

Fixed Route

Update page About

Remove unuse hooks, useless props, add Header component

Merge branch gitLFS to master

Merge branch gitLFS to master

Add HomePage and Not Found Page

Replaced Component Content with Homepage

Remove unuse hooks, useless props

Remove unuse hook in src/pages/About/About.js
Remove props onClick
Change class to className

Replaced class with className

Replaced class with className in:

src/component/About/Project.js
src/component/ListComponent.js
src/component/Slider.js
src/pages/About/About.js
src/component/About/ProjectJSThuan.js

Need to fix all these issues

I have set up CI but it doesn't work now because of warning when building. Please fix all issues listed in CodeFactor: Stype, Maintainability

Fixed Routes in App.js

FIxied Route in file App.js

Fix 7 Duplication issues in multiple files

CodeFactor found multiple issues last seen at fcaef09:

Duplicate Code

Fixed Day8 MediaPlayer

Fixed MediaPlayer Day8:
When the PauseButton or PlayButton is clicked or onChange SeekBar, the State does not need to be displayed again. When AudioSrc changes the new state needs to be changed

use Hook useEffet or useForwardRef

Add features for page Proffile

Add features Auto-Playing Slideshow by using lib React-Slick

After Add Feature :

Refer: https://react-slick.neostack.com/docs/example/auto-play-methods/

Render icon to component Objective error

	<div className="header grid " >
	<div className="nav row">
	<div className="nav__item"><Link to="/" onClick={handleAdd} >Home</Link></div>
	<div className="nav__item"><Link to="/News" onClick={handleAdd}>News</Link></div>
	<div className="nav__item"><Link to="/About" onClick={handleAdd} >About</Link></div>
	<div className="nav__item nav__item--menu" onClick={handleShowMenu} >
	<i className="fas fa-bars"></i>

	</div>
	<div className="sub-nav" onClick={handleUnShowMenu}>
	<div className="sub-nav__item"><Link to="/About" onClick={handleAdd} >About</Link></div>
	<div className="sub-nav__item"><Link to="/News" onClick={handleAdd}>News</Link></div>
	</div>
	</div>
	</div>

v-dat / 30days Goto Github PK

30days's People

Contributors

Stargazers

Watchers

30days's Issues

img elements must have an alt prop, either with meaningful text, or an empty string for decorative images.

Duplicate Code

Recommend Projects

Recommend Topics

Recommend Org