Code Monkey home page Code Monkey logo

domains's People

Contributors

aaryan2134 avatar apeschar avatar christyjacob4 avatar donaldtrump88 avatar eldadfux avatar goheljay avatar huluti avatar lohanidamodar avatar meldiron avatar neelshah2409 avatar rutam21 avatar sidpro-hash avatar suven-p avatar torstendittmann avatar vermakhushboo avatar wess avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

domains's Issues

Parsing blogspot.com subdomains fails

I dont think that this result is expected, also getRegisterable returns the complete domain name with the subdomain in it.
Example:

Utopia\Domains\Domain Object
(
    [domain:protected] => notcivil.blogspot.com
    [TLD:protected] =>
    [suffix:protected] =>
    [name:protected] =>
    [sub:protected] =>
    [parts:protected] => Array
        (
            [0] => notcivil
            [1] => blogspot
            [2] => com
        )

)

Invoked via

require_once(dirname(__FILE__) . "/vendor/autoload.php");
$domain = new \Utopia\Domains\Domain("notcivil.blogspot.com");

Upgrade our issue templates to use GitHub issue forms โœ๏ธ

Introduction

GitHub has recently rolled out a public beta for their issue forms feature. This would allow you to create interactive issue templates and validate them ๐Ÿคฏ.

Appwrite currently uses the older issue template format. Your task is to create GitHub issue forms for this repository. Please use Appwrite's issue templates as a reference for this PR.

Tasks summary:

  • Fork & clone this repository
  • Prepare bug report issue form in .github/ISSUE_TEMPLATE/bug.yaml
  • Prepare documentation issue form in .github/ISSUE_TEMPLATE/documentation.yaml
  • Prepare feature request issue form in .github/ISSUE_TEMPLATE/feature.yaml
  • Push changes to master and test issue forms on your fork
  • Submit pull request

If you need any help, reach out to us on our Discord server.

Are you ready to work on this issue? ๐Ÿค” Let us know, and we will assign it to you ๐Ÿ˜Š

Happy Appwriting!

๐Ÿ› Bug Report: getSuffix() empty for some domains

๐Ÿ‘Ÿ Reproduction steps

This occurs for domains with * in the suffix list: https://publicsuffix.org/list/public_suffix_list.dat
for example:

$domain = new Domain('example.com.jm');
$domain->getSuffix();

๐Ÿ‘ Expected behavior

"com.jm"

๐Ÿ‘Ž Actual Behavior

"" (empty)

๐ŸŽฒ Utopia Domain version

Version 0.2.x

๐Ÿ’ป Operating system

Linux

๐Ÿ˜ PHP Version

PHP 7.4.x

๐Ÿงฑ Your Environment

No response

๐Ÿ‘€ Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

๐Ÿข Have you read the Code of Conduct?

๐Ÿ› Bug Report: getRegisterable() did no validation format

๐Ÿ‘Ÿ Reproduction steps

    $domain_check = new Domain($data['domain']);
    var_dump($domain_check->get());
    var_dump($domain_check->getTLD());
    var_dump($domain_check->getSuffix());
    var_dump($domain_check->getRegisterable());
    var_dump($domain_check->getName());
    var_dump($domain_check->getSub());
    var_dump($domain_check->isKnown());
    var_dump($domain_check->isICANN());
    var_dump($domain_check->isPrivate());
    var_dump($domain_check->isTest());die();
string(16) "www.test-8__.com"
string(3) "com"
string(3) "com"
string(12) "test-8__.com"
string(8) "test-8__"
string(3) "www"
bool(true)
bool(true)
bool(false)
bool(false)

๐Ÿ‘ Expected behavior

test-8__.com is not valid for Register
I think should add $domain_check->isRootDomain() to check if is a valid domain with Registerable

๐Ÿ‘Ž Actual Behavior

1

๐ŸŽฒ Utopia Domain version

Version 0.2.x

๐Ÿ’ป Operating system

Linux

๐Ÿ˜ PHP Version

PHP 8.0

๐Ÿงฑ Your Environment

No response

๐Ÿ‘€ Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

๐Ÿข Have you read the Code of Conduct?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.