We still have some legacy logos in our image directory. We need to clean up and ensure all appropriate logos are added.

The background color of NIST.gov footer is slightly darker than the background color of the footer in repo. Will want to update to keep consistent.

Hex values of background colors

NIST.gov footer - #2e2e2e
Footer repo - #333333

@mdsteveb We're adding a standard footer. Should I make a new repo or rename this one to 'nist-html-components' and add? Any preference?

We should update README.md based on changes from recent PR.

Has anyone had issues with this repo and CORS on a live site?

It would be nice to also have a workaround for local sites so they don't run into CORS issues.

We noticed two issues with the NIST header as seen in the picture:

The header and footer do not have the same color, according to the inspector:

• .nist-header: background #000
• .nist-footer: background #333333

The arrow is not centered (seems to be due to top: -2px for .nist-header__logo-icon class).

Thanks!

It seems that the NIST Snake logomark appears "by itself" in the boilerplate-header.html. Is this correct? According to the incorrect usage page, this must be approved by the NIST Director of Web Content. Please confirm if the logomark usage was approved.

jquery 1.x is ancient and I've seen it triggering some vulnerability scanners. I tested nist-header-footer with the latest jquery 3.x release and it works fine. (I had to update leaveNotice to work with it, but I did that so it is now happy with 3.x too.)

Anyway I'm of mixed feelings about having a copy of jquery in the repo at all since it will always be out of date and yet people will still be referencing it. I think it might be best to change the documentation to pull the latest 3.x jquery from the CDN by changing the script tag that loads it to this:

<script type="text/javascript" src="https://code.jquery.com/jquery-3.x-git.min.js" defer="defer"></script>

Leave the 1.9 version in the repo so we don't break anything, but don't mention it anymore.

Neither nist-header-footer nor leaveNotice do anything sophisticated so minor version changes are very unlikely to cause problems.

Then the HTML head template in the repo should be changed to match the documentation.

Sorry, I'm swamped with other stuff so haven't had time to try to put a pull request together, but ran into this today and wanted to get it filed in case you can do it.

Footer logo should either be aligned to the left or use a centered version.

See https://inet.nist.gov/pao/nist-logo for guidelines.

Maintaining all the menu links from www.nist.gov in the header is a maintenance issue and is unnecessary. We have the approval of Public Affairs to simplify the header by removing the expandable menu and adding just a few static links.

This should appear similar to what we had before implementing the menu.

No action should be necessary to update current implementations as they already load the header, css and js dynamically from the public boilerplate header.

Per Public Affairs, we need to remove the Business USA footer link.

Right now the header logo is positioned to the far left of the black banner.

Example 1

When the USA Banner is added to a site as shown in example above the logo looks out of place. Creating an optional modifier class to help with alignment when the USA banner is added could help with logo placement.

Example 2

Topics link in header bar file points to https://nistwww.dev.dd:8443/topics. Needs to be updated to point to https://www.nist.gov/topics

This repo is too complicated. When this repo started, we had the main menu included so it made sense to update it dynamically. Now the only links are footer links, which rarely change.

Dynamically loading the markup is causing some issues:

1. pages.nist.gov is not highly available
2. Usage is confusing
3. More maintenance
4. Code too complicated - have to include jQuery etc.

A few options:

1. Transition this repo to static assets
2. Move this resource to https://wcm.ipages.nist.gov/nist-component-library/latest/styleguide/ and deprecate this repo

@phernand42

I have not tested this myself but I had a report that following the instructions to add the nist-footer-bottom class to the html element per the instructions in index.html did not result in the desired effect of having the footer stuck to the bottom of the window.

I believe that was with a short page. Possibly it works with scrollable pages but not with shorter-than-window-size pages?

In May of 2022 we (ITL/SSD/SIG) were informed that tenable scans were flagging all instances of JQuery < 3.5 as security vulnerabilities and we were told to scrub all references to JQuery < 3.5 (even in code that wasn't actually running). As such any web pages / web apps include your suggested version of JQ will likely not pass muster when subjected to security screening.

The logo area in footer seems to be full width, not the image but container of logo. This in turn is making the whole entire area clickable since the logo img is wrapped by an <a> inside of container. The logo img area itself should only be clickable not the container.

Current setup

How it should be

On second line, we need to add Vote.gov to the end of the list of links and link out to that site.

I don't see a need for the full header. The only place this is used in the homepage of www.nist.gov. Let's remove it.

The nist-header component should have all the styling necessary for rendering but no more.

Add new NIST logo to footer

It would be potentially very useful if this repo were exposed on the pages server via a nist-pages branch so that other projects can link to the actual template files rather than having to copy them locally where they will become obsolete. I haven't checked whether this repo is constructed in a way to enable that, but it might be as simple as moving the code into a nist-pages branch and setting up the web hook.

Some sites hard-coded links to legacy images in this repo. To minimize error messages and facilitate a smooth transition into using the code properly, I'm going to add legacy images back to this repo since they are still valid NIST logos to use in general.