• Procure digital certificate
• Test code signing tools

@terrahaxton I merged OWA's code into our repository so the license is no longer CC0. In fact it is now MIT. As per the Contributors guidelines, since we have incorporated their code, we must now honor their license. Make sense?

Also target your PRs to the "develop" branch going forward.

The purpose of this task is to configure cmake and cpack to automate installer creation

• Create cmake install target
• Configure cpack for ZIP generator
• Configure cpack for Wix or NSIS generator

References:
https://cmake.org/cmake/help/v3.13/command/install.html
https://foonathan.net/blog/2016/03/03/cmake-install.html

https://www.slideshare.net/DanielPfeifer1/cmake-48475415
https://www.slideshare.net/DanielPfeifer1/effective-cmake

If the name of a link is more than MAXID (=31), the link cannot be found in hashtable at line 1276 in input3.c file. The line reads if ((j = findlink(net, parser->Tok[0])) == 0) return setError(parser, 0, 204);

The case was tested holds a pump with ("MAIREHAU_PUMP_STAND_BY_US.MAIREHAU_PUMP_STAND_BY_DS.1") name. The file is runnable with EPANET 2.0 but, it throws error 204 in EPANET 2.2.

One or two ways can be proposed to fix this issue. Throwing errors when the length of names exceeds 31 characters can be a good solution. I think this is a good solution, because if the 31 first characters of two links are the same, a wrong index may be found in the hashtable.

OWA has prepared a derivative work (OWA EPANET) consisting predominantly of a government work (USEPA EPANET). Therefore, pursuant to Section 403 of Copyright Act of 1976 OWA must identify those portions of the work in which copyright is claimed.

https://www.law.cornell.edu/uscode/text/17/403

• Simplify regression testing procedure
• Write SOP for running unit and reg tests
• Describe benefits of testing (target audience non-programmers)

The private test suite consists of approximately 270 input files. Of these approximately 30 produced a non-zero exit code when run using epanet v2.2.0. The following lists summarizes the causes:

• epanet v2.0.12 allowed minor variations in section tag names (only matched first five characters)
• Some link types, i.e. valves, are not being recognized in [STATUS] section
• Intermittent crashes when "Writing output report ..."
• Report file becomes unavailable when writing results (Error 303)
• 1962_1.inp, Test19.inp, Test19c.inp -- networks that were previously solvable now yield Error 110

An intermittent hard crash of the dll has been isolated to the code that frees demand category lists -- freedemands().

Dox markup epanet_output.h and epanet_output_enums.h and add to toolkit documentation package

Hi all,

I was wondering if any of you could assist me with an issue.

I need to use the epanet source code from EPA (https://www.epa.gov/water-research/epanet) and compile it with a different epanet.c file which incorporates some functions for a research project. When I try to load in matlab the new dll created with "nmake /f epanet2.mak" as described in the readme files of the original source code, I get the following error:
Error using loadlibrary
There was an error loading the library
"C:\Users\epanet2.dll"
'C:\Users\epanet2.dll' has different architecture than the host.

Trying to solve the problem, I have done the following actions:
I went back to the epanet2.mak file and effectively it is defined for Win32. I wonder if and how I can edit that configuration.
I downloaded the latest version of the OWA/epanet source code. When compiling the source files, it doesn't even create the dll due to several fatal errors associated with the edited epanet.c file.

Is there any way to get the epanet2.dll created from the original source code working on a win64 environment?

I highly appreciate any suggestions.

• Refactor testing scripts for private testing
• Get private tests running and under source code control
• Generate benchmark using EPANET v2.0.12 for private test suite
• Generate benchmark for SUT release candidate
• Investigate any differences

Add a build target for Doxygen to generate Toolkit docs and add it to the install for packaging.