urjcmakergroup / makerworkbench Goto Github PK

We overlooked this but each addon needs an SVG logo to represent it in the Addon Manager. A PR needs to be made (as mentioned in the Addon Manager github PR template to:

1. Add the workbench icon to the .qrc file: src/Mod/AddonManager//Resources/AddonManager.qrc
2. Upload the SVG to src/Mod/AddonManager/Resources/icons/
   In both commits naming conventions should be followed

In Maker/Mechatronic you utilize XPM methodology which is now considered deprecated due to HiPDi resolutions.

Please mark this high-priority. Thank you!

As instructed on Youtube I like to report an issue I am having since I installed Maker Workbench yesterday. I keep getting "/Resources/Icons/Maker_workbench_icon.svg" pop-up message and a "Cannot find icon: /Resources/icons/Maker_workbench_icon.svg" in the "Report View". This happens when I start Freecad and also when I open and existing project. It does not pop-up when I create a new project. The Maker Workbench still works but the pop-ups are annoying.

Per https://wiki.freecad.org/Package_Metadata this will represent the workbench better within the addon manager.

It would appear there's an unacceptable character in the recent package.xml changes which affects all users not just those who've installed this workbench, this is the output in Report View:

16:40:19  Checking network connection...
16:40:19  GitHub's zen message response: It's not fully shipped until it's fast.
16:40:19  Failed loading /home/john/.cache/FreeCAD/Cache/AddonManager/PackageMetadata/MakerWorkbench/package.xml
16:40:19  XML declaration not well-formed: line 1, column 52
16:40:19  Addon Manager internal error: lost metadata for package MakerWorkbench
16:40:19  Addon Manager internal error: lost metadata for package MakerWorkbench
16:40:19  Addon Manager internal error: lost metadata for package MakerWorkbench

using:

OS: Linux Mint 20.3 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.21.0.32287 (Git)
Build type: Release
Branch: master
Hash: 5b3c86d8e3fa04e540cac1cc4cb082431fd45ec6
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.3.0
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * CurvedShapes 1.0.4
  * freecad.gears 1.0.0
  * Curves 0.6.8
  * PieMenu 1.2.4
  * Plot 2022.4.17
  * AirPlaneDesign 0.4.0
  * fasteners 0.4.54
  * sheetmetal 0.2.59

By definition, in the Qt controls, the maximum length for the aluminum profile is 999mm. It would be great to allow longer distances for bigger designs:

These profiles can be purchased up to 3m in theory.

Congratulations on this great development!!!

Now tolerances for parts to be 3D printed are in kcomp.py and kparts.py
There are various tolerances, such as:

• TOL: the general tolerance
• STOL: a smaller tolerance
• TOL_BEARING_L: larger tolerance for linear bearings, since they don't always fit
• MTOL/MLTOL: which are also smaller tolerances, but MTOL is now the same as TOL

Tolerances depend on the 3D printer used, and also if it is about a lenght of a radius/diameter
Usually 0.4 mm is recommended, but it varies.

It would be great to have these tolerances more tunned, and also to have an option to increase or reduce them in case you are using a different 3D printer. And also to allow the user to set a specific value.

As an example, we have just printed the Linear Bearing Housing kcomp.SCE20UU_Pr30b, with this tolerance
MLTOL = kparts.MTOL/2. -0.1
Being MTOL=0.4, then
MLTOL = 0.1
Making the diameter to fit the bearing:
bearing_d_tol = bearing_d + 2.0 * self.MLTOL

So the diameter of the housing is 0.2 mm larger that the bearing diameter:

But with the other printer, it seems that it was ok with the original tolerance, which was:
MLTOL = kparts.MTOL
bearing_d_tol = bearing_d + 2.0 * self.MLTOL

Which would be 0.8mm larger
In previous designs, we have used 0.7 as tolerance for the diameter

Anyhow, I think that it was too much, and maybe the formula would be:
bearing_d_tol = bearing_d + self.MLTOL

And adjust from that

• Please move all icons in to MakerWorkbench/Resources/icons/
• If you are translating the workbench please create a Resources/translations directory (have you successfully been able to translate the workbench? I've seen indications in the source code)
• Rename icons so that the workbench name precedes the name of the icon. This is future-friendly since FreeCAD documentation is striving to make all documentation uniform for better interoperability within itself and external workbenches. The convention is <Workbenchname>_<Command>.svg
• Fix #4
• Remove pycache files https://github.com/URJCMakerGroup/MakerWorkbench/tree/master/Gui/__pycache__
• Change README.md Web section name to Documentation so it's less generic

I've just started scripting parts in FreeCAD. I was going to start with DIN Rails and Aluminum Extrusions, as the first thing I'm modeling up is a custom rack and enclosure system for printers and mills.

I'm going to be using DIN Rails to mount power supplies, mainboards, relays, etc...

I started with the scripting bits on the FreeCAD wiki, and arrived at some workable solutions, but once I found the source to your addon here, I really started learning better ways.

I would like to contribute DIN Rails (among other components, some listed above), but would like to know:

• would this be a component you would accept a PR for?
• aside from tests and icons, what other things would I need to look into to make sure this new component worked with or implemented so that it has the full functionality of your other components?

Acceptance Spec:

• variable W,HL axis similar to aluminum extrusions
• support rail types of 'C', 'G', 'Top Hat'
• support rail thickness? (not sure if I've ever seen a rail that wasn't 1.5mm)
• support slotted (boolean)

Helpful information on Acceptance spec:

• https://uk.rs-online.com/web/generalDisplay.html?id=ideas-and-advice/din-rails-guide