urigo / accounter-fullstack Goto Github PK

docs:

• add uploading_financial_entity attribute
• think about how to represent multiple relevant financial entities for each doc

replace all_transactions.account_number with account_id (based on financial_accounts.id)
meaning - use the ID of account as identifier instead of account number - this to prevent future duplications.
also, update the functions feeding the table.

• migrate to Yoga
• generate JSON schemas for data
• enhance Mesh’s SOAP handler to deal with result-only docs

show event_date if diff from debit_date

Tasks:

• create reversed matcher: on all-charges add match-document function that shows top 3 picks and full list ordered by date #149
• delete document button #161
• show document extended info inputs according to type selection #143
• merge documents table and matcher

misc

• on Israeli transactions, debit date is missing. If no value => (If creditcard + ILS use event_date). solve it on DB/PubSub later #153

the current one uses the temp-server and doesn't match new schema conventions.

after creation, add here (./client/src/components/allCharges/cells/):

• Entity
• Description
• Category
• Vat
• ShareWith

• docker compose
• seed script with some data
• migrations #24

{json: {…}} json: data: {documents: Array(1632)} errors: Array(1) 0: locations: Array(2) 0: column: 5 line: 107 [[Prototype]]: Object 1: column: 5 line: 128 [[Prototype]]: Object length: 2 [[Prototype]]: Array(0) message: "Unexpected error." path: Array(4) 0: "documents" 1: 1092 2: "amount" 3: "raw" length: 4 [[Prototype]]: Array(0) [[Prototype]]: Object length: 1 [[Prototype]]: Array(0) [[Prototype]]: Object [[Prototype]]: Object

the server already supports that.
client has useUpdateCharge and useUpdat
https://github.com/Urigo/accounter-fullstack/blob/edit-ledger/client/src/components/all-charges/cells/category.tsx

Basically:

1. Define the interface for the GraphQL context type -> it should include anything related to data that you might need in your resolver. Don't put helper function and things like that. Only loaders, DB connection and everything you might need to mock one day as part of testing.
2. Add that to the typescript-resolvers codegen plugin config, it's called contextType.
3. Make sure to build the context object as part of GraphQL Yoga server creation (either by using useExtendContext plugin, or by using the context option of the Yoga server.
4. Replace all direct imports to data sources / loaders and use context.something

https://www.boi.org.il/he/BankingSupervision/Pages/Open-banking.aspx

https://poalimdev.co.il/get-started

https://openbanking.isracardgroup.co.il/

https://tortilla-hq.slack.com/files/UAYN3DZ9T/F03PDM14WDA/_________________________-___________________16032022__1_.pdf

cumulative graph of the overall balance of money we have on a time scale

Issues:

• selection requires touch (add null option, make default) #124

• insert ledger failing #123

• Charge tag suggestions not working on new design #125

• vat is updating (from null to null), should be removed before mutation sent #126

• cannot generate creditcard ledger automatically

• add vat back, add amount to charge, use all_transactions currency for amount, vat, withholdingTax (edited only on amount) #128

• temporary add account number & type to charge #121

• No label for tags #125

• insert/generate buttons are not available if no data #127

• show insert ledger as card under the charge (so you can see charge details) #130

• UI that shows charge data aside for update/insert forms #130

• add credit/debit counterparties to documents table (and to UI insert/update) #131

• unlink document from charge #129

• link documents to charge flow+UI (can use test-server logic) #133

• update email listener (on test-server) to use documents table

• add trigger to update (and link) documents on insert to email_invoices

• deb7012a-fcc5-4dff-9080-cb088996bdf2 move to crisp charge

• slooooooowwww. paginate

• local currency should default to ILS #142

• insert ledger still not working #141

overall expenses together with their breakdowns in one chart

logic should match new schema.
maybe logic should move to server?

after update, add here (./client/src/components/allCharges/cells/):

• Entity
• Description
• Category
• Vat
• ShareWith

Related:

• #22

• create documents table in the DB
• add triggers to maintain data until migration completion
• update new server logic to use new table
• add logic to use email_invoice table as seed to documents

Yellow where no docs / ledger

Rethink and implement better DB structure.

later-
update server resolvers:

• Charge.beneficiaries
• Mutations.updateCharge.beneficiaries

update client:

• edit charge modal
• all-charges view

currently the unique key is account_number (which is bank account number / credit card last 4 digits) - which is not unique as DB will scale, and theoretically can be changed.
we should add id column, to match other table conventions and avoid duplications

As a method to enforce ReactElement as a return type for components
it’s important as if the component return undefined there will be a runtime error from react

not sure about the dates, I think new Date(09/10/2020) might have month-date mix.
need to double check that

• amount sign
• add uploading_financial_entity column