urbanopt / geojson-modelica-translator Goto Github PK

Create a docker image to:

1. download/install support libraries for JModelica;
2. download/install JModelica;
3. download modelica-buildings-library
4. build/compile the geojson-translator
5. run the geojson-translator

mapped to institutional blgs in TEASER. Some diversity has been achieved.

for RC models only

High level architecture discussions w/ Katherine.

Complete: 14 April

TEASER models generated when running pytest (e.g. tests/output/geojson_1/Loads/B5a6b99ec37f4de7f94020090/ICT.mo) may include parameter values that would better be rounded for readability.

Expected Behavior

  Buildings.ThermalZones.ReducedOrder.RC.TwoElements
  thermalZoneTwoElements(
    redeclare package Medium = Modelica.Media.Air.DryAirNasa,
    VAir=260.9,
    hConvExt=2.05,
    hConvWin=2.70,
    gWin=0.67

Actual Behavior

  Buildings.ThermalZones.ReducedOrder.RC.TwoElements
  thermalZoneTwoElements(
    redeclare package Medium = Modelica.Media.Air.DryAirNasa,
    VAir=260.9433707086081,
    hConvExt=2.0490178828959125,
    hConvWin=2.7000000000000006,
    gWin=0.6700000000000002,

Steps to Reproduce

Run pytest

Version Information

TEASER: URBANopt/0.7.2

TEASER models generated when running pytest (e.g. tests/output/geojson_1/Loads/B5a6b99ec37f4de7f94020090/ICT.mo) use different medium models than the ones from MBL. Especially Modelica.Media.Air.DryAirNasa is not suited for moisture modeling.

Expected Behavior

  Buildings.ThermalZones.ReducedOrder.RC.TwoElements
  thermalZoneTwoElements(
    redeclare package Medium = Buildings.Media.Air,

Actual Behavior

  Buildings.ThermalZones.ReducedOrder.RC.TwoElements
  thermalZoneTwoElements(
    redeclare package Medium = Modelica.Media.Air.DryAirNasa,

Steps to Reproduce

Run pytest

Version Information

TEASER: URBANopt/0.7.2

Running pip install -r requirements.txt yields the following error:
ERROR: tox 3.13.2 has requirement importlib-metadata<1,>=0.12, but you'll have importlib-metadata 1.3.0 which is incompatible.
However it seems innocuous as all tests pass afterwards.

1. Pick a typical air-terminals. == confirm with Nick
2. make modelica air-terminal
3. add air-terminals to translator
4. translate air-terminals to modelica
5. integrate modelica air-terminal with modelica building model

Actual Behavior

Currently, simulating the generated RC models yields the following error.

Error: The following error was detected at time: 0
End-of-file reached when reading numeric data of matrix "Internals(8760,19)" from file "/home/agautier/gitrepo/modelica-buildings/Buildings/Applications/DHC/Loads/Examples/BaseClasses/GeojsonExportRC/Resources/Data/OfficeBuilding/InternalGains_Restroom.txt"

In the referenced resource file (here InternalGains_Restroom.txt) the table attributes (here Internals(8760, 19)) are invalid and should be updated with the actual number of columns (4 and not 19).

Steps to Reproduce

Run pytest.

Version Information

Modelica Buildings Library: 7.0.0
TEASER: 0.7.2
Python: 3.7.6

@nllong This ready for your review. Please move to Done when complete.

Est Completion: 3/27

1. get the example project to work w/ TEASER. *complete
2. get to work w/ Spawn *complete

.idf files needed from Katherine/Rawad
put into repo for example project

Update systems parameters file to point to these files correctly

currently works w/ TEASER

Initial Evaluation: 17 April

Est Completion: ?

o Need to try and run the translator on a generic geojson file from URBANopt. Ask Katherine for a reasonable file to start with. Run it through the translator and figure out what is missing.
o If everything just works, then we need to demonstrate why this all matters, which speaks to creating a single design alternative for now. Perhaps that is a 4GDHC vs a 5GDHC system.

We need to get an exemplar GeoJSON from the URBANopt UI project that has, let’s say, 10 buildings in that. We need to make sure that we can translate that into a fully articulated Modelica model with 10 buildings (some can be RC models and some can be Spawn). The buildings should be connected to ETS systems and connected to an infinite source district system.

1. make a fake EnergyTransferStation modelica model
2. add ETS to translator
3. translate ETS to modelica
4. Integrate with AirTerminal and Building, both in Modelica
5. Make the process automatic
6. wait for actual ETS model from CU-Boulder,
7. integrate actual ETS with AirTerminal and Building, both in Modelica

Est Completion: 4/30

Expected Behavior

When running Spawn models the paths work okay for JModelica and the Spawn models should run in Dymola.

Actual Behavior

The IDF and EPW files are not found when running within Dymola.

Steps to Reproduce

• Run py.test to generate the tests/model_connectors/output/spawn_single project.
• Open the coupling.mo file in Dymola
• Run simulate and plot

Date Complete: 10 April

Add .mot files for creating district cooling plant

Keep Amy in the loop

Date Complete: 24 April

#39

Create a template for RC building model for connecting terminal units and flow distribution
Add unit test to exercise this functionality (TEASER)
Nick will do Spawn verification (#59)

Completed for:
Spawn (verify unit test)

Date: 14 April

List available in slide 6&7 in presentation

Est Completion: 3/20

Connect ETS to a RC building, finish the template.

assume infinite source from district system
Date Complete: 24 April

Py.test works when running from the root of the project; however, if you run a specific test with an IDE (such as PyCharm), then the tests file due to not finding the resources correctly.

This will also (likely) result in an update to the system parameters file to ensure that the paths to the supplemental resources (e.g., EPW files, MOS, files, IDF files, etc) need to be relative from the path.

Use absolute path for models in the Buildings library.
Correct file path for weather files.

The schemas have some small updates that need to be synced with this repo.

Running pip install -r requirements.txt yields:

ERROR: Invalid requirement: 'requests=2.22.0' (from line 7 of requirements.txt)
Hint: = is not a valid operator. Did you mean == ?

The test case cannot be compiled, due to a C compiling issue.

The error file is attached:
failure_compiling_C.txt

Expected Behavior

Generated Modelica models should not contain Dymola specific annotations such as:

experiment(__Dymola_Algorithm="Cvode")
__Dymola_experimentSetupOutput(...)

Those will be will be checked for through #1807.

Actual Behavior

Models generated when running pytest, e.g., tests/output/geojson_1/Loads/B5a6b99ec37f4de7f94020090/Floor.mo currently include:

annotation (experiment(
  StartTime=0,
  StopTime=31536000,
  Interval=3600,
  __Dymola_Algorithm="Cvode"),
  __Dymola_experimentSetupOutput(equidistant=true,
  events=false));

Steps to Reproduce

Run pytest

Version Information

Modelica Buildings Library: 7.0.0
TEASER: 0.7.2
Python: 3.7.6

Expected Behavior

Some description strings of generated RC models need to be corrected.

Actual Behavior

Examples are taken from tests/output/geojson_1/Loads/B5a6b99ec37f4de7f94020090/Floor.mo.

• The model description string ends with with traceable ID None.
• No description is provided for the heat port port_a.

Steps to Reproduce

Run pytest.

Version Information

Modelica Buildings Library: 7.0.0
TEASER: 0.7.2
Python: 3.7.6

This is needed until #1566 is closed (@mwetter working on it).
The two exported models simulate together only when modifying the idf files names so that they are different (the absolute paths being different is not sufficient).

Based on discussion during 3/20 meeting--how do sizing-related inputs get into system design parameters file? This will likely be different for different use cases. For high level analysis, we might like to be able to use some high-level questions in the UI to set these values.

Enable the user (and the unit tests) to run a modelica model using the jmodelica docker container.

The ETS template and related tests are requiring files in strange ways. For example:

base_folder = os.path.join(os.getcwd(), "geojson_modelica_translator")
        dest_path = "/system_parameters/schema.json"
        self.system_parameters_geojson = base_folder + dest_path

The schema.json file should not be read other than using an instance of the system_parameters file. This most likely relates to #62 since the schema is incorrect, I suspect that the ETS template is reading value from the schema and not an instance.

Furthermore, string replacements like this need to be verified.

 self.thermal_junction_properties_geojson = self.thermal_junction_properties_geojson.replace("\\", "/")

Data are being written to the tests folder that are actually being used in the ETS model

directory_up_two_levels = os.path.abspath(os.path.join(__file__, "../../.."))
        self.directory_ets_templated = os.path.join(
            directory_up_two_levels + "/tests/output_ets"
        )

The schema for the ETS elements are invalid.

These need to follow the rules of JSONSchema. The values that are present appear to be the defaults.

My test failed after build the product.
Reason: it looks for the "test" folder in TEASEROutput/Project/TestBuilding/, which is an external folder parallell to geojson-modelica-translator.
Solution-1: i copied the "test" folder within geojson-modelica-translator, to replace the "test" folder in TEASEROutput. The tests all passed.
Solution-2: py.test tests

The error message are in the attachment: failure.txt.
failures.txt

Move spawn models out of experimental and into Buildings.ThermalZones.EnergyPlus.BaseClasses.

Unit tests are working.

Currently the wrapper around TEASER RC model only exposes the convective heat port. This issue is for exposing additional connectors that are needed to model HVAC terminal units or to post process computed variables. The additional connectors to expose are:

• intGainsRad: Auxiliary port for internal radiative gains
• ports[nPorts]: Auxiliary fluid inlets and outlets to indoor air volume
• QLat_flow: Latent heat gains for the room
• TAir: Indoor air temperature
• TRad: Mean indoor radiation temperature

Update to pre-release version 0.7.2

Connect ETS to a Spawn building, finish the template.

assume infinite source from district system
Date Complete: 17 April

The branch name should be "connect_ets_RCbuilding".

When i run the testcase, i got errors, all related can not find the class Building, Medium, ..... They are all related to the Modelica Building Class.
Solution: export MODELICAPATH=/home/your-user-name/modelica-buildings
The error file is attached.
failure_CanntFindModelicaBuildings.txt

Est Completion: ?

The get methods developed for system parameters uses a custom searching format. This needs to be replaced with an official JsonPath (similar to XPath).

Actual Behavior

The generated RC models have incorrect parameter names.
Examples are taken from tests/output/geojson_1/Loads/B5a6b99ec37f4de7f94020090/Floor.mo.

• hConvExt should be hConExt.
• hConvWin...
• hConvInt...
• hConvWallOut...
• hConvWinOut...

Note: The convention in MBL (as much as possible) is to truncate to 3 characters the different patterns in the Camel case notation (except for physical quantities or other variables that have a standard symbol). Here the convention is actually violated for Wall which is unfortunate...

IN ADDITION

All instances should be renamed according with the new naming conventions.

• Modelica.Blocks.Sources.Constant alphaWall should rather be Modelica.Blocks.Sources.Constant hConWall.

Steps to Reproduce

Run pytest.

Version Information

Modelica Buildings Library: 7.0.0
TEASER: 0.7.2
Python: 3.7.6

The ROM parameters alphaInt, alphaExt, etc. have been renamed in the last version of Buildings. This is to update the export.

make sure the CI runs these tests

The CLI should be simple for now. I imagine something like:

./geojson-translator --input my.geojson --system-parameters params.json --output-directory save_here

• include SPAWN and CSV

The generated RC models (e.g. tests/output/geojson_1/Loads/B5a6b99ec37f4de7f94020090/ICT.mo) contain an invalid connect statement that needs to be removed:

connect(weaBus, weaBus)

@nllong As discussed: attached are the pytest log and the list of the installed packages in my Python environment.
pytest.log
versions.txt