upgrad / django-deletes Goto Github PK

Restores a deleted instance of a Deletable model.
(Need to decide if it restores just the instance or all cascading instances. )

Usually users do not care about old records, deleted records. Soft delete is mostly used for keeping a buffer or some kind of safety mechanism that saves the users data in unnecessary delete option. In the long run it doesnt make sense to keep old records and a clean up action may be desirable.

1. Say we delete a parent model. Parent model will be soft deleted. With all_with_delete() function we can still extract that parent model. While fetching its related models(which might be deleted as well) with all_with_deleted() gives me all the rows in that models rather than particular set which were related and deleted.

question = Question.objects.all()[100]
question.delete() - Corresponsing Answers are also deleted here

deleted_question = Question.objects.all_with_deleted(pk=q.id)
deleted_question.answers.count() give 0 which is fine
deleted_question.answers.all_with_deleted gives me all the answers rather than answer deleted and related to "deleted_question"

Restore is either cascade or single object restore. There is no way to restore according to the objects that were deleted along with a specific deletion request.

Should they have independent managers, and objects deals with only live instances? The current options may not be sufficient.

1. expose the old delete method.
2. Cascades the old delete to cascading instances
3. Can be either of the form:
   1. instance.delete(forced=True)
   2. instance.final_delete()

Consider 2 Models Parent, and Child, where Child has a Foreign Key to Parent.
Parent.objects.get(pk=1).child will return a valid object even though it is soft deleted.

Line 14: shouldn't it be *self.odering instead of *ordering

and: Line 9: list_filter instead list_display_filter