Errors when trend is flat about react-trend HOT 5 CLOSED

hey @Mattasher,

Thanks for pointing this out! Hadn't run into this bug yet.

So, I don't really like the idea of adding another prop that's so specific to this problem. One thing I've been thinking about, though, is to provide min and max props.

Sometimes, for example, you have several trends side-by-side, and you want them to all share the same data scale.

It would also solve this problem; If your data was [5, 5, 5, 5, 5], and you provided a min of 0 and a max of 10, your data would be a flat line along the middle. If the data was [0, 0, 0, 0, 0], it would run along the bottom.

(of course, a potential problem with that approach is if you provide data outside the supplied range... but maybe I can just clamp it to the range provided, and add a console warning).

from react-trend.

Published a basic fix, where lines will run along the baseline when all values are the same.

In the future, a minor version bump will allow the min/max props I described above (or something similar).

from react-trend.

Excellent! Thanks. If you want to see it in action I've added trendlines to http://growhive.io/ in the upper left corner you'll have to leave "The Nursery" and go to other Sectors to accumulate Score & Nectar.

from react-trend.

@Mattasher this is awesome!! Thanks so much for sharing, love seeing where things get used :)

I do see the issue, where once the trend fills up with the same value (eg. my score of 3 has been static the whole while), the line jumps back down to baseline. Min/max will fix that, hopefully I can make some time for it soon.

from react-trend.

(sadly, min/max is not something we need at Unsplash yet, so it's hard to justify the time for it - if you'd like to work on it, though, I'd gladly accept PRs!)

from react-trend.