Code Monkey home page Code Monkey logo

Comments (2)

joshwcomeau avatar joshwcomeau commented on July 16, 2024

Yikes, sorry for the delay! I thought I answered this.

Yeah, so if you're satisfied by how it looks in that example, by just adding a fill to the SVG path, I'd fork this project and add it (just delegate the prop down, should be very simple).

There are a few reasons it isn't officially supported:

  • Depending on your line-end, the fill doesn't extend all the way. This is visible in your screenshot, and it gets worse the larger the stroke thickness is.
  • autodraw is an animation on-mount that draws the stroke. No idea how the fill fits in with that.
  • Ideally, fill would match the gradient for the line provided.

Adding this feature the way I'd want it to be added would be a huge amount of work, and it feels funny to me to expose the fill in a way that is so problematic with the existing props.

from react-trend.

edufschmidt avatar edufschmidt commented on July 16, 2024

Any chance this could be implemented as in https://danielpataki.com/svg-chart)/ ?

from react-trend.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.