unnamedmoose / serialmonitor Goto Github PK

Can now do this since new wxFB version seems to be compatible with wx 4.0.1

It would be useful to add an option for data acquisition from any device outputting high-frequency fixed format data directly into binary or ascii files in raw integer format.

I expect the "hex output" checkbox to be greyed out unless "raw output" box is ticked. No matter how many times I select the raw output, the hex output checkbox remains greyed out.

Should be able to display at least the following two sets of info in separate dialogue boxes:

1. License,
2. Info with:
   2.1. The SerialMonitor.__version__ and __file__,
   2.2. current wx.__version__ and __file__, which is very useful in debugging installation issues.

For now just reading/writing to serial, maybe also some serial connection set up methods, too

There seems to now be a lot of printout "Debug: Too many EndStyle calls" appearing after each line in the log. This is most likely coming from some wx issues, investigate and remove the root cause or at least suppress to keep the log file for relevant information only.

Review installation instructions, license, add examples of projects that used serialMonitor, make sure all of the functionality now available is described clearly. Add more screenshots.

Observed that certain HIL tests executed manually via the GUI do not always pass. This tends to happen in cases where raw bytes are sent from the Arduino (test codes L or S, for example). However, this is just initial assessment so the issue might extend to other tests as well. It is also unclear why these tests sometimes pass and sometimes fail, like shown in the attached screenshot. The issue appears to e WX-related only, because the logger always correctly shows all the expected data.

Need further investigation to understand the true extents and origins of the problem before trying to fix it.

I was connected to a FTDI 3.3 V TTL-232 adaptor cable while there was no data being transmitted on the bus. I then unplugged the cable from the laptop, and the SerialMonitor did not recognise this. I'd expect that it notifies me that the peripheral isn't readable in such case.

When two or more invalid ASCII bytes are sent when using the formatted outputFormat, the warningSummary dictionary will only hold one entry. Every time a new invalid byte is received, the previous errors will be overwritten. This is covered by the testFormattedGoodByte_invalidASCII test case. Suggested solution is to save every error with a unique key in the warningSummary dictionary.

Makes the code cleaner and more easy to understand.

If only one invalid ASCII byte is received in the formatted outputFormat, the entire dataStr will be discarded even if it contains otherwise valid bytes. This is covered by testFormattedGoodByte_validInvalidASCII and testFormattedGoodByte_invalidValidASCII test cases.

The suggested solution is to rewrite L142 of commsInterface.py (outputBuffer += dataStr.decode('ascii')) to only decode one byte at a time.