unlcms / unl_five Goto Github PK

unl/wdntemplates has this CSS that is giving us whitespace at the bottom of the content area

.unl .dcf-main-content > :last-child:not(.dcf-bleed) {
  margin-bottom: 3.16em;
}

Should we do this?
<div class="region region-content dcf-bleed dcf-wrapper">

Currently, when a field is designated as required, the required markup is correctly added by unl_five_preprocess_form_element(); however, in the settings tray, it needs to displayed in inverse:

In unl_five_preprocess_form_element(), it's not possible to know if the settings tray is involved not. For that matter, I'm not sure if there's a good programmatic way to conditionally add the dcf-inverse class. It might be the case where CSS is the solution.

what was done on the 7 branch:

function unl_five_html_head_alter(&$head_elements) {
  // Add a preconnect HTTP header for Cloud Typography.
  drupal_add_http_header('Link', '<https://cloud.typography.com>; rel=preconnect');

In the 4.1 appearance tab, there are fields where you can set the classname for grid columns when there is a sidebar.

These fields aren't there in 5.0, and I think it would be nice to be able to switch it to a 3/4 + 1/4 column grid instead of 2/3 + 1/3.

Also, I just noticed that the "disable drilldown menu" isn't there anymore either — not sure if that will impact sites as well.

Webforms added as a component in a builder page are having centering and responsiveness issues.

It appears the DCF checkbox styles conflict with the CSS in the settings tray.

With unl_five:

With bartik:

core/jquery.form was removed in Drupal 10: https://www.drupal.org/node/3293156

Layour builder ajax submits don't work without it. It was removed in 97c8280 but needs restored.

Having the book navigation in the second sidebar puts an empty div in

civil engineering

Example use: https://www.unl.edu/gradstudies/academics/programs/update-form

unl_five loads amd-disable.js before Drupal loads the rest of its JS libraries. amd-ensable.js is loaded in the middle of the Drupal these library loads, not after all of them. Both are loaded as Drupal libraries with a large negative weight used for amd-disable.js. The theme currently attempts to use unl_five_js_alter() to set a large positive weight for amd-enable.js; however, this is not an effective method to move the library lower in the load order. In fact, there doesn't appear to be a way to load a JS library last. Drupal uses dependencies to determine load order. The only way to ensure amd-enable.js loads last is to declares everything that loads before it as dependencies. This of course means that all JS loads all the time. This issue sums it up nicely: Loading a custom library after all other libraries got loaded.

The issue was noticed when trying to use the Admin Toolbar module with the unl_five theme.

The proposed solution is to remove amd-enable.js from unl_five's 'amd' library and hardcode it in html.html.twig.

unl_five.libraries.yml:

  amd:
    version: VERSION
    js:
      js/amd-disable.js: { weight: -999 }
-     js/amd-enable.js: { }   

html.html.twig:

  {{ page_bottom }}
  {% include "/wdn/templates_5.0/includes/global/noscript.html" %}
  {% include "/wdn/templates_5.0/includes/global/js-body.html" %}
  <!-- InstanceBeginEditable name="jsbody" -->
  <js-bottom-placeholder token="{{ placeholder_token }}">
+ <script src="/{{ directory }}/js/amd-enable.js"</script>
  <!-- InstanceEndEditable -->
  </body>
  </html>

This is a broader Drupal problem: https://www.drupal.org/project/drupal/issues/953034

Right now, if you have Book Navigation set in Sidebar Second, {{ page.sidebar_second }} will render 100% of the time, even if there is no Book Nav on the particular page.

When an editor add the 'Serif' style to text in CKEditor, the correct class is added; however, the font remains unchanged visually. This is because the 'wdn-font-serif' library needs to be loaded.