udacity / fsnd Goto Github PK
View Code? Open in Web Editor NEWPublic repository for the Full-Stack Nanodegree program.
Public repository for the Full-Stack Nanodegree program.
Suggestion:
Change from "num_shows" to "num_upcoming_shows".
Hey,
I noticed that Werkzeug version in requirement.txt is 0.15.4 . Which apparently has some issue showing an error when running falsk run
The error message was TypeError: required field "type_ignores" missing from Module
and the solution to this error was upgrading Werkzeug to Werkzeug-1.0.1.
Maybe you should change the version in requirement.txt
Line 120 in e9c096d
@app.route('/headers') @requires_auth def headers(payload): print(payload) return 'Access Granted'
route to '/headers' will not work (will give 404), in Auth0 account creation, gave the audiance name as 'images', we have to change the name in Auth0 side
Thank you!
Cheers!!!
/projects/01_fyyur/starter_code/README.md > Instructions (number 6)
https://github.com/udacity/FSND/blob/master/projects/01_fyyur/starter_code/README.md
written:
Using SQLAlchemy, set up normalized models for the objects we support in our web app in the Models section of app.py. Check out the sample pages provided at /artists/1, /venues/1, and /shows/1 for examples of the data we want to model, using all of the learned best practices in database schema design. Implement missing model properties and relationships using database migrations via Flask-Migrate.
but it should be:
Using SQLAlchemy, set up normalized models for the objects we support in our web app in the Models section of app.py. Check out the sample pages provided at /artists/4, /venues/1, and /shows for examples of the data we want to model, using all of the learned best practices in database schema design. Implement missing model properties and relationships using database migrations via Flask-Migrate.
or else it'll throw exception
Action: pip install -r requirements.txt
inside virtualenv
Result:
The conflict is caused by:
The user requested pycryptodome==3.6.6
python-jose-cryptodome 1.3.2 depends on pycryptodome<3.4.0 and >=3.3.1
To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict
Your code in line 130 is wrong and returns an object which is not valid for react.
Please change it to {this.state.categories[id].type} so that your students do not have the trouble with your frontend
Hi, can you check that line:
https://github.com/udacity/FSND/blob/master/projects/03_coffee_shop_full_stack/starter_code/backend/src/database/models.py#L51
after json dump now the result is a dict object. So we should use key, value, dict.items()
if we really want to unpack a dict into a list. Not sure If I am missing something.
FSND/BasicFlaskAuth/requirements.txt
Line 17 in 2d1197d
Hi,
I tried following along with the BasicFlaskAuth
exercise, but I would keep getting this error when I try doing a GET request.
TypeError: required field "type_ignores" missing from Module
After some searching, it turned out to be a bug that existed in version 0.15.4
of Werkzeug
requirement, according to this changelog on their documentation website.
Thus, a possible fix would be to change the referenced line to Werkzeug==0.15.5
or to a later version.
After updating that line, and trying to do the GET request again, it worked with no errors.
Hopefully this issue is fixed such that it doesn't cause frustration to future learners.
Regards,
FSND/projects/01_fyyur/starter_code/app.py
Line 433 in 2d1197d
Suggestion:
Remove that TODO comment line or add the "num_shows" key to static data and the "templates/pages/shows.html".
Please update the version of typed-ast in requirement.txt, as 1.3.5 is currently not supported in python 3.9
Running setup.py install for typed-ast ... error ERROR: Command errored out with exit status 1:
getting a comma-separated string values when i use request.form['genres']
getting only the first selected genre
request.form['genres']
at '/{artist or venue}/create'
routeI know almost nothing about WT Forms and used the solution in #54 to fix the create page but when I saw this line I guessed that the result should be in comma-separated format
If the locale is not specified when calling babel.dates.format_datetime(), it throws the following error:
AttributeError: 'NoneType' object has no attribute 'days'
The fix on my Windows 10 machine is the following:
return babel.dates.format_datetime(date, format, locale='en')
In FSND/projects/01_fyyur/starter_code/app.py under models section in show_artist function on line 275 the TODO is incorrect
shows the venue page with the given venue_id
TODO: replace with real venue data from the venues table, using venue_id
Venue should be replaced with artist.
The flagged behavior --no-site-packages has been deprecated from virtualenv. Instead the installation should read $ virtualenv env
excluding the flag --no-site-packages
.
To work with Python 3.10, the collections.Callable
must be set to:
import collections
import collections.abc
collections.Callable = collections.abc.Callable
The readme instructs the users to seed db in migrate.
This is apparently not a requirement according to your reviewers please fix
*.svg icons are not displaying on the app page.
file names must be capitalized.
Some students face the page not found problem without changing anything in the code, including requests that use the GET
method.
A temporary solution is to add the following line of code in the app.py
file:
https://github.com/udacity/FSND/blob/master/projects/01_fyyur/starter_code/app.py#L23
Code:
app.url_map.strict_slashes = False
Problem image:
Udacity Projects
The button label in the Add new artist form says Create Venue.
<input type="submit" value="Create Venue" class="btn btn-primary btn-lg btn-block">
I can change it if you don't mind me
I think the README should be updated to use main instead of master. The project is still using old syntax.
To work with Python 3.10, the Jinja2
version must be:
Jinja2==3.0
This is written in project instruction
Check out the sample pages provided at /artists/1, /venues/1, and /shows/1 for examples of the data we want to model
I installed and ran the fresh project in local, neither of these is working, its throwing error as below:
AttributeError: 'NoneType' object has no attribute 'days'
https://github.com/udacity/FSND/blob/master/projects/01_fyyur/starter_code/app.py#L89
Change from:
<h5>{{ venue.name }}</h5>
To:
<h5>{{ venue.name }} <small>(Upcoming shows {{venue.num_upcoming_shows}})</small></h5>
Hi team,
in your Question.js and QuestionView.js there is wrong code that leads to svg are not displayed in your starter code. Please change to:
Question.js line 23: only if category is not undefined (=true) do something. and the category type is needed and in lowercase
{category && <img className="category" src={${category.type.toLowerCase()}.svg
}/>}
QuestionView.js lin 132: again also the type is needed in lowercase
<img className="category" src={${this.state.categories[id]['type'].toLowerCase()}.svg
}/>
When building local development following the Development Setup steps, the following error happens:
Traceback (most recent call last):
File "app.py", line 10, in <module>
from flask_sqlalchemy import SQLAlchemy
ModuleNotFoundError: No module named 'flask_sqlalchemy'
Hello,
i found that the versions of js libs and packages some of the are high vulnerabilities and needs updates can i make a pull request to update them?
In the following piece of code, a task is given to implement "enum restrictions"
FSND/projects/01_fyyur/starter_code/forms.py
Line 191 in ee22b4e
genres = SelectMultipleField( # TODO implement enum restriction 'genres', validators=[DataRequired()], choices=[ ('Alternative', 'Alternative'), ('Blues', 'Blues'), ... ...
It's not clear what restrictions are needed to be implemented. Choices and the validator seem to ensuring that the correct enum is sent and at least one is chosen.
A similar todo is found here:
And also here, which seems to have no need for any enums altogether.
FSND/projects/01_fyyur/starter_code/forms.py
Line 216 in ee22b4e
I would ideally open a PR for this, but since I haven't submitted it yet, I would ask the creators of the task to review this and fix these todos. Or alternatively clarify what kind of restrictions are expected.
According to flask-wtf the Class named Form
will be removed.
FSND/projects/01_fyyur/starter_code/forms.py
Line 195 in db539dd
Hello, is the above comment meant to appear for the phone field or is it by mistake?
For now I added validation logic in my submission for the state selector but not the phone field.
Thanks.
I think there is a typo in that form tag? Can anyone confirm or I am mistaken?
In Instructions section:
Using SQLAlchemy, set up normalized models for the objects we support in our web app in the Models section of app.py. Check out the sample pages provided at /artists/1, /venues/1, and /shows/1 for examples of the data we want to model, using all of the learned best practices in database schema design. Implement missing model properties and relationships using database migrations via Flask-Migrate.
Udacity does not provide the /shows/<int:show_id>
endpoint for a /shows/1
URL.
This should be updated to:
Using SQLAlchemy, set up normalized models for the objects we support in our web app in the Models section of app.py. Check out the sample pages provided at /artists/1, /venues/1, and /shows for examples of the data we want to model, using all of the learned best practices in database schema design. Implement missing model properties and relationships using database migrations via Flask-Migrate.
Please create a github page pointing to: https://github.com/udacity/FSND/blob/master/LocalStore/index.html
then update coco link to reflect the public URL:
https://coco.udacity.com/nanodegrees/nd004-beta/locale/en-us/versions/2.0.0/parts/858461/modules/850001/lessons/850004/concepts/857086#
The button on the form on new_show.html says "Create Venue", when it should say "Create Show".
When I run the flask app, I get a "NameError: Name 'drink' is not defined" coming from the models.py.
Is there a reason to define "drink" inside the db_drop_and_create_all() function in models.py ??
models.py
def db_drop_and_create_all():
db.drop_all()
db.create_all()
# add one demo row which is helping in POSTMAN test
drink = Drink(
title='water',
recipe='[{"name": "water", "color": "blue", "parts": 1}]'
)
drink.insert()
In my local machine, I moved the "drink" variable and its insertion to the database to api.py after calling db_drop_and_create_all() and the app ran without crashing.
api.py
app = Flask(__name__)
setup_db(app)
CORS(app)
db_drop_and_create_all()
drink = Drink(
title='water',
recipe='[{"name": "water", "color": "blue", "parts": 1}]'
)
drink.insert()
def show_artist(artist_id):
# shows the venue page with the given venue_id
# TODO: replace with real venue data from the venues table, using venue_id
This label should be Create Artist, is not it?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.