Code Monkey home page Code Monkey logo

fsnd's People

Contributors

abefeinberg avatar abhiojha8 avatar abrahamfeinberg avatar albertvilacalvo avatar amyhua avatar anjalikul avatar benawad95 avatar benmini avatar grutt avatar hadi-alnehlawi avatar ivanolmo avatar iyebohboh avatar khogaeslam avatar malteleuschner avatar patnebe avatar pavloteyfel avatar pibcrib avatar robinlamb avatar ronny-udacity avatar sameh-farouk avatar sudkul avatar tasawar-hussain avatar uanjali avatar udacavs avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

fsnd's Issues

requirement.txt - Werkzeug version

Hey,
I noticed that Werkzeug version in requirement.txt is 0.15.4 . Which apparently has some issue showing an error when running falsk run
The error message was TypeError: required field "type_ignores" missing from Module and the solution to this error was upgrading Werkzeug to Werkzeug-1.0.1.
Maybe you should change the version in requirement.txt

Changes to the Auth0 Audiance Name

@app.route('/headers')

@app.route('/headers') @requires_auth def headers(payload): print(payload) return 'Access Granted'

route to '/headers' will not work (will give 404), in Auth0 account creation, gave the audiance name as 'images', we have to change the name in Auth0 side

Thank you!
Cheers!!!

Wrong instructions

/projects/01_fyyur/starter_code/README.md > Instructions (number 6)
https://github.com/udacity/FSND/blob/master/projects/01_fyyur/starter_code/README.md

written:

Using SQLAlchemy, set up normalized models for the objects we support in our web app in the Models section of app.py. Check out the sample pages provided at /artists/1, /venues/1, and /shows/1 for examples of the data we want to model, using all of the learned best practices in database schema design. Implement missing model properties and relationships using database migrations via Flask-Migrate.

but it should be:

Using SQLAlchemy, set up normalized models for the objects we support in our web app in the Models section of app.py. Check out the sample pages provided at /artists/4, /venues/1, and /shows for examples of the data we want to model, using all of the learned best practices in database schema design. Implement missing model properties and relationships using database migrations via Flask-Migrate.

or else it'll throw exception

ERROR: Cannot install -r requirements.txt (line 14) and pycryptodome==3.6.6 because these package versions have conflicting dependencies.

Action: pip install -r requirements.txt inside virtualenv

Result:

The conflict is caused by:
    The user requested pycryptodome==3.6.6
    python-jose-cryptodome 1.3.2 depends on pycryptodome<3.4.0 and >=3.3.1

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

QuestionView.js

Your code in line 130 is wrong and returns an object which is not valid for react.
Please change it to {this.state.categories[id].type} so that your students do not have the trouble with your frontend

'BasicFlaskAuth' exercise requires package updates due to a bug.

Werkzeug==0.15.4

Hi,

I tried following along with the BasicFlaskAuth exercise, but I would keep getting this error when I try doing a GET request.
TypeError: required field "type_ignores" missing from Module

After some searching, it turned out to be a bug that existed in version 0.15.4 of Werkzeug requirement, according to this changelog on their documentation website.

Thus, a possible fix would be to change the referenced line to Werkzeug==0.15.5 or to a later version.

After updating that line, and trying to do the GET request again, it worked with no errors.

Hopefully this issue is fixed such that it doesn't cause frustration to future learners.

Regards,

Broken HTML in Fyyur project

I just cloned this and set up the development server for the Fyyur project. The create artist form seems broken:
2020-05-11-230930_630x877_scrot
Screenshot of the bottom:
2020-05-11-231104_642x553_scrot

Probably related: the Genre and Facebook Link fields are both returned as 'state' in the ImmutableDict object.

typed-ast 1.3.5 is not supported in Python3.9

Please update the version of typed-ast in requirement.txt, as 1.3.5 is currently not supported in python 3.9
Running setup.py install for typed-ast ... error ERROR: Command errored out with exit status 1:

Selecting multiple genres in create venue or artist sends only the first value

Expected Behavior :

getting a comma-separated string values when i use request.form['genres']

Actual Behavior:

getting only the first selected genre

Steps to reproduce:

  • use the form to add or edit a venue or an artist
  • on controller-tier try inspecting request.form['genres'] at '/{artist or venue}/create' route

I know almost nothing about WT Forms and used the solution in #54 to fix the create page but when I saw this line I guessed that the result should be in comma-separated format
code snippet says placeholder = comma-separated values line new_artist.html line 32

Starter code has error in fortmat_datetime function

If the locale is not specified when calling babel.dates.format_datetime(), it throws the following error:
AttributeError: 'NoneType' object has no attribute 'days'

The fix on my Windows 10 machine is the following:
return babel.dates.format_datetime(date, format, locale='en')

Incorrect TODO

In FSND/projects/01_fyyur/starter_code/app.py under models section in show_artist function on line 275 the TODO is incorrect

shows the venue page with the given venue_id
TODO: replace with real venue data from the venues table, using venue_id

Venue should be replaced with artist.

Updates to ReadMe

I think the README should be updated to use main instead of master. The project is still using old syntax.

Cannot open /artists/1, /venues/1 and /shows/1 as written in Instruction

This is written in project instruction

Check out the sample pages provided at /artists/1, /venues/1, and /shows/1 for examples of the data we want to model

I installed and ran the fresh project in local, neither of these is working, its throwing error as below:

AttributeError: 'NoneType' object has no attribute 'days'

SVG are not displayed

Hi team,
in your Question.js and QuestionView.js there is wrong code that leads to svg are not displayed in your starter code. Please change to:
Question.js line 23: only if category is not undefined (=true) do something. and the category type is needed and in lowercase
{category && <img className="category" src={${category.type.toLowerCase()}.svg}/>}

QuestionView.js lin 132: again also the type is needed in lowercase
<img className="category" src={${this.state.categories[id]['type'].toLowerCase()}.svg}/>

update js libs & packages

Hello,
i found that the versions of js libs and packages some of the are high vulnerabilities and needs updates can i make a pull request to update them?

Incorrect or unclear todo

In the following piece of code, a task is given to implement "enum restrictions"

# TODO implement enum restriction

However in the code below, the enum is constrained by a choices menu and has a validator as:

genres = SelectMultipleField( # TODO implement enum restriction 'genres', validators=[DataRequired()], choices=[ ('Alternative', 'Alternative'), ('Blues', 'Blues'), ... ...
It's not clear what restrictions are needed to be implemented. Choices and the validator seem to ensuring that the correct enum is sent and at least one is chosen.

A similar todo is found here:

# TODO implement enum restriction

And also here, which seems to have no need for any enums altogether.

# TODO implement enum restriction

I would ideally open a PR for this, but since I haven't submitted it yet, I would ask the creators of the task to review this and fix these todos. Or alternatively clarify what kind of restrictions are expected.

Correction in the text of the Instructions section

README.md file:

In Instructions section:

Using SQLAlchemy, set up normalized models for the objects we support in our web app in the Models section of app.py. Check out the sample pages provided at /artists/1, /venues/1, and /shows/1 for examples of the data we want to model, using all of the learned best practices in database schema design. Implement missing model properties and relationships using database migrations via Flask-Migrate.

Udacity does not provide the /shows/<int:show_id> endpoint for a /shows/1 URL.

This should be updated to:

Using SQLAlchemy, set up normalized models for the objects we support in our web app in the Models section of app.py. Check out the sample pages provided at /artists/1, /venues/1, and /shows for examples of the data we want to model, using all of the learned best practices in database schema design. Implement missing model properties and relationships using database migrations via Flask-Migrate.

Is there a reason to create the first record in the 'drink' table in models.py?

When I run the flask app, I get a "NameError: Name 'drink' is not defined" coming from the models.py.

Is there a reason to define "drink" inside the db_drop_and_create_all() function in models.py ??

models.py

def db_drop_and_create_all():    
    db.drop_all()    
    db.create_all()    
    # add one demo row which is helping in POSTMAN test    
    drink = Drink(        
            title='water',        
            recipe='[{"name": "water", "color": "blue", "parts": 1}]'  
  )

drink.insert()

In my local machine, I moved the "drink" variable and its insertion to the database to api.py after calling db_drop_and_create_all() and the app ran without crashing.

api.py

app = Flask(__name__)
setup_db(app)
CORS(app)

db_drop_and_create_all()

drink = Drink(
    title='water',
    recipe='[{"name": "water", "color": "blue", "parts": 1}]'
    )

drink.insert()

can't run frontend of trivia

hi , it's my first time to run react project
when i try to run it i got these errors and server doesn't start
{30254190-0EC5-4FAE-9FA7-FC7EAF7FCE1B} png

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.