ucf / gmucf-utilities Goto Github PK

Description

Change wording of email "PREVIEWs" in the plugin to "TEST".

Why it's Important

To better clarify the difference between a work-in-progress test vs a final preview before a live email is sent.

Alternatives

Possible Implementation

Additional context

Describe the bug
The Send Preview button is showing up in post types other than ucf-email. This is not intended behavior.

Steps to Reproduce

1. Open a page.
2. See the button.
3. Realize the button shouldn't be there.
4. Fix it.

Expected Behavior
The opposite of what's happening now.

Possible Fix
We need to make sure this line works as expected. Something in the logic is causing it not to return out of the function.

Description

See title

Why it's Important

Make sure "[email protected]" and "[email protected]" are treated as the same email address and we don't send them two previews.

Alternatives

Possible Implementation

Additional context

Describe the bug

The instant_send() function only sends to addresses set in the Preview Recipients field; the original requester of the email does not receive previews unless they are explicitly added to the Preview Recipients field.

Steps to Reproduce

n/a; just look here:
https://github.com/UCF/GMUCF-Utilities/blob/master/includes/email-send-functions.php#L114-L120

Expected Behavior

The original requester should receive previews as well as the recipients in the preview recipients list.

Possible Fix

We should add the original requester to the list of preview recipients before sending previews.

Your environment:

n/a

Additional context

Describe the bug

See title. Issue ported over from email editor plugin.

Steps to Reproduce

1. Set up a new email post in QA and assign at least one preview recipient
2. Click "Send Preview"
3. Instead of a success banner, a warning banner with "There was a problem sending the preview." appears
4. However, when inspecting the outbound request in the console, a 200 OK response is returned

Expected Behavior

When the preview sends as expected, a success message should appear.

Possible Fix

n/a

Your environment:

n/a

Additional context

n/a

Description

See title.

Why it's Important

Per Roger, this functionality should be exclusive to the GMUCF site.

Alternatives

n/a

Possible Implementation

Copy over logic + remove from Email Editor plugin.

Additional context

n/a

Description

Move site functionality/logic that should ideally not belong in a theme into this plugin.

Why it's Important

For separation of presentation and functionality.

Alternatives

Possible Implementation

Additional context

Description

It'd be nice if we had a site option or something that allowed us to add the webcom email (or maybe any of our personal addresses) to send email previews to, in addition to an email's designated preview recipients and requester.

Why it's Important

See above/so we can review and ensure previews get sent out as expected.

Alternatives

n/a

Possible Implementation

Site option?

Additional context

n/a