It looks like there is a regression with HTTPS requests. When running the tests against requests=2.4.3
, I see the following error:
nosetests
..........E...........E...........E...............................E.......SSSSSSSS...
======================================================================
ERROR: Test that HTTPS requests work using requests.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/underdog/github/cassette/cassette/tests/test_cassette.py", line 320, in test_requestslib_https
resp = self.helper_requestslib(TEST_URL_HTTPS)
File "/home/underdog/github/cassette/cassette/tests/test_cassette.py", line 299, in helper_requestslib
r0 = requests.get(url)
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/api.py", line 60, in get
return request('get', url, **kwargs)
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/api.py", line 49, in request
return session.request(method=method, url=url, **kwargs)
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/sessions.py", line 457, in request
resp = self.send(prep, **send_kwargs)
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/sessions.py", line 569, in send
r = adapter.send(request, **kwargs)
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/adapters.py", line 362, in send
timeout=timeout
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 516, in urlopen
body=body, headers=headers)
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 304, in _make_request
self._validate_conn(conn)
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 722, in _validate_conn
conn.connect()
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/packages/urllib3/connection.py", line 195, in connect
conn = self._new_conn()
File "/home/underdog/.virtualenvs/cassette/local/lib/python2.7/site-packages/requests/packages/urllib3/connection.py", line 120, in _new_conn
if self.socket_options:
AttributeError: 'UL3CassetteHTTPSConnection' object has no attribute 'socket_options'
-------------------- >> begin captured logging << --------------------
requests.packages.urllib3.connectionpool: INFO: Starting new HTTPS connection (1): httpbin.org
--------------------- >> end captured logging << ---------------------