The design-patterns-solutions from ubcx-software-construction-2

design-patterns-solutions's People

Contributors

Stargazers

Watchers

design-patterns-solutions's Issues

AuctionHouse: solution doesn't take into account if user is highest bidder

It appears as though in the solution for AuctionHouse the user, if the user is not the highest bidder in the first round, then in subsequent rounds, the user's input is not taken into account when calculating the highest bid.

It appears that the following small change to the initiation of max in getHighestBid() would resolve this:

    private static double gethighestBid() {
        double max = auctioneer.getCurrentBid();
        for (Bidder b : bidders) {
            if (max < b.getPersonalBid()) {
                max = b.getPersonalBid();
            }
        }
        if (max == 0) {
            return auctioneer.getCurrentBid();
        } else {
            return max;
        }
    }

Here is an output from the console when running the solution for reference:

Would you like to bid again? (y/n): 
y
Enter your new bid: 200
The highest bid is currently: $200.0
Notifying bidders of the new highest bid...
Update received for: Anthony Estey, current bid is at: $200.0
Anthony Estey can't bid any higher!
Update received for: Ian Cavers, current bid is at: $200.0
Ian Cavers can't bid any higher!
Update received for: Elisa Baniassad, current bid is at: $200.0
Elisa Baniassad can't bid any higher!
Update received for: James Yoo, current bid is at: $200.0
James Yoo can't bid any higher!
Update received for: Amy Zhu, current bid is at: $200.0
Amy Zhu can't bid any higher!
Update received for: James Xiao, current bid is at: $200.0
James Xiao can't bid any higher!
The current highest bid is at: 66.0

Would you like to bid again? (y/n):

Recommend Projects