Comments (7)
@julian384 this will be fixed shortly, as in like a few hours.
from angular-chartjs.
@ziscloud Your solution is sub-optimal and you clearly do not intend to merge your work back into the main branch. Please refrain from attempting to fragment open source codebases as a result of a single feature bug fix or feature request.
That said, contributions are certainly welcome to benefit ALL users of a library. To that end, design your work in the form of a pull request that can be merged back into this main codebase that all users can rely on.
from angular-chartjs.
@petermelias I hope you understand I did not malicious. Your project is an amazing job, but when I look at the issues page, most of the open issues are not responsed. I cannot wait for so long time to get a fix, so I did that.
from angular-chartjs.
@ziscloud The point I am trying to make is that when you go ahead and "fix" something. You should do it in such a way that it is designed to be MERGED back into master so that all of the people who rely on the main repository as a "source of truth" can benefit from your changes.
I do not believe you were being malicious, you were just not being helpful.
Instead of opening a pull request, you started referring people to your fork. This is not helpful because when the main library is updated (with new features), your fork becomes useless.
Furthermore, your solution to the problem was not in line with the development of the Chart.js library, which now supports native functionality for updating chart values and automatic resizing.
If you had opened a pull request, it would have given me (and other developers) the opportunity to review your code and guide it according to the development roadmap for both projects before merging it in.
Keep in mind that when you open a pull request, you do NOT have wait for it to be merged to start using your branch. You simply use your master branch until the pull request has been merged into the main master.
This is the spirit and the purpose of open source collaboration.
from angular-chartjs.
@petermelias Yes, I am agree with you about the open source, I have removed my helpless comment posted before.
Here I want to explain is, we are using bower to manage our javascript lib and before the merge request is approved, we can not get the fix via bower, right?
By the way, please add tags/releases, then people can install/update this lib by a bower recognized version number.
from angular-chartjs.
Version 0.0.4
was tagged about 13 minutes ago, you can now install the latest code from bower
or npm
. See updated README for details. Thank you for your contributions.
from angular-chartjs.
You can modify your app's bower.json
file to install dependencies from any repository URL.
Any branch, any tag, any repo, any user.
from angular-chartjs.
Related Issues (20)
- ReferenceError: Chart is not defined at postLink HOT 3
- setting scaleStepWidth dynamically? HOT 4
- How do you use the 'advanced' features, specifically .generateLegend()? HOT 4
- Dynamically updated values don't work on pie charts HOT 2
- Issues installing via Bower and Grunt's wiredep HOT 6
- Installing via Bower (lastest version) cannot find src file HOT 2
- How i use ng-repeat with this directive?
- How i use ng-repeat with this directive?
- Can't use dynamic data HOT 2
- Legend template HOT 5
- Demo url not working HOT 2
- asynchronous data question HOT 12
- Setting up a custom width HOT 2
- How to show labels? HOT 2
- options are not applied to pie chart
- component breaks when using uglify
- Error: c[e] is not a function HOT 1
- cant seem to be able to enable tooltips in any of the charts? HOT 2
- Chart increasing height infinitely when "autofit=true" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-chartjs.