Comments (6)
it should be:
"dist/angular-chartjs.js"
from angular-chartjs.
dist/ is new since I opened this issue. I'm not sure whether bower should point at that or not, though. I don't often see dist in a repo--that's usually something created by a build tool.
from angular-chartjs.
Hello gentlemen,
I am in the middle of creating a new release for this library that compatible with the new versions of ChartJS. What you see here is a work in progress (although the code is now more or less stable). I need to release it properly and write some basic tests.
@JAAulde
As far as having dist/
in the repo goes, I generally don't include it for repos that I know will only be used as standalone NodeJS packages, especially on the server / application side. It is automatically created by the GulpJS build tasks.
The reason I DO however include it for packages like this one (that are client-side only) is because many people (using Bower or otherwise) like to have quick and easy access to the built files without having to do any extra work for including the package into their dependency structure (in the HTML).
While this can cause merge conflicts from time to time with many collaborators, it is usually fairly trivial to work out.
I will update Bower in line with the coming release. If not today, then over this weekend.
from angular-chartjs.
Hi Peter, thanks for your work and the info. Please don't think I was criticizing the presence of dist/
in the repo, I was just talking through where the main
property ought to point and what I'm accustomed to seeing. I have one distributed browser-only library and some others in the works and have considered putting a dist/
in the repo as well.
Cheers,
Jim
from angular-chartjs.
@JAAulde Oh yeah no worries I just wanted to make it clear what the purpose of it was, no criticism suspected :)
from angular-chartjs.
The versions and paths have been updated.
from angular-chartjs.
Related Issues (20)
- ReferenceError: Chart is not defined at postLink HOT 3
- setting scaleStepWidth dynamically? HOT 4
- How do you use the 'advanced' features, specifically .generateLegend()? HOT 4
- Dynamically updated values don't work on pie charts HOT 2
- Installing via Bower (lastest version) cannot find src file HOT 2
- How i use ng-repeat with this directive?
- How i use ng-repeat with this directive?
- Chart not updating HOT 7
- Can't use dynamic data HOT 2
- Legend template HOT 5
- Demo url not working HOT 2
- asynchronous data question HOT 12
- Setting up a custom width HOT 2
- How to show labels? HOT 2
- options are not applied to pie chart
- component breaks when using uglify
- Error: c[e] is not a function HOT 1
- cant seem to be able to enable tooltips in any of the charts? HOT 2
- Chart increasing height infinitely when "autofit=true" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-chartjs.