twokul / leek Goto Github PK

I noticed you copied a lot of code from https://github.com/yeoman/insight

Definitely ok, but you forgot attribution ;)

From the MIT license:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

https://github.com/twokul/leek/blob/master/lib/send.js
https://github.com/yeoman/insight/blob/master/lib/push.js

be sure to audit them, if they are including files that are not needed let them know they should be removed.

Individually this isn't a problem, but npm's loose de-duping strategy can easily cause a project like ember-cli to balloon to many megabytes.

might be good to defer requiring request until a request is made as this slows CLI boot time.

Just trying out leek for one of the tools I am working on and it seems it is at least logging the users/sessions to google analytics.
But how to set it up to see the name and the message from the track command? I followed the readme on insight but don't seem to be able to find the details, the OS or node version. Some readme for that would be really helpful. I am also willing to write it if you can just give me some more pointers. Thank you.

This change results in exposing users to errors: 61232d6

own files maybe published by mistake:

• tests/

dependencies that may need investigation:

• request 732

for CLI that use this, having to load all of request is a pretty heavy initial load hit in ember-cli about 170ms ember-cli/ember-cli#6009

We may want to explore a more light weight solution, maybe just https://nodejs.org/api/http.html#http_http_request_options_callback