twiliodeved / ivr-phone-tree-rails Goto Github PK

I am using ruby 2.1.4 and get the following error

anand@awrtc:~/twilio/ivr-phone-tree-rails$ rake test
rake aborted!
NoMethodError: undefined method fixtures' for ActiveSupport::TestCase:Class /home/anand/twilio/ivr-phone-tree-rails/test/test_helper.rb:7:inclass:TestCase'
/home/anand/twilio/ivr-phone-tree-rails/test/test_helper.rb:5:in <top (required)>' /home/anand/twilio/ivr-phone-tree-rails/test/controllers/twilio_controller_test.rb:1:inrequire'
/home/anand/twilio/ivr-phone-tree-rails/test/controllers/twilio_controller_test.rb:1:in <top (required)>' /home/anand/.rvm/gems/ruby-2.1.4/gems/railties-4.1.6/lib/rails/test_unit/sub_test_task.rb:114:inrequire'
/home/anand/.rvm/gems/ruby-2.1.4/gems/railties-4.1.6/lib/rails/test_unit/sub_test_task.rb:114:in block (3 levels) in define' /home/anand/.rvm/gems/ruby-2.1.4/gems/railties-4.1.6/lib/rails/test_unit/sub_test_task.rb:114:ineach'
/home/anand/.rvm/gems/ruby-2.1.4/gems/railties-4.1.6/lib/rails/test_unit/sub_test_task.rb:114:in block (2 levels) in define' /home/anand/.rvm/gems/ruby-2.1.4/gems/railties-4.1.6/lib/rails/test_unit/sub_test_task.rb:113:ineach'
/home/anand/.rvm/gems/ruby-2.1.4/gems/railties-4.1.6/lib/rails/test_unit/sub_test_task.rb:113:in block in define' /home/anand/.rvm/gems/ruby-2.1.4/gems/railties-4.1.6/lib/rails/test_unit/sub_test_task.rb:20:ininvoke_rake_task'
/home/anand/.rvm/gems/ruby-2.1.4/gems/railties-4.1.6/lib/rails/test_unit/testing.rake:8:in block in <top (required)>' /home/anand/.rvm/gems/ruby-2.1.4/bin/ruby_executable_hooks:15:ineval'
/home/anand/.rvm/gems/ruby-2.1.4/bin/ruby_executable_hooks:15:in `

@jarodreyes I think list_planets should be private, since it is not being exposed through the public API, what do you think?

If you agree and of course if you don't mind I can do the change and create a PR for that.

Could you all please fix these files so that we can use Rails 5.0+ ?

Gemfile
app/controllers/twilio_controller.rb
test/controllers/twilio_controller_test.rb

I have already fixed them on my local, but I want to you all to check if mine is right.
Or if you update the files above, then I can compare them to my codes.

It looks like you're trying to link "Twilio Numbers" to something in this step, but I wasn't exactly sure what you wanted it to link to, so I didn't include a fix in the PR.

https://github.com/TwilioDevEd/ivr-phone-tree-rails/blob/gh-pages/tutorial/index.jade#L36-L37

The README still contains instructions for the pg gem, and doesn't include any information about the PLANET#_NUMBER environment variables.

In the TwiML you make here, you use menu_path as the action URL:

https://github.com/TwilioDevEd/ivr-phone-tree-rails/blob/master/app/controllers/twilio_controller.rb#L14

And in the TwiML you make here, you use '/ivr/planets' as the action URL:

https://github.com/TwilioDevEd/ivr-phone-tree-rails/blob/master/app/controllers/twilio_controller.rb#L47

Would it be better to use planets_path? Or were you doing it both ways to show that this TwiML parameter is flexible?

It looks like this iteration of the app doesn't need a database, but the README instructions still tell you to set one up and the app.json also includes one.

If you do plan to keep Postgres as a dependency for this version of the app, I ran into some trouble in the README because rake db:create made a database called ivr-rails_test but rake db:migrate wanted ivr-rails_development. So I had to create ivr-rails_development manually to get through the setup.

After fixing the issue #10 I found this failure.

This assertion:

test "/planets should Play something then Hangup when 2 is chosen" do
  get :planet_selection, From: "15556505813", Digits: '2'
  assert response.body.include? "Play"
  # ...

doesn't match with the implementation of TwilioController#planet_selection:

case user_selection
when "2"
  twiml_dial("+12024173378")
when "3"
# ...

def twiml_dial(phone_number)
  response = Twilio::TwiML::Response.new do |r|
    r.Dial phone_number
  end

  render text: response.text
end

Would you mind checking this out please?

This is minor, but I might consider adding a "goodbye" stage that happens at the end of each path through the IVR.

I felt caught off guard a little by the app hanging up on me after the directions ending. And right now the planet selection endings play once, then play again, then hang up - I was expecting them to either play once and hang up, or loop forever.

A final route for each path that makes it clear the IVR is over. Maybe something like:

"Thank you for calling the ET Phone Home Service - the adventurous alien's first choice in intergalactic travel."

Poking around the source, I noticed a couple references to the automated surveys use case:

• surveys.js.coffee and surveys.css.scss
• The landing page is also still for automated surveys