Code Monkey home page Code Monkey logo

connected-block-textures's Introduction

connected-block-textures

An implementation of the MCPatcher/Optifine connected textures format on the Fabric modloader.

connected-block-textures's People

Contributors

telans avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

connected-block-textures's Issues

incompatible with indium

i'm trying to use this with sodium on 1.16.5 with indium and it's crashing when i launch the game

glass does not CTM properly

image

glass does not CTM properly the texture for the ends are the ones that are seen of glass is left/right of other glass.

NO MODS (Fresh fabric install)
Version: latest from source

Incompatibility with Lithos pack

The Lithos pack (https://www.curseforge.com/minecraft/texture-packs/lithos-core-32x-1-6-1-11-complete) has CTM support, and appears to work under Optifine. However, some of the paths it uses are not valid Identifiers, which Optifine seems to accept just fine. The pack also uses some paths starting with ~ in its matchTiles specification -- which I don't see in the spec but which optifine seems to support.

Log -- there's a combination of things CBT doesn't support yet (which is fine), and issues with naming that don't appear in optifine

When loading the pack with CBT installed, pack loading will fail if there are folders with invalid names (in this case just the coal pillars folder, and will dump exceptions from trying to load other textures (log from above is with the coal pillars name changed to be valid).

I don't know how common these things are in other packs -- but I wouldn't be surprised if these sorts of things pop up in other places too, since it sounded like at least for this pack CTM support was done a long time ago and then left fairly untouched. Are you able to work around the naming issues?

Modrinth uploads

Modrinth is a platform for sharing mods like CurseForge, has better search features and full api. I think it would be good if CBT was on it.

Use stb_image instead of AWT/ImageIO

AWT is known to be finicky on Mac and Linux. You should probably move to stb_image. Look at Minecraft's resource pack loading code for examples.

Broken biome-dependant texture colour variations

Running under MultiMC with Manjaro, using the 1.17 compiled .jar, I did some testing to pin down what mod was causing the issue, connected block textures alone being enabled caused this to happen to the Stay True resource pack's birch leaves. They are the only instance I have seen of this happening though. Purely a visual error. No wisdom to provide but just wanted to report.

image

1.20.1

Ive been looking for a mod like this forever, and the only one i find, is 1.16.
please update this!!

Fabric API 0.20 breaks CBT

OS: Mac OS, but bug is likely OS agnostic.
JVM: 8, 11, 14 (all 64 bit)
Loader version: 0.9.3+build.207
Game version: 1.16.2

Reproducible using just CBT 0.1.2 + Fabric API 0.20.0 build 399

Relevant bit from the log:

(normal log things)
[23:32:18] [main/INFO]: Backend library: LWJGL version 3.2.2 build 10
---- Minecraft Crash Report ----
// Sorry :(

Time: 5/09/20 11:32 PM
Description: Initializing game

java.lang.UnsupportedOperationException
at com.google.common.collect.ImmutableCollection.add(ImmutableCollection.java:218)
at net.minecraft.class_3304.handler$zeo000$injectCBTPack(class_3304.java:1029)
at net.minecraft.class_3304.method_18232(class_3304.java)
at net.minecraft.class_310.(class_310.java:569)
at net.minecraft.client.main.Main.main(Main.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:192)
at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:140)
at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)

Full log: here!

From a brief glance, CBT now seems to be trying to modify a ImmutableCollection, which is very :tiny_potato: in my books.

1.17 support?

I'd love to have cbt for 1.17, any ETA on when you're updating it?

CTM for pillar blocks doesn't work correctly

CTM for pillar blocks doesn't work correctly when they are place sideways (horizontal).

Here's a cut down version of my pack (John Smith Legacy) with all the logs and stems.

For example: Oak Logs.

matchBlocks=minecraft:oak_log
method=ctm
tiles=0-46
connect=block
faces=top bottom

Minecraft 1.16.2 and connected-block-textures-0.1.2+1.16

CTM Log Test
John Smith Legacy LOG TEST.zip

Also my current test world (JimStoneCraft Presentation Map) may be of help as it's got all the blocks laid out.

https://www.johnsmithlegacy.co.uk/jimstonecraft.php

Stained glass glitchy on chunk borders

In this exact spot (on a chunk border) glass renders glitchy and allows color to leek through.
I could only recreate this in one certain spot, so I can't be sure exactly what the issue is.

I am using Sodium, Indium, and CTM, along with a bunch of other mods, but the issue did persist when just using those three.

2021-02-24_14 22 21
In this image I believe the black showing through the glass is the black concrete that is way below the glass.
(The floor is a bunch of layers of glass which is what's creating the reflection, not any shaders)

Another question (a separate problem afaik but didn't think it was worth it to make another issue) is that I am getting red lines in between glass blocks. Not sure what's causing that, maybe just a sodium bug?

Something's wrong with high resolution texture packs

Description

The game freezes at the loading screen while trying to load a "heavy" resource pack. Also memory begins to leak during this process (perhaps after a while we'll get OutOfMemoryException, but I didn't wait for it to happen)

Mod list

  • Fabric API
  • CBT

Resource packs

  • Faithful-32x - Works fine since it provides x32 textures and its size is only 6-7 MB
  • NAPP_2.0 - And this big boi (385 MB, x512) causes us some problems

Support MC 1.16.4

I mostly file these as a courtesy; 1.16.4 is the last version of 1.16 and requires minimal changes to support.
Update at your convenience.

Incompatible with Sodium

Expected Behavior

Connected textures mod functions normally.

Actual Behavior

Textures do not connect.

Reproduction Steps

Built sodium on 20w27a via this

Using latest release of CBT from here

  1. Place glass
  2. Observe

System Information

  • Operating System: 5.7.4-arch1-1
  • Java Version: OpenJDK 8 latest AUR build
  • CPU: Intel i7-5600U
  • GPU: Integrated

Additional Context:

I filed an issue in their repo here as I'm not sure which mod is at fault

CBT not sensing fabric mod

I downloaded Fabric, sodium and then CBT on my macbook air running bootcamp windows. I got Sodium to work, but when I added CBT, it crashed and said: - Mod connected_block_textures depends on mod {fabric @ [*]}, which is missing! Even though I downloaded it on fabric. It still crashes without sodium, and I don't know how I can get it to work. I'm not very good with this stuff; sorry if it's because of something stupid.

Crashing after startup

When Ioad the Fabric 1.16.5 version in my Minecraft launcher it closes instantly.
I use the latest Fabric API and my PC is good enough to run this mod.
I also tried to delete the "Fabric" file and restarted my PC.
Any solutions?

Some blocks do not connect properly

I was testing a new build when I noticed that bedrock textures no longer connected properly; the textures are rotated/mirrored incorrectly. I believe it's a side effect of this?

Old:
image

New:
image

Also using ctm_compact in both of the above screenshots if relevant

1.18 support?

I tried to install this mod in 1.18, but it said there's something missing.
Will you update this mod to 1.18?

Segfault is caused in incredibly specific circumstances

https://discordapp.com/channels/507304429255393322/507982463449169932/741110063187623946 Here is an even more specific instance where this causes issues, specifically a segfault under incredibly specific circumstances. Probably a good idea to re-open.

Originally posted by @NeRdTheNed in #3 (comment)

EDIT: After more testing, the segfault happens regardless of wether the window receives focus during loading

Copy paste from discord:

I'm using MacOS, the bane of many programs. I have found a setup that reliably causes segfaults in the JVM using three mods: Connected Block Textures, Canvas Renderer and Now Playing. The issue only occurs if the game isn't given focus until Connected Block Textures has caused the JVM to output a message saying "[JRSAppKitAWT markAppIsDaemon]: Process manager already initialized: can't fully enable headless mode", and Now Playing tries to show a toast showing the name of a song on the title screen. This also only happens if Canvas is enabled.

I've created a MultiMC instance and gathered some logs if anyone wants to look at them, which you can find at (https://drive.google.com/drive/folders/1PPQxxV5F49pxHHFkSJn2bBv67Aco2VKG?usp=sharing). I'm completely lost on why this happens.

Incorrect glass pane connections

image

Glass panes do not connect properly on the edges when placed in the east-west direction and viewed while facing south. The other side looks fine, as do both sides when the panes are placed north-south.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.