Code Monkey home page Code Monkey logo

gradle-plugin-scr's People

Contributors

jdigger avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

gradle-plugin-scr's Issues

com.twcable.gradle:gradle-plugin-scr:1.2.0 fails in java 11

We are using Gradle 4x with the below dependencies to build our AEM project and it's working fine with java 8.

buildscript {
dependencies {
classpath "com.twcable.gradle:gradle-plugin-scr:1.2.0"
}
}

dependencies {
compile group: 'org.apache.felix', name: 'org.apache.felix.http.servlet-api', version: '1.1.0'
compile group: 'org.apache.felix', name: 'org.apache.felix.scr.annotations', version: '1.9.8'
}

Now, We are trying to upgrade to Java 11 where it's failing with the Felix annotations/dependencies. Do we have any workaround to make Felix work in Java 11?

Skip interface reference check / default value

Thanks for skip interface check:

   plugins.withId 'com.twcable.scr', {
        processScrAnnotations {
            skipInterfaceReferenceCheck = true
        }
    }

but without overriding it, error quite often occur but I am not sure if it is good to have it enabled by default. Maybe make whole plugin more fail-safe by setting this to true by default.

Option to turn off interface checking

While it's a very, very bad idea to do an @Reference to a class instead of a reference, you should have to ability to explicitly shoot yourself in the foot if that's what you really want.

Separate output directories

It seems like since Gradle 4.x, Gradle expects the JVM language code to be output to different classes directories. Could someone update the code to account for this?

Stacktrace:

Gradle now uses separate output directories for each JVM language, but this build assumes a single directory for all classes from a source set. This behaviour has been deprecated and is scheduled to be removed in Gradle 5.0
        at org.gradle.api.internal.tasks.DefaultSourceSetOutput.getClassesDir(DefaultSourceSetOutput.java:80)
        at org.gradle.api.internal.tasks.DefaultSourceSetOutput_Decorated.getClassesDir(Unknown Source)
        at com.twcable.gradle.scr.ScrPlugin$_addScrTask_closure1$_closure3.doCall(ScrPlugin.groovy:44)

The issue and its solution are described in a Stackoverflow post.

NPE when sources don't contain any components

NPE at if (!files.isEmpty()) { but I think that it should be if (files && !files.isEmpty()) {

        } as FilenameFilter) as List<File>

        if (!files.isEmpty()) {
            def relFiles = files.collect { file -> 'OSGI-INF/' + file.name }
            project.logger.info "Created ${relFiles}"

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.