tuturto / deep-sky Goto Github PK

Loading all planets or all starsystems currently return full dataset. Things like buildings, landed ships and such aren't needed in the client side where this data is used. Create trimmed down data sets, which return only data that is needed.

There's currently no UI level testing and sometimes client side code breaks because of that. Something like Robot Framework should be taken into use.

Would be really nice to have common loading indicator that shows player that data is currently being loaded. It would also make writing UI tests easier.

Kragii attack might happen on a planet that already has kragii attack in progress. Prevent this.

Stats (diplomacy, martial, learning, intrigue and stewardship) of generated character currently have uniform distribution. They should have normal distribution.

Most (or even almost all) widget files aren't currently used. All of unused ones should be removed.

Currently user submitted news only display avatar's name, ie. Susanna XVIII. Instead, full formal title should be displayed: Procurator Susanna XVIII or even Susanna XVIII, Procurator of Sol.

Moreover, maybe there should be link from person's name to respective person page.

Server reports Http 400, one of the required arguments is empty.

Person section of admin panel currently has breadcrumb "Home / Admin / People / Name Here". It should display name of the person currently edited there.

Probably would make sense to cache names in some common location in model so that they don't need to be loaded all the time.

There should be common error handling that:

• is based on enumerated error codes
• known how to turn error code into explanation
• can make json objects of error code and explanation
• knows how to return them back to client

It shouldn't be possible to dismiss special events. That'll just cause them to be processed, without player able to decide how to react to them.

Unit designer shows only 6 available components, even if there would be more available.

current format is messy, clean it up and use same everywhere

When building_construction table is empty, simulation gives an error PersistMarshalError "Couldn't parse field planetIdfrom database results: Failed to parse Haskell typeInt64; expected integer from database, but received: PersistNull. Potential solution: Check that your database schema matches your Persistent model definitions."

Probably related query:

SELECT "planet"."id", "planet"."name", "planet"."position", "planet"."star_system_id", "planet"."owner_id", "planet"."gravity", "building_construction"."id", "building_construction"."planet_id", "building_construction"."index", "building_construction"."progress_biologicals", "building_construction"."progress_mechanicals", "building_construction"."progress_chemicals", "building_construction"."type", "building_construction"."level"
FROM "planet" LEFT OUTER JOIN "building_construction" ON "building_construction"."planet_id" = "planet"."id"
WHERE "planet"."id" = ?

When switching from planet to another, previous planet's details are shown before new ones have been loaded from server.

Only first 50 people are shown in admin view. Rest are not available for viewing and editing. Search results are paged, but corresponding controls are missing.