Incorrect BRDF rendering of rough materials about wickedengine HOT 13 CLOSED

Seems like a plain Schlick is being used for IBL reflection, instead of DFG term.

WickedEngine/WickedEngine/shaders/surfaceHF.hlsli

Line 244 in 19280fc

F = F_Schlick(f0, f90, NdotV);

I suggest to bake DFG lookup table for IBL, or use approximations (ie. https://www.unrealengine.com/en-US/blog/physically-based-shading-on-mobile).

After replacing the Schlick with the EnvBRDFApprox in the article you linked:

Wicked Roughness 1:

Blender roughness 1:

Wicked Rougness 0:

Blender roughness 0:

from wickedengine.

I'm having problems with Blender, I couldn't really find a way to adjust roughness easily. But I agree that Blender renders it differently, as if it doesn't have fresnel effect.

The model has a roughness map, if you go on the material settings, and click on the dot at roughness ("separate color") you can then choose "remove link" in the menu. After that you can modify the roughness value globally. Wicked and Blender are close for low values, but begin to differ after 0.4 or so.

from wickedengine.

Here is another white furnace example with the tree model illustrating the issue.
https://github.com/turanszkij/WickedEngine/assets/37701550/f8d5de59-0e4b-4ff6-919b-b5cf7857c24c

from wickedengine.

Right now it mostly matches Windows 3D Viewer result

Windows 10 3D Viewer:

Wicked Engine:

(I had to remove vertex colors from the model, otherwise it's mostly balck)

from wickedengine.

I'm having problems with Blender, I couldn't really find a way to adjust roughness easily. But I agree that Blender renders it differently, as if it doesn't have fresnel effect.

from wickedengine.

Gestaltor reference GLTF viewer:

Wicked Engine:

I think it's pretty close.

from wickedengine.

Seems like a plain Schlick is being used for IBL reflection, instead of DFG term.

I suggest to bake DFG lookup table for IBL, or use approximations (ie. https://www.unrealengine.com/en-US/blog/physically-based-shading-on-mobile).

from wickedengine.

Right now it mostly matches Windows 3D Viewer result

Windows 10 3D Viewer:

Wicked Engine:

(I had to remove vertex colors from the model, otherwise it's mostly balck)

I see that, however the visual output here is definitely wrong. A bark material with those rough properties should have that metallic sheen. Therefore I would say that the PBR model in the windows 3D viewer is probably flawed as well (which isn't terribly surprising considering its a very basic viewer that isn't designed for accuracy or production rendering).
I therefore think taking orientation against both other renderers who don't exude this behaviour and real-life reference is probably better.

LVutner may be onto something with the usage of Schlick for IBL reflection.

from wickedengine.

Cool. The minor differences comes from DFG itself.

from wickedengine.

That looks a lot better! Can't wait to try it and see if it improves things :)

from wickedengine.

Some more notes on IBL DFG terms:
https://knarkowicz.wordpress.com/2014/12/27/analytical-dfg-term-for-ibl/
https://github.com/TheRealMJP/DXRPathTracer/blob/master/SampleFramework12/v1.02/Shaders/BRDF.hlsl#L209

from wickedengine.

Added this in the PR: #737
Let me know if this is matching expectations.

from wickedengine.

The following fixes were made since this issue was opened:

• applying Unreal Engine's Environment BRDF approximation for surface.F value in PBR shaders
• environment map prefiltering improvements: NdotL normalization, dynamic miplod determination
• environment map filtering only goes down to 16x16 mip level as recommended by some graphics people, also as in EXT_lights_image_based GLTF sample

from wickedengine.