Code Monkey home page Code Monkey logo

marketch's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

marketch's Issues

Adjusting markup for borders

Hey there,

Borders are counted as part of the size of an object, so if you have a box that is 20 x 20 with a 1 px border, it is marked within marketch as 22 x 22 and still includes border information in the css. This isn't too much of a problem if I have to tell my devs that this exists in this way however it is a problem if I hand off work to others who are remote as it misrepresents the size of the actual shape.

Just wanted to bring this to your attention.

Thanks

split the json data

it would be nice to have the option to split the JSON data by each artboard when exporting all artboards so that we are only loading required data. I would imagine with phasing all the artboard in one single JSON file is not good for loading time.

依旧无法导出

提示导出成功,但是在目的路径下还是找不到导出的文件。

Export SVG assets instead of PNG?

Wondering if you will be providing the option of exporting to SVG instead of PNG for the accompanying assets? Also, we would need a 3x export as well for all assets.

development process

Hi, I was wondering are you using XCode to create the plugin or just a using a normal text editor. I would like to contribute the project, I have seen a couple of bugs regarding the measurements be off by 1px. Can you tell me the tools you use to write and debug the plugin?

I have tried to use sketch-devtools, but it does not work with the latest sketch version.

Sketch beta

Sketch Beta (Version 3.4 (15009) crashes. No export / saving possible :-(

Best, Maik

Avoid useless page or artboard ?

Hi, as an InVision user I prefix all my pages and artboards width '-' to prevent them to be exported automatically.
Is it possible to add the same behaviour for marketch export ?
I'm just posting the idea, maybe I could implement it later.

BTW this is a perfect plugin, love it.

Measurement issues

Hey there,

Our team designs @2x, and we would like to have an option that would allow our developers to read the doc as follows:
-a @1x option should be 0.5px
-a @3x option should be 1.5px
Anything of that sort in the works?
Thanks!

导出不了Zip

系统日志里提示如下:
TypeError: MSSliceMaker.slicesFromExportableLayer_inRect_useIDForName_ is not a function. (In 'MSSliceMaker.slicesFromExportableLayer_inRect_useIDForName_( layer ,sliceRect ,false)', 'MSSliceMaker.slicesFromExportableLayer_inRect_useIDForName_' is undefined)

Blank HTML-files on export

I keep getting the issue that my HTML files open a blank page in the browser. The folder structure seems fine. But the browser still doesn't display anything.

Ordering artboards

I can't figure out how you can order artboards so they are listed in a specific order in the HTML file. I've tried changing the order of artboards in Sketch, and also putting numbers in front of all the artboard names to set the order but nothing seems to work in the exported HTML.

Why GoogleAnalyticsObject?

I saw this code in file export

< script >
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)})(window,document,'script','https://www.google-analytics.com/analytics.js','ga');ga('create', 'UA-67070169-1', 'auto');ga('send', 'pageview');
< /script >

I don't understand. Why insert script in file export ???

grid style issue

grid not displaying properly, I have selected the thumbnail image, but the grid is displayed at the top corner.
image

exporting speed issue

compared to sketch-origami-export https://github.com/tarngerine/sketch-origami-export the plugin takes a while to export the files, I tested exporting a single artboard on sketch-origami I managed to export it in 7 seconds but with marketch it took a full minute. A way the plugin could reduce the time for export is to check if the same name also try using saveArtboardOrSlice to save the file.

var check_name_conflict  = function(layer, depth, artboard_name) {
  var was_conflict = false;
  if (array_contains(layer_names, artboard_name + [layer name])) {
      was_conflict = true;
      log_depth("Layer name conflict: <" + [layer name] + "> already exists in artboard <" + artboard_name + ">", depth);

      // Preserve layer name modifiers + - *
      var last_char = [layer name].slice(-1);
      var has_modifier = should_ignore_layer(layer) || should_flatten_layer(layer) || should_make_layer_own_image(layer);
      if (has_modifier) {
        [layer setName:[layer name].split(last_char)[0]]; // Remove last_char
      }
      [layer setName:[layer name] + " copy"];
      if (has_modifier) {
        [layer setName:[layer name] + last_char];
      }
      log_depth("Renaming to: <" + [layer name] + ">", depth);

      check_name_conflict(layer, depth, artboard_name);
    }

  return was_conflict;
}

code snippets

check out sketch snippets useful codes for developing plugins. You could use NSPredicate to speed up the process for look for layers and also the Abstract Search Functions.

export individual art boards

first off great tool, also can you add the ability to export individual art boards and have better file names for the assets like cta_button.png

Not working in Beta 3.4

I'm not able to get the plugin to work using any of the available Export options. This was tried on different files and Artboards.

页面展示的问题

1.page以及artboard改为以左侧导航栏的形式进行展示,方便用户筛选。
2.界面在显示区域居中显示,更符合用户习惯

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.