Code Monkey home page Code Monkey logo

Comments (5)

hugoledoux avatar hugoledoux commented on June 27, 2024

Show me the input please, here I can't understand what the problem is.

from pprepair.

adrien-berchet avatar adrien-berchet commented on June 27, 2024

Here is the initial data:
pprepaire_issue1_data

And here is the complete data set I used:
test_pprepair_issue.zip

from pprepair.

hugoledoux avatar hugoledoux commented on June 27, 2024

First, your data are probably not what should be used as input in pprepair. There are many disconnected parts, and here I am not sure what I as a human would do to "repair" this dataset. What do you want to obtain in the case above where you have roads/canals (I guess...)?

Second, what happens in your first image above is that the empty part gets the value of the triangle in red, because in theory any of the adjacent polygon to a problematic polygon can be used to fix the problematic area. But this is my guess, since I am not sure if I know the meaning of the 2 colours in your image.

In brief: I'd first consider if pprepair can fix your problem here. It seems to me that snapping would perhaps be more appropriate for many of the errors that you have. pprepair was created to solve a very specific problem: fix a planar partition, not any GIS datasets.

Hope this helps.

from pprepair.

adrien-berchet avatar adrien-berchet commented on June 27, 2024
  1. For the first point, each part is supposed to be a planar partition (they are land use parcels so they are supposed to be perfecly contiguous, without any hole nor overlap). So your advice would be to run pprepair on each part separately?
  2. Sorry, I did not explained much about the pictures. The last image, in my previous post, is the original dataset. The images I firstly posted are the tagged triangulation exported using the argument -otnt. The red triangles are the ones tagged with a 0 and the others are tagged with a 1. All the triangles that are tagged with a 0 are not reconstructed in the output dataset. So there are some initial polygons that are just deleted from the final dataset. The very weird thing is that just adding a node to these polygons make them being tagged with a 1 and thus they reappear in the final dataset.
  3. Also, I am still not sure about something: is pprepair sensitive to invalid geometries? Should I repair the invidual geometries with prepair before running pprepair?

from pprepair.

hugoledoux avatar hugoledoux commented on June 27, 2024
  1. yes
  2. hmmmm, no time now to check but I advice you to use the branch "new", and use --outtr to see the triangles.
  3. yes it is. and yes you should. Use branch "new" and then by default the validation of each is done (can be skipped with --skipvalideach). The branch master automatically repairs wrong input ones, but I think it's safer to run prepair on your file first and then pprepair it.

from pprepair.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.