Code Monkey home page Code Monkey logo

Comments (3)

kennykb avatar kennykb commented on June 27, 2024

Oh, I should have mentioned, version was the 'master' branch, downloaded and compiled yesterday. GDAL and CGAL are both whatever is current on Ubuntu Xenial, I can retrieve that information if it makes a difference.

from pprepair.

kennykb avatar kennykb commented on June 27, 2024

After reading the conversations on several other issues here, I tried building from the 'new' branch.

Initially, it seems much better. The program runs impressively fast, and the irregular boundaries between the polygons are dissolved quite as I expected.

The one thing that becomes a surprise is that holes in the polygons are now filled. In the data set that I uploaded earlier, for instance, the polygon with ogc_fid=338 name='Sand Hill Unit' has had the two large enclaves on its southwestern border filled in.

I think I can work around this by adding extra polygons in upstream processing so that the holes will be occupied, and only then using pprepair to dissolve borders.

Is the filling of holes expected and unavoidable, or am I missing something?

from pprepair.

hugoledoux avatar hugoledoux commented on June 27, 2024

yes, indeed branch "new" is better sometimes, we might merge it with master soon, if we get back to working on this.

Holes will be filled, because that's the whole point of pprepair: to create a PP from a set of input. The branch "new" doesn't have yet a way to tell it that certain polygons shouldn't be filled (the master branch let,s you define a point); we might add that in the future. In the meantime, I suggest you use your hack. But

from pprepair.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.