Code Monkey home page Code Monkey logo

make_bubbles_pop's Introduction

👋 Hi, I’m Tschipcraft

A Minecraft enthusiast who sometimes posts his creations online ✨
Here you'll find all the code and resources for my Minecraft data packs, resource packs and mods.
If you have any question or suggestions don't hesitate to open an issue.
Thank you for stopping by and have a good time!


My GitHub statistics

Most Used Languages

Ko-fi button

make_bubbles_pop's People

Contributors

aviewfromthetop avatar merhaf avatar tschipcraft avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar

Forkers

calvineries aviewfromthetop squareland merhaf

make_bubbles_pop's Issues

Varied Bubble Pop Volume

Is your suggested enhancement related to a problem? Please describe.

No response

Describe the solution you'd like

It'd be nice if the sound effects for when a bubble pops had varied volume instead of all being at 0.1. Bubbles often generate in large quantities and them all popping at the same volume can be a bit annoying. In fact, maybe even some of them should make no sound at all.

Describe alternatives you've considered

No response

Additional context

No response

1.21 Support

Is your feature request related to a problem? Please describe.

No.

Describe the feature you'd like

Mod needs updated to the latest version.

Describe alternatives you've considered

N/A

Additional context

Love the mod. Thanks!

Barrels opened by other players don't spawn bubbles

Describe the bug

Opening chests or barrels creates bubbles. Watching another player open a chest, I see bubbles, but not with a barrel.

Steps to reproduce

  1. Be in multiplayer
  2. Place barrel
  3. Have friend click barrel

Expected behavior

bubble

Additional context

Using version 0.2.0 of the mod for Fabric on MC 1.20.4.

Minecraft 1.18.2 crashes after TNT or creeper exploded in water or flowing water with this mod

Describe the bug

Prime the TNT or creeper and make it explode in the water or flowing water, then the game will crash. I found this would happen in Minecraft 1.18.2 with the 0.2.0 version of the mod, but it didn't happen in Minecraft 1.20.4. And it's in Fabric.

Steps to reproduce

  1. Minecraft 1.18.2, Fabric 0.15.6 and Fabric API 0.77.0+1.18.2
  2. Prime the TNT or creeper in the water or summon TNT using command
  3. Wait until it explodes

Expected behavior

The game will crash and a crash report will generate.

Additional context

The crash report is here.crash-2024-02-06_17.46.35-client.txt

Magma block bubble column appears to pop inside the block rather than on the top

Is your feature request related to a problem? Please describe.

Title. This isn't the fault of the mod, it also happens in vanilla (the bubbles blink out of existence halfway inside the block).

Describe the feature you'd like

Either adjusting the bubbles' target Y if possible, or collision detection.

Describe alternatives you've considered

No response

Additional context

Using version 0.2.0 of the mod for Fabric on MC 1.20.4.

update to 1.20.6

Is your feature request related to a problem? Please describe.

No response

Describe the feature you'd like

just an update to 1.20.6 because this mod is cool

Describe alternatives you've considered

No response

Additional context

No response

Double the bubble pops with "Particle tweaks" on

Describe the bug

Apparently, this was "fixed" in the particle tweaks changelog but whatever fix was implemented has done nothing and
the extra bubble pops still occur
image

Steps to reproduce

  1. install bubble pops 0.2.0
  2. install particle tweaks 1.1.3
  3. look at situations where bubble pops would usually appear
  4. see that there's a second slightly out-of-sync bubble in the same place as the bubble

Expected behavior

Simply just one bubble pop, this should not showcase two bubbles at weirdly offset times and in the same places

Additional context

to be clear, while this was showcased in a quilt environment, I have tested and can confirm this appears alongside regular fabric.
also, I would have mentioned this to the particle tweaks issues, but there is no issues page linked and I couldn't find any similar way to contact the mod dev about this, so I'm just posting it here to see if you could fix it on your end

Nitpick: Literal newline in `fabric.mod.json` of 0.2.0 artifact

This doesn't seem to be a problem for the Fabric loader, but a strict parser like jq's will choke on literal newlines in strings.
Since it's not literal in the source:

make_bubbles_pop/fabric/src/main/resources/fabric.mod.json

Line 6 in f23c11c

"description": "This client-side mod makes bubble particles pop and lets them realistically rise to the water surface.\nIt also adds bubble particles to opening chests, opening barrels and explosions underwater.",

...I'm guessing the process of expanding templates is what introduces it.

1.20.6 support

Is your feature request related to a problem? Please describe.

The mod crashes when starting on 1.20.6

Describe the feature you'd like

Add a 1.20.6 support to the mod

Describe alternatives you've considered

Additional context

Crash log:

[11:07:35] [main/ERROR]: Mixin apply for mod make_bubbles_pop failed make_bubbles_pop.mixins.json:BarrelOnUse from mod make_bubbles_pop -> net.minecraft.class_3708: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Inject annotation on injectBubbles could not find any targets matching 'Lnet/minecraft/class_3708;method_9534(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;)Lnet/minecraft/class_1269;' in net.minecraft.class_3708. Using refmap make_bubbles_pop-refmap.json [PREINJECT Applicator Phase -> make_bubbles_pop.mixins.json:BarrelOnUse from mod make_bubbles_pop -> Prepare Injections ->  -> handler$dld000$make_bubbles_pop$injectBubbles(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on injectBubbles could not find any targets matching 'Lnet/minecraft/class_3708;method_9534(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;)Lnet/minecraft/class_1269;' in net.minecraft.class_3708. Using refmap make_bubbles_pop-refmap.json [PREINJECT Applicator Phase -> make_bubbles_pop.mixins.json:BarrelOnUse from mod make_bubbles_pop -> Prepare Injections ->  -> handler$dld000$make_bubbles_pop$injectBubbles(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.validateTargets(InjectionInfo.java:658) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.findTargets(InjectionInfo.java:589) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.readAnnotation(InjectionInfo.java:330) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.<init>(InjectionInfo.java:316) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.<init>(InjectionInfo.java:308) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.struct.CallbackInjectionInfo.<init>(CallbackInjectionInfo.java:46) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62) ~[?:?]
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502) ~[?:?]
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo$InjectorEntry.create(InjectionInfo.java:149) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.parse(InjectionInfo.java:710) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1329) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1053) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:395) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:422) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403) ~[sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) [sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) [sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) [sponge-mixin-0.13.3+mixin.0.8.5.jar:0.13.3+mixin.0.8.5]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422) [fabric-loader-0.15.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) [fabric-loader-0.15.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) [fabric-loader-0.15.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) [fabric-loader-0.15.11.jar:?]
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) [?:?]
	at net.minecraft.class_2358.method_10199(class_2358.java:336) [client-intermediary.jar:?]
	at net.minecraft.class_2966.method_12851(class_2966.java:53) [client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:170) [client-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) [fabric-loader-0.15.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.15.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.15.11.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100) [NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) [NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?]
---- Minecraft Crash Report ----
// Why is it breaking :(

Time: 2024-05-12 11:07:37
Description: Bootstrap

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_3708 failed
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	at net.minecraft.class_2358.method_10199(class_2358.java:336)
	at net.minecraft.class_2966.method_12851(class_2966.java:53)
	at net.minecraft.client.main.Main.main(Main.java:170)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
	... 13 more
Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [make_bubbles_pop.mixins.json:BarrelOnUse from mod make_bubbles_pop] from phase [DEFAULT] in config [make_bubbles_pop.mixins.json] FAILED during APPLY
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinApplyError(MixinProcessor.java:589)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:379)
	... 16 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on injectBubbles could not find any targets matching 'Lnet/minecraft/class_3708;method_9534(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;)Lnet/minecraft/class_1269;' in net.minecraft.class_3708. Using refmap make_bubbles_pop-refmap.json [PREINJECT Applicator Phase -> make_bubbles_pop.mixins.json:BarrelOnUse from mod make_bubbles_pop -> Prepare Injections ->  -> handler$dld000$make_bubbles_pop$injectBubbles(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.validateTargets(InjectionInfo.java:658)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.findTargets(InjectionInfo.java:589)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.readAnnotation(InjectionInfo.java:330)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.<init>(InjectionInfo.java:316)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.<init>(InjectionInfo.java:308)
	at org.spongepowered.asm.mixin.injection.struct.CallbackInjectionInfo.<init>(CallbackInjectionInfo.java:46)
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo$InjectorEntry.create(InjectionInfo.java:149)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.parse(InjectionInfo.java:710)
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1329)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1053)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:395)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:422)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
	... 16 more


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: main
Stacktrace:
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	at net.minecraft.class_2358.method_10199(class_2358.java:336)
	at net.minecraft.class_2966.method_12851(class_2966.java:53)
Mixins in Stacktrace:
	net.minecraft.class_2358:
		net.fabricmc.fabric.mixin.content.registry.FireBlockMixin (fabric-content-registries-v0.mixins.json)
	net.minecraft.class_2966:
		org.embeddedt.modernfix.common.mixin.feature.measure_time.BootstrapMixin (modernfix-common.mixins.json)
		net.fabricmc.fabric.mixin.registry.sync.BootstrapMixin (fabric-registry-sync-v0.mixins.json)

-- Initialization --
Details:
	Modules: 
Stacktrace:
	at net.minecraft.client.main.Main.main(Main.java:170)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Mixins in Stacktrace: None found

Overhauled smoke particle behavior

Is your feature request related to a problem? Please describe.

No response

Describe the feature you'd like

Add the overhauled bubble particle behavior but for smoke particles from campfires

8mb.video-Klm-vj6tDf3S.mp4

Describe alternatives you've considered

The Physics Mod does this but with really realistic looking smoke

Additional context

No response

Bubbles not Appearing

Describe the bug

Bubbles that are underwater will not appear if I am not underwater. Same applies to the opposite (Bubbles above water not appearing if I am underwater)

Screenshot 2023-05-20 at 19 01 39 Screenshot 2023-05-20 at 19 01 47

Steps to reproduce

No response

Expected behavior

For bubbles to be visible regardless wether you are under or above water

Additional context

The issue still applies if I remove my other texture packs

[Request] Toggle Options

Is your suggested enhancement related to a problem? Please describe.

i really love the mod even if it is just some small details, but the thing is that sometimes i just dont want the bubbles to work with some features, like when im fishing

Describe the solution you'd like

adding a option to toggle on-off in config files

Describe alternatives you've considered

disabling it
or adding modmenu config

Additional context

No response

"Overhauled bubble particle behavior" doesn't work with soul sand bubbles

Describe the bug

Bubbles aren't going around blocks (most of the time), as shown in the demonstration video.

Steps to reproduce

Quilt 1.20.1 client, using latest version of mod on a vanilla(-compatible) server.

Expected behavior

To look like the first video on this page: https://modrinth.com/mod/make_bubbles_pop

Additional context

What it looks like on my client: https://matthewrease.net/simplescreenrecorder-2023-06-27_20.15.07.mp4 (ignore my drowning lol)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.