Code Monkey home page Code Monkey logo

trustless-fund's Introduction

trustless-fund's People

Contributors

dependabot[bot] avatar kadenzipfel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

trustless-fund's Issues

Add a README

  • Getting started
  • Features
  • Use cases
  • Contributions
  • License

Deposit and withdrawal modals open simultaneously

This seems to be because the state of FundContainer sets and keeps the render modal properties as true even when they're closed, so when the component re-renders they're both open. The solution may be to use redux, or to manage the state of the modals only FundContainer.

Cannot set expiration date as current date

This is because it's converting from a date object to a timestamp before submitting the form. Instead, we'll check to see if it is the proper type before converting.

Memory leak in withdraw form

This appears on the invalid fund page.

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in WithdrawForm (at FundContainer.js:40)
    in div (at FundContainer.js:37)

Gas Optimizations

There are likely some optimizations that can be made relating to storage variables.

Address Validation

  • Beneficiary address
    • Factory submit button should be disabled if address is invalid.
    • Should display, 'Invalid address'.
  • Token contract address
    • Only applicable when custom token addresses are accepted.
  • Updated owner/beneficiary address
    • Only applicable when feature is enabled.

Convert decimal values for tokens

Since different tokens have different numbers of decimals, we'll have to find the amount of decimals to convert to whole numbers as opposed to using from/toWei.

Create fund form should be replaced by buttons

It's unlikely users want to immediately make another function, so after submission, we'll remove the form and add a 'Go to Fund' button and a 'Create Fund' button in case they want to create another fund.

Max listeners exceeded warning

Not sure if an issue with us or Metamask.

react_devtools_backend.js:6 MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 101 data listeners added. Use emitter.setMaxListeners() to increase limit

Get Trustfund address and update contract object

At the moment we pull in an example TrustFund contract object, but we want to grab the address from TrustFundFactory via the ID.

We may want to completely change the way we bring in the TrustFund contract anyway. For example, we don't need access to the contract object on the index page anyways, so we could perhaps only instantiate it on the Fund page and only after grabbing the address from the factory contract.

Add gold focus outlines

Instead of the generic blue outline that you get when elements are focused, lets make it the brand color.

Token input

  • Order token list.
    • It's ordered, but gets mixed up on search.
  • Functional search input.
  • Clicking away should close the dropdown.
  • Button click should focus input.
  • Button should have a down carat.
  • Fix stock ERC20 token logo not working in button.
  • Fix logos getting mixed up.
    • Easiest way to do this might be to add the logos to the token list object directly.
    • Note this only happens on search, so probably because they are staying in the same order.

Add more sass variables

Values that are reused throughout, such as border-radius should be represented with variables in case we decide to change them. Same goes for $color-brand: $color-gold instead of $color-gold directly.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.