trungvose / angular-spotify Goto Github PK

Requested by @qoouep on Twitter

https://twitter.com/qoouep/status/1379229477801132033

Hi @trungk18

Could you please share your reasoning about the implicitDependencies configuration between the app and the web-shared-assets lib?

In my mind the web-shared-assets would be an implicit dependency of the angular-spotify app, so that changing assets would trigger a re-build of the main app, and not the other way around.

But I can see in your nx.json that you've set the app as an implicit dependency of the lib.
https://github.com/trungk18/angular-spotify/blob/40e328e67a34eeccd8448ffdc0af68ad7b92d8f9/nx.json#L81

My guess is... maybe it doesn't matter? As both the app and the web-shared-assets artifacts go to the assets library, it should work, but... does it make sense to rebuild the assets on every app change?

Your project is being a great reference for me as I learn how to structure nx workspaces, thanks!

Suggestion, add lyrics for the music, and if possible lyrics following the song.
Maybe float lines over the interface, or separate screen to follow the lyrics.

Thanks!

Toxic electric cab service

When attempting to authorize access for the app to my Spotify account, the page displays:
"Something went wrong, please try again or check out our help area"

In the console, it logs:
"Failed to load resource: the server responded with a status of 400 ()"

Soundcloud, YT, deezer ...

Find video clip from current track FROM Spotify and play it in the spectral widget

Filter music clip video, live etc...

Google Chrome 112.0.5615.137

For some reasons, the schematics stop working after the Tailwind PR #9 was merged.

Sample command

ng generate @nrwl/angular:library --name=album --directory=web --no-interactive --dry-run

Error

Issue

Some playlist was not very safe to access track property directly, need to check for its truth before accessing its property further.

Fix

606dc2b

Awesome work!

I have a suggestion regarding the structure since you use Nx Workspace.
You could move the entire apps/angular-spotify/src/assets folder to a more generic library (e.g. libs/shared/assets).
Thus, you can use pathing to any folder within the project (apps & libs) and will have nicely architectured new lib only for assets.

P.S. I can help on this issue if you want.

HI,

Nice work. I have an suggestion:
Load the liked songs in the background(Service worker?) and save the list in the Local Storage.

I have 10k liked song and the browser crash when I try to load the liked song list.
Maybe an live stream teaching that?

Thanks!

AS-IS:

• When changing the listening device, the process bar still running but does not have sound.
• Angular Spotify not updated the current song when played in another device

Expected:

• When changing the listening device, should have notification or show like windows application
• Angular Spotify should be updated current song when played in another device

Attachment:

Run build with prod flag

Run build with prod flag and manually enabled purge

@nartc Do you have any ideas?

I need to keep the same sound volume after close and reopen de site.

I'm stared recently with Angular, Maybe you(@trungk18) can help with a video tutorial about that.
I loved the project and I want to contribute with them in the future.

Thanks!

Like the original client new feature apparently recently added.
Because the original web client is asking now for Web Notifications permission.

And I think It's a cool feature, specially thinking in the Angular study.

Thanks!

Is this project using your Spotify application?

I would like to selfhost, whats the best approach using my own Spotify credentials?

Hi. Great design and functionallity!

just one point, how do i make it work for non premium users aswell?
i have a premium account and still pops the message i don't :D.

Thanks!

While this does use NX it does not seem to define the boundary constraints between library types. Many ui libraries are depending on data-access libraries and are outside of the scope nx suggests in their documentation that can be found here.
Updating the "depConstraints" to match the suggested dependency constraints will cause eslint to fail.
Dependency Constraints
Feature Library -> can depend on any type of library.
UI Library -> can only depend on other ui or util libraries.
Data-access library -> can only depend on data-access and util libraries.
Utility library -> can only depend on utility libraries.

Hello,

Very nice project.
I have one question: how will you put i18n in that type of architecture ? Like transloco for instance ?
One json file per ui component or one global one ? But if you have multiple app sharing the same component, you'll have to duplicate keys.

Thanks

Today i missed the Search functionality using the project.

I suggest the implementation of search and REST search with Elastic Search and sharable links.

Thanks!

Thinking in educational purpose of the App.
I suggest the PWA architecture implementation.

For make the application works offline(Don't playing song, but accessible).
This approach can explore concepts with Connection Detection, Service Worker, Local Storage, Cache.

I'm anxious to see that in a Live on Youtube!

Thanks!

Suggestion, add way to detach the visualization from principal page to another page like PiP modal.
To see visualization in one screen and use the principal interface in another.

Thanks!