The deku-redux's discuss from troch

deku-redux's Issues

bump peerDependency

deku 1.0.0 is out.

Components always rerender regardless of change or not

Hi!

I'm having problems with components re-rendering on any action regardless of changes being made it not.

The following all re-render upon change. Any idea why?

export const Remarket = connect(
	state => ({})
)(RemarketComponent);

export const Row = connect()(RowComponent);

export const Remarket = connect(
	state => ({
		static: 'value'
	})
)(RemarketComponent);

Shouldn't the component only update when the state has changed?

v1.1.1 doesn't contain the mapDispatchToProps fix

#5 wasn't included here

any chance you can recompile/publish?

connect.js:128 Uncaught ReferenceError: stateProps is not defined

when accessing ownProps from within mapDispatchToProps, deku-redux throws a ReferenceError

smallest test case i could create:

import element from 'virtual-element'
import { tree, render } from 'deku'
import { createStore } from 'redux'
import { connect, storePlugin } from 'deku-redux'

const App = connect(mapStateToProps, mapDispatchToProps)({
  render () {
    return <div />
  },
  afterMount ({ props }) {
    props.something()
  }
})

function mapStateToProps (state, ownProps) {
  return {}
}

function mapDispatchToProps (dispatch, ownProps) {
  return {
    something: () => dispatch({ type: 'DID_SOMETHING' })
  }
}

const reducer = (state = {}, action) => state
const store = createStore(reducer)

const app = tree(<App foo='bar' />)
app.use(storePlugin(store))
render(app, document.getElementById('root'))

strangely enough, this works fine though:

function mapDispatchToProps (dispatch /*, ownProps*/) {
  const ownProps = arguments[1]
  return {
    something: () => dispatch({ type: 'DID_SOMETHING' })
  }
}

Recommend Projects