trevorsuter / mod_0_skills Goto Github PK

@Trevorsuter
Nice work on this- you have performed well enough on the assessment to be considered technical ready with some minor revisions. Please have these in EOD Monday:

• A little terminal practice- please remove the extra variables file within your classes directory.

• Update class names to follow PascalCase conventions.

• One method in your first class, and several methods in your second class, do not follow the pattern of starting with your active word. Give your method names a sweep and try to make sure each starts with a verb... well, not only is a verb, but used as a verb (for example shift is not used as a verb in your method name).

Not actionable feedback, but your class ideas are on the verge of encapsulation issues. I think you've done well in your kitchen class to make sure each attribute relates to instances of your class- they are pretty fundamental to kitchens- but do beware that attributes like sink_on, oven_temperature and ingredients could all seem like they are attributes of a different class. It is the combination of all those attributes that represent the kitchen, which is great, but remember that we want to make our attributes apply to all instances. I find it helps to practice making classes out of single, physical things to practice thinking in a small scope (a kitchen is a pretty big scope). No concern here, just some food for thought as you practice!