tretherington / nlmpy Goto Github PK

With the exception of the Perlin noise function, all functions currently rescale values between 0 and 1 linearly. The Perlin noise function also has options to use absolute and squared functions before linear rescaling to provide different effects. It could be useful to make these other rescaling options into general functions, and allow other NLM functions such as the mid-point displacement to also call them - as like Perlin noise the mid-point displacement algorithm produces negative and positive values.

Hi,

running the model with NumPy version >1.20 leads to the following Error

`np.int` was a deprecated alias for the builtin `int`. To avoid this error in existing code, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `np.int`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

This can be easily fixed by changing line 534 in nlmpy.py from:

N = np.int(np.ceil(np.log2(maxDim - 1)))

to:

N = np.ceil(np.log2(maxDim - 1)).astype(int)

To improve the documentation of the functions I think it would be great to write some wiki examples that show case and explain how the various NLM functions work. Perhaps pictures of real landscapes can be shown, and then how to mimic those landscapes using NLMpy?

Folks are hitting issues when using the software paper and associated supplementary materials as these are now outdated as:

1. The import statement has changed
2. The blendArrays function has changed.

I think this could be resolved by:

1. Adding a more explicit warning when mentioning the software paper that these things have changed.
2. Creating new versions of the example scripts as wiki examples, so that folks can access updated versions of the code examples that can be maintained going forward.