travelrepublic / nlog.targets.gelf Goto Github PK

When I use config example provided with this package NLog will throw me exception
System.NotSupportedException: Parameter graylogversion not supported on GelfTarget
If I delete graylogversion atribute, everything works fine.

I'm using NLog 4.4.2 and NLog.GelfTarget 4.4.1 installed from NuGet.

When you create your SocketClient you are not specifying an address family. If you are contacting a server on a different address type (in my case from an IPv6 Azure web app to an IPv4 gelf target) it throws an address incompatible with protocol error:
[SocketException (0x273f): An address incompatible with the requested protocol was used] System.Net.Sockets.Socket.SendTo(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags, EndPoint remoteEP) +2896915 NLog.Targets.Gelf.GelfTarget.SendMessage(String gelfServer, Int32 serverPort, String message) +202 NLog.Targets.Gelf.GelfTarget.Write(LogEventInfo logEvent) +184 NLog.Targets.Target.Write(AsyncLogEventInfo logEvent) +69

I grabbed the source and specified the address family to make it work correctly:
Ideally SendMessage would use gelfAddress.AddressFamily to identify what socket to use.

private static readonly Socket SocketClient = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp);
private static readonly Socket SocketClientV6 = new Socket(AddressFamily.InterNetworkV6, SocketType.Dgram, ProtocolType.Udp);

private void SendMessage(string gelfServer, int serverPort, string message)
{
var endPoint = GetIPEndPoint(gelfServer, serverPort);
var thisSock = endPoint.AddressFamily == AddressFamily.InterNetworkV6 ? SocketClientV6 : SocketClient;
...
thisSock.SendTo(messageChunkFull, 0, messageChunkFull.Length, SocketFlags.None, endPoint);