travello-gmbh / amazon-alexa-skill-library Goto Github PK

The Amazon Echo Show needs to be supported. Especially the template directives. See these links for details:

• https://developer.amazon.com/de/blogs/alexa/post/12826e9e-e06a-4ab4-a583-8e074709a9f3/how-to-build-alexa-skills-for-echo-show1
• https://developer.amazon.com/de/docs/custom-skills/build-skills-for-echo-show.html
• https://developer.amazon.com/de/docs/custom-skills/best-practices-for-echo-show-skills.html

The Session attribute handling needs to be extracted from the TravelloAlexaLibrary\Application\AbstractAlexaApplication class. This involves the following steps:

• Move initSessionAttributes() to a session container class.
• Move getSessionAttributes() to a session container class.
• Move resetSessionAttributes() to a session container class.
• The method initResponse() should be removed as well. Maybe a middleware pipeline class could handle this.
• The intent classes should get the new session container injected.
• Finally, the AbstractAlexaApplication does not need to be abstract anymore.

Currently every POST request is handled as an Alexa request. If you want to add a form to your application the InjectCertificateValidatorMiddleware and InjectAlexaRequestMiddleware throw an exception.

When working at a new Skill, I got a service request sent by the service simulator with a different timestamp format:

"request": {
    "requestId": "EdwRequestId.ea1f77ad-b269-4b61-b606-f77f65c012b0",
    "locale": "de-DE",
    "type": "LaunchRequest",
    "timestamp": 1501507326551
},

The normal format is 2017-01-26T20:38:55Z for example. To keep users from frustrating debugging this "unnormal" format should be handled.

Extend the skill configuration class TravelloAlexaLibrary\Configuration\SkillConfiguration with further fields:

• Skill name
• RenderTemplate background image
• Render template background title

Inject the SkillConfiguration class into the intents and remove the injection from the application.

Needs updates in the ZF Library intent factory as well.

Add a new Method resetSessionAttributes() to the TravelloAlexaLibrary\Application\AbstractAlexaApplication class to reset session attributes when stopping, cancelling or launching a skill.

The Text helper should be locale aware to handle international skills with more than one language.

The AbstractAlexaApplication needs to be refactored:

• CertificateValidator should be removed from AbstractAlexaApplication
• Check of application id should be removed from AbstractAlexaApplication
• Both checks should be added to the middleware pipeline
• TextHelper should be removed from AbstractAlexaApplication
• Locale for TextHelper should be set in the middleware pipeline
• TextHelper should be injected in the intent classes via factory

Further refactorings:

• Remove the need to extends the text helper class for each skill
• Remove the need to extends the intent manager class for each skill
• Add a new configuration class for current skill, e.g. for application id, intents, etc.

All Zend Framework based factory and middleware classes should be move to this new package

https://github.com/travello-gmbh/amazon-alexa-skill-zf

Aim is to reduce the dependency on Zend\ServiceManager.

Currently, all intents are tightly fixed to the TravelloAlexaLibrary\Application\AbstractAlexaApplication class. The idea behind this issue is to create single classes for each intent. Intent objects should habe access to the TravelloAlexaLibrary\Request\AlexaRequest and TravelloAlexaLibrary\Response\AlexaResponse objects and manipulate the Alexa response by changing its OutputSpeech, Card, Session Attributes, and so on.

The need to extend the AbstractAlexaApplication class to implement the handleIntentRequest() method in each application should be removed. The handleIntentRequest() should handle the intent requests automatically without the need to add each intent into a case condition.

When the service request is sent without the version the skill handling breaks with an error:

ErrorException: Undefined index: version in file /vendor/travello-gmbh/amazon-alexa-skill-library/src/Request/RequestType/RequestTypeFactory.php on line 39

When the context object is sent within an Alexa request and no AudioPlayer object is sent, the request handling fails. The TravelloAlexaLibrary\Request\Context\Context expects an AudioPlayerInterface instance as a parameter for its constructor. This should be changed. Otherwise the handling in the TravelloAlexaLibrary\Request\RequestType\RequestTypeFactory fails.

The Alexa Request Context is not implemented yet. See

• https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/alexa-skills-kit-interface-reference#request-body-syntax

Add a solution to randomize common texts like alexaLaunchMessage or alexaStopMessage or alexaCancelTitle by adding arrays for each text.

The Alexa Response Directives are not implemented yet, see:

• https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/alexa-skills-kit-interface-reference#response-body-syntax

Write a new middleware for the pipeline to add the AlexaRequest instance to the DI Container. Write another one to add the AlexaResponse instance to the DI Container. This will make it easier to access both in the application.