trapp / ethereum-bip44 Goto Github PK

bootstrap:893 Error: Cannot find module 'readable-stream/writable.js'
at webpackMissingModule (index.js:29)
at Object../node_modules/_stream-browserify@2.0.2@stream-browserify/index.js (index.js:29)
at webpack_require (bootstrap:769)
at fn (bootstrap:129)
at Object../node_modules/_hash-base@3.0.4@hash-base/index.js (index.js:3)
at webpack_require (bootstrap:769)
at fn (bootstrap:129)
at Object../node_modules/_md5.js@[email protected]/index.js (index.js:3)
at webpack_require (bootstrap:769)
at fn (bootstrap:129)

Wanted to try out this project but it seems to have conflict with bitcore-lib of bitcore itself.
When I just use npm install ethereum-bip44 it says it cannot find module bitcore. When installing bitcore manually I get the following error:

18:38 $ node
> var bitcore = require('bitcore');
undefined
> var EthereumBip44 = require('ethereum-bip44');
Error: More than one instance of bitcore-lib found. Please make sure to require bitcore-lib and check that submodules do not also include their own bitcore-lib dependency.
    at Object.bitcore.versionGuard (/opt/project/node_modules/ethereum-bip44/node_modules/bitcore-lib/index.js:12:11)
    at Object.<anonymous> (/opt/project/node_modules/ethereum-bip44/node_modules/bitcore-lib/index.js:15:9)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/opt/project/node_modules/ethereum-bip44/es5/index.js:15:19)

Hi. Im trying to test out this project and I keep getting this error when running it with node and the same error in the browser:

SyntaxError: Unexpected token import
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:404:25)
at Object.Module._extensions..js (module.js:432:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:311:12)
at Function.Module.runMain (module.js:457:10)
at startup (node.js:136:18)
at node.js:972:3

When importing ethereum-bip44 I get the error above.

I think the problem may be avoided if you move bitcore-lib from dependencies to peerDependencies in package.json:

"peerDependencies": {
    "bitcore-lib": "^0.15.0"
}

wallet.getAddress(0) gives you the wallet address which looks good. However wallet.getPrivateKey(0) gives a Buffer object. How do you get the private key in the regular (string?) format?

It seems that different wallets use different derivation paths for generating address.

I've found that with Coinomi, the derivation path should not have the "/0" at the end.
So this should be rewritten:

    this.parts = [
      `44'`, // bip 44
      `60'`,  // coin
      `0'`,  // wallet
      `0`    // 0 - public, 1 = private 
      // index
    ]

To

    this.parts = [
      `44'`, // bip 44
      `60'`,  // coin
      `0'`,  // wallet
      // index
    ]

Then the addresses match Coinomi's.

Maybe the derivation path could be made to be a parameter.

I am trying to create addresses using Mnemonic, I went to bip32.org
Got the m, info private key created wallet using EthereumBip44.fromPrivateSeed

Can you guide if this would actually work ?

Hi!
I am trying to generate a vast amount of addresses from the given master private key.
It works great in a single thread but looks like too slow (about 1000 addresses in 2 seconds).

Is it somehow possible to run this thing in a multithreaded way to speed it up?

Thanks!