translate / virtaal Goto Github PK

Source text should be disabled from editing, and should probably not have spell checking. If we have spell checking in the source, it should be English, or preferably a source language value obtained from Globals.

1) virtaal some.po
2) Add a character
3) Title bar indicates file has changed by adding *
4) Ctrl-Z # to undo the last change and return to the unedited state
5) File is still marked as changed and the user will receive warnings if they try to close it.

We should be able to track the undo stack and now when we are back to where we started with the file being edited.

We should be able to update the current file to a new project template (POT). This should simply be done with pot2po from the toolkit. Specifying an optional TM might or other options (fuzzy matching options) might be useful.

Try this:
1) Create readonly.po
2) chmod -w readonly.po
3) virtaal readonly.po
4) Edit the file
5) Ctrl-S

You will get this error:
Traceback (most recent call last):
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 323, in on_file_save
self.document.store.save()
File “/home/dwayne/dev/lm/trunk/translate/storage/base.py”, line 489, in save
fileobj = fileobj._class__(filename, “w”)
IOError: [Errno 13] Permission denied: ‘readonly.po’

We should:
1) Warn people when we open such files
2) Not allow any editing functionality
3) Allow someone to select ‘Save As…’

If virtaal is open with no document open yet, F3 results in this traceback:
Traceback (most recent call last):
File “src/virtaal/virtaal/main_window.py”, line 150, in on_search
self.document.mode_selector.select_mode_by_name(‘Search’)
AttributeError: ‘NoneType’ object has no attribute ’modeselector’

Do the following:
cat “Not an XLIFF file” > not.xlf
virtaal not.xlf

This will generate this traceback:

Traceback (most recent call last):
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 132, in
main(sys.argv)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 129, in main
runner(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 116, in default_runner
run_virtaal(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 96, in run_virtaal
prog = VirTaal(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 125, in init
self.load_file(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 214, in load_file
self.document = document.Document(filename, store=store)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/document.py”, line 100, in init
self.store = factory.getobject(filename)
File “/home/dwayne/dev/lm/trunk/translate/storage/factory.py”, line 182, in getobject
store = storeclass.parsefile(storefile)
File “/home/dwayne/dev/lm/trunk/translate/storage/base.py”, line 504, in parsefile
newstore = cls.parsestring(storestring)
File “/home/dwayne/dev/lm/trunk/translate/storage/xliff.py”, line 485, in parsestring
xliff = super(xlifffile, cls).parsestring(storestring)
File “/home/dwayne/dev/lm/trunk/translate/storage/base.py”, line 459, in parsestring
newstore.parse(storestring)
File “/home/dwayne/dev/lm/trunk/translate/storage/lisa.py”, line 321, in parse
self.document = etree.fromstring(xml).getroottree()
File “lxml.etree.pyx”, line 2385, in lxml.etree.fromstring (src/lxml/lxml.etree.c:21626)
File “parser.pxi”, line 1359, in lxml.etree.parseMemoryDocument (src/lxml/lxml.etree.c:54696)
File “parser.pxi”, line 1246, in lxml.etree.parseDoc (src/lxml/lxml.etree.c:53668)
File “parser.pxi”, line 798, in lxml.etree.BaseParser.parseDoc (src/lxml/lxml.etree.c:50996)
File “parser.pxi”, line 452, in lxml.etree.ParserContext.handleParseResultDoc (src/lxml/lxml.etree.c:48120)
File “parser.pxi”, line 536, in lxml.etree.handleParseResult (src/lxml/lxml.etree.c:48966)
File “parser.pxi”, line 478, in lxml.etree.raiseParseError (src/lxml/lxml.etree.c:48384)
lxml.etree.XMLSyntaxError: Start tag expected, ‘<’ not found, line 1, column 1

While this is a really a toolkit problem I’m placing it here so that we are aware of it for a VirTaal release. Once someone is working on it we can push it to the correct product.

If you open a .po that has nothing to do with po. try renaming a .sh to .po and opening it. Then we get this traceback:

Traceback (most recent call last):
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 168, in on_file_open
if self.open_file(filename, chooser):
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 208, in open_file
return self.load_file(filename, dialog=dialog)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 239, in load_file
self.unit_grid = unit_grid.UnitGrid(self)
File "/home/dwayne/dev/lm/trunk/virtaal/virtaal/unitgrid.py", line 67, in init
raise ValueError(_(“The file did not contain anything to translate.”))
ValueError: The file did not contain anything to translate.

Ideally we should be giving some dialogue box or at least reporting the traceback. We should be able to get back to translating in the application and not hang on the tracback.

My ideal solution. Simply open in a giant text widget and warn that this file seems not to be a PO file.

This problem is inherited from Translate Toolkit which throws an unkown filetype error like such:

Traceback (most recent call last):
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 132, in
main(sys.argv)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 129, in main
runner(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 116, in default_runner
run_virtaal(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 96, in run_virtaal
prog = VirTaal(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 125, in init
self.load_file(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 214, in load_file
self.document = document.Document(filename, store=store)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/document.py”, line 100, in init
self.store = factory.getobject(filename)
File “/home/dwayne/dev/lm/trunk/translate/storage/factory.py”, line 176, in getobject
storeclass = getclass(storefile, ignore)
File “/home/dwayne/dev/lm/trunk/translate/storage/factory.py”, line 157, in getclass
raise ValueError(“Unknown filetype (%s)” % storefilename)
ValueError: Unknown filetype (phpeg.php)

We should fail gracefully in this situation. By graceful failure I would mean:
1) Start VirTaal
2) Show a non-model warning that we could not open the file

While editing, if the mouse is clicked on the current editing area (not on a widget inside it), the row is deactivated and another row selected. Nothing should happen.

An old QM file will produce this error. This probably means that we should have a way to capture nice errors from the toolkit. And also that we think about which messages we are likely to get and how to handle each.

[dwayne@localhost storage]$ virtaal /usr/share/sqliteman/sqliteman_cs.qm
Traceback (most recent call last):
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 132, in
main(sys.argv)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 129, in main
runner(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 116, in default_runner
run_virtaal(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/bin/virtaal”, line 96, in run_virtaal
prog = VirTaal(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 125, in init
self.load_file(startup_file)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/main_window.py”, line 214, in load_file
self.document = document.Document(filename, store=store)
File “/home/dwayne/dev/lm/trunk/virtaal/virtaal/document.py”, line 100, in init
self.store = factory.getobject(filename)
File “/home/dwayne/dev/lm/trunk/translate/storage/factory.py”, line 182, in getobject
store = storeclass.parsefile(storefile)
File “/home/dwayne/dev/lm/trunk/translate/storage/base.py”, line 504, in parsefile
newstore = cls.parsestring(storestring)
File “/home/dwayne/dev/lm/trunk/translate/storage/base.py”, line 459, in parsestring
newstore.parse(storestring)
File “/home/dwayne/dev/lm/trunk/translate/storage/qm.py”, line 126, in parse
raise ValueError(“Old .qm format with no source defined”)
ValueError: Old .qm format with no source defined

This is in the toolkit but exposed through editing a very large XLIFF file generated with odf2xliff.

The first is that within lang.data::normalize we seem to be sending None values to be normalized.

Once sorted that exposed the None strings further within the pogrep searching functions.

With both fixes applied we get no further tracebacks. I’m not sure my patches are fixing the problem at the right level.

It would be nice to be able to activate the check boxes easily with mnemonics.

If you are editing a plural you can move forward using ENTER but you cannot move to previous plural lines using the keyboard.

I’m not sure what the command would be but perhaps Ctrl+Up and Ctrl+Down should work to move?

If you open a PO file with comments that contains entities e.g.

1. . “
2. : $lang[‘doublequoteopening’]

msgid ““”
msgstr ““”

Then you will get the following errors as you move between units:

~/dev/lm/trunk/virtaal/virtaal/main_window.py:369: GtkWarning: Failed to set text from markup due to error parsing markup: Error on line 1: Entity name ‘ldquo’ is not known
gtk.main()

When translating a PO file in Virtaal that has smart quotes in it, Virtaal displays it as straight quotes. If the user types ordinary straight quotes, the resultant PO file contains escaped straight quotes, not smart quotes. If the user copies the quotes from the source box, the resultant PO file does contain smart quotes correctly.

However, since the user cannot see in VirTaal which quotes are opening quotes and which ones are closing quotes, he might accidently copy an opening quote to the position of a closing quote, and this shows up in the resultant PO file.

Attached:
- original myfile.po (the original file)
- from virtaal 1 myfile.po (from VirTaal, when typed straight quotes)
- from virtaal 1 myfile.po (from VirTaal, when copied from source box)
- quotething.jpg (screenshot of original myfile.po in VirTaal)

Modes could be defined as changes in several aspects of the user interface, but for a start, it should define a list of relevant units within the current store which are considered active/relevant whereas the others are only displayed for context.

Initial types to implement (will be expanded later):
- normal translation mode (all translatable units are included)
- quick translation mode (all translatable units are included which are untranslated or fuzzy)

Think about the implications if an edit to a unit could/should remove it from the current list it is part of (translating an untranslated unit, removing the search term from a search hit)

While holding Ctrl-Down in, some cells above the current unit are not properly rendered, and is at the “editing height”

We need to drop the .locamotion directory that we are using for Virtaal.

Ideally we need a directory that can be used by all tools. Or simply name after the tool itself.

.translate-toolkit
.virtaal
.pootle
etc

If you run virtaal:

Obviously does not exist or at least is not writeable. Instead of throwing the expected exception and error the code continues as pan_app seems to not throw and error.

When opening a PO file without any headers and without the “nplurals” and “plural” fields in ~/.locamotion/virtaal.ini, the open fails with the following message: “Error opening file: ‘nplurals’”.

The problem has been isolated to the compute_nplurals() function in document.py. For some reason the ask_for_language_details() sub-function is not called.

Dwayne suggests that defaults be used in stead of asking the user, because a new user would not know what to answer.

Ctrl+Up Arrow and Ctrl+Down Arrow work correctly on opening the first file. But on opening subsequent files it fails.

To reproduce:
run_virtaal.py
File→Open→Select some file
Ctrl+UP and Ctrl+DOWN – work correctly
File→Open→Select another file
Ctrl+UP and Ctrl+DOWN now fail to work correctly

Check that we handle escapes properly:
\
\n
\t
(\r?)

Check that the files correspond to what we expect, and can also do things like \n, etc.

If a unit is fuzzy, and you then edit it, the entry should become unfuzzy. If during the course of editing a unit you manually make it fuzzy then this auto unfuzzy behaviour should not continue.

When Virtaal encounters plurals in the PO file, it displays the singular in source and the plural in target, in the edit box. See screenshot. I’m using Windows XP Pro. I also attach the PO file with which this happened.

We shouldn’t have fuzzy displayed for stores that have no ‘fuzzy’ attribute.

There are various solution/stages to solving this problem and we might want to raise separate bugs for each:

1) Don’t display it if there is no equivalent: e.g. mo has no concept of this, while XLF could be interpreted as having one especially if it is PO XLIFF variant. Wordfast also doesn’t have this concept and neither does TMX or TBX.

2) Push attributes to the storage classes and build the attribute list depending on the format being displayed. Some attributes exclude a unit from even being displayed e.g. obsolsete units in .ts and .po

It seems that sometimes the scrollbars are shown in text boxes when they shouldn’t. In particular, if the edit widget isn’t larger than the screen, the text boxes should be large enough to display all their contained text.

To fix this, simply disable text box scrollbars when the edit widget isn’t larger than the vertical screen space.

1) Open a file
2) Open another file
3) F3
Note how the labels in the check boxes are not showing.

It’s useful to copy the source text to the target text. Add a button to do this.

When opening a PO file without plural information in its headers, the plural information is read from ~/.locamotion/virtaal.ini. The information found here is then added to the PO store (store.updateheaderplural(nplurals, pluralequation), document.py:88, revision 8481). This causes the header to be displayed as the first unit and the last unit to disappear.

Although not confirmed, I believe that this is because of the fact that the store is never reloaded after the headers are added (via the updateheaderplural() call above).

This bug is related to bug #523.

Depends on:
- [x] #380 Ability to update from new project template
- [x] #645 Prompt user with ‘Save As…’ for POT files

Ideas for the help menu:
Help Menu
- Web documentation – http://translate.sourceforge.net/wiki/virtaal/index
- Localisation guide – http://translate.sourceforge.net/wiki/guide/index
- Tutorial – (copy of) local POT file
- Report a bug in VirTaal – Wiki page explaining procedure (search, information, etc.) or http://bugs.locamotion.org/enter_bug.cgi?product=VirTaal
- About

When editing an empty strings, the text box is of one line hight but it doesn’t grow when the text becomes several lines long i.e. the box is one line only and one needs to move the scroll bar up and down to see other lines. The text box should grow at least of 4 or 5 lines max. before having a scroll bar, as the current behavior makes translating long strings painful experience.

Depends on:
- [x] #477 Quotes handled incorrectly in Virtaal

Some characters are deceptively similar at small font sizes, and we should help users to distinguish between them while translating. We could solve this by packaging a useful font and using it for the source (and optionally the target) language. Eventually fonts might be configurable by the user, but we need to make good default choices.

Some candidates for better than default font use include:
- smart quotes vs normal quotes (bug #477)
- I vs l vs 1 vs |
- double spaces (perhaps using fancy ligatures to indicate them properly)
- start and end spaces

There are probably several more issues to consider, we might want to make them block this bug.

1) Open a file
2) Open another file
3) F3
Note how the labels in the check boxes are not showing.

Allow the translator to launch a URI set in the Report-Msgid-Bugs-To entry so that they can report bugs.

I would err on the easiest option which would do nothing but launch the app. It might be worth thinking about how to launch it for a specific unit. Or to allow errors to be collected and documented and then sent as a batch in an email.

By doing unit level reporting we could then str the unit and add the comments allow clear demarcation. It could present some problems in that a user might want to report each item separately to aid discussion.

Only .py files are included with setup.py sdist – it should for example include the po/ and data/ directories and their content.

If you start VirTaal with no file open then the mode selector at the bottom has an undefined label of ‘label’. I think this should be hidden if no file is open or at least should be set to the last mode that the user was using.

1. Case sensitivity
2. Light up translation units that match the search
3. Replacement functionality

If you correct an incorrect word using the spell checker dropdown then the text is not marked as changed as it should be.

Try this:
1) virtaal some.qm
2) Make a change
3) ls -l some.qm

Files size is zero.

We can read .qm files but we can’t write them.

VirTaal should be able to get info about whether we can write a given file format from the Translate Toolkit. If we are unable to write it then we should:
1) Show that the file is read only
2) Disable any editing functionality

Some basic features for navigation is needed. The idea is to make it easy and natural to navigate both in the editing area, as well as in the bigger “document”. Ideally it should be consistent, with for example Ctrl being used for intra-unit navigation (probably with the exception of Backspace and Delete).

For the editing area:
Normal editing shortcuts should remain. Things like the arrows, backspace, Ctrl+Backspace, Ctrl+Delete should all work as expected.

For intra-unit navigation
Ctrl+Up/Down – one unit up/down in the current mode
Ctrl+PgUp/PgDn – many units / a page of units up/down in the current mode
Alternatively PgUp/PgDn could just scroll visually without actually changing the cell currently edited.

We should show the different types of comments of a unit, as well as the context (where these exist).

If you are editing a plural message you cannot use the mouse to change focus to the N+1 widget.

Virtaal currently uses xdg-open and xdg-email, but this does not work on Windows and Mac OSX. Check the URL of ways of doing this better. Check specific cases, like using Firefox as default browser in KDE should not open Konqueror, etc.

To reproduce:
- Open a file
- Mark any number of non-fuzzy units as fuzzy and/or vice versa

Current behaviour:
- The file is not savable, even though it was changed.

Expected behaviour:
- The file should be savable via Ctrl+S or the “File” menu.

If the last word of a translation has a candidate completion with autocomplete, pressing enter will accept the suggested completion and submit the translation.

Scenario:
Translate this program
Vertaal hierdie program
If Virtaal suggests “programme”, the suggestion is accepted, even though it wasn’t accepted with the tab key, and Virtaal already advanced onto the next unit.

Plumbing changes broke the undo functionality.

The following files/dirs are missing from the Virtaal tarball:
- LICENSE
- po/
- maketranslations – builds the translated mimetypes and desktop file

Make sure that there are no complications arising from the use of gtkspell.